[Bug 24839] New: branchtransfers does not deal with holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 Bug ID: 24839 Summary: branchtransfers does not deal with holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com This code looks to have been broken for some time, we check reserves, but we don't pass the variable back to the script -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100459&action=edit Bug 24839: Return hold info to transfer script and set borrowernumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100460&action=edit Bug 24839: unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100459|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100461&action=edit Bug 24839: Return hold info to transfer script and set borrowernumber To test: 1 - Place a hold on an item 2 - Go to Circulation->Transfers 3 - Attempt to transfer item to a branch it is not expected at 4 - No warning 5 - Apply patches 6 - Repeate 7 - You get a notice that there is a hold and must deal with the hold (or ignore) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24620 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620 [Bug 24620] Existing transfers not closed when hold is set to waiting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100460|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 100481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100481&action=edit Bug 24839: unit tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100461|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 100482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100482&action=edit Bug 24839: Return hold info to transfer script and set borrowernumber To test: 1 - Place a hold on an item 2 - Go to Circulation->Transfers 3 - Attempt to transfer item to a branch it is not expected at 4 - No warning 5 - Apply patches 6 - Repeate 7 - You get a notice that there is a hold and must deal with the hold (or ignore) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- transferbook is also called in rotating collections.. should the return value be used there too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100481|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100542&action=edit Bug 24839: unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100482|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100543&action=edit Bug 24839: Return hold info to transfer script and set borrowernumber To test: 1 - Place a hold on an item 2 - Go to Circulation->Transfers 3 - Attempt to transfer item to a branch it is not expected at 4 - No warning 5 - Apply patches 6 - Repeate 7 - You get a notice that there is a hold and must deal with the hold (or ignore) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Martin Renvoize from comment #6)
transferbook is also called in rotating collections.. should the return value be used there too?
I think this can be handled in a follow-up bug report as currently Rotating Collections just ignores the response from transfer book entirely. At some point soon I'd really like to actually see transferbook removed and the Koha Objects alternative used.. but that's down the line.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100544&action=edit Bug 24839: (QA follow-up) Remove unused variables Whilst QAing I spotted a couple of unused variables in the test.. no harm in removing them ;) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.05 released in| | --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- tests would need to be rebased if this is needed in 19.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org