https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 99926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99926&action=edit Bug 24777: Use patron.is_debarred instead of patron.debarred in return.tt In return page return.tt, when there is an hold message, patron is said as restricted even if restriction end date is in the past. Test plan : 1) For a patron Jon Doe create a manual restriction with end date in the past 2) Create an hold for this patron on an item 3) Check in this item => You don't see message "Patron is RESTRICTED" 4) For a patron Kevin Doe create a manual restriction with end date in the future 5) Create an hold for this patron on an item 6) Check in this item => You see message "Patron is RESTRICTED" 7) Repeate 1-6 with system preference HoldsAutoFill enabled 8) Repeate 1-6 with a waiting hold -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99926|0 |1 is obsolete| | --- Comment #2 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 100276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100276&action=edit Bug 24777: Use patron.is_debarred instead of patron.debarred in return.tt In return page return.tt, when there is an hold message, patron is said as restricted even if restriction end date is in the past. Test plan : 1) For a patron Jon Doe create a manual restriction with end date in the past 2) Create an hold for this patron on an item 3) Check in this item => You don't see message "Patron is RESTRICTED" 4) For a patron Kevin Doe create a manual restriction with end date in the future 5) Create an hold for this patron on an item 6) Check in this item => You see message "Patron is RESTRICTED" 7) Repeate 1-6 with system preference HoldsAutoFill enabled 8) Repeate 1-6 with a waiting hold Signed-off-by: Devinim <nazli@devinim.com.tr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100276|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100457&action=edit Bug 24777: Use patron.is_debarred instead of patron.debarred in return.tt In return page return.tt, when there is an hold message, patron is said as restricted even if restriction end date is in the past. Test plan : 1) For a patron Jon Doe create a manual restriction with end date in the past 2) Create an hold for this patron on an item 3) Check in this item => You don't see message "Patron is RESTRICTED" 4) For a patron Kevin Doe create a manual restriction with end date in the future 5) Create an hold for this patron on an item 6) Check in this item => You see message "Patron is RESTRICTED" 7) Repeate 1-6 with system preference HoldsAutoFill enabled 8) Repeate 1-6 with a waiting hold Signed-off-by: Nazlı Çetin <nazli@devinim.com.tr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- doesnt apply clean to 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.