[Bug 37728] New: More "op" are missing in POSTed forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug ID: 37728 Summary: More "op" are missing in POSTed forms Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org xt/find-missing-op-in-forms.t is missing some occurrences. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170701&action=edit Bug 37728: Adjust test to catch more missing 'op' in POSTed forms The test is not catching missing op in forms that are not the first POST form of the template. Found when fixing the test for bug 37309. It was not catching the missing op in the second form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |katrin.fischer@bsz-bw.de, | |nick@bywatersolutions.com --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- So this is certainly hiding... more than 20 bugs. not ok 1 - The <form> in the following files are missing it's corresponding op parameter, or op does not start with 'cud-' (see bug 34478) # Failed test 'The <form> in the following files are missing it's corresponding op parameter, or op does not start with 'cud-' (see bug 34478)' # at xt/find-missing-op-in-forms.t line 43. # got: '20' # expected: '0' # $VAR1 = 'koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt:260,293'; # $VAR2 = 'koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt:110'; # $VAR3 = 'koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt:152'; # $VAR4 = 'koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt:808'; # $VAR5 = 'koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt:327'; # $VAR6 = 'koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt:150,182'; # $VAR7 = 'koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt:209,270'; # $VAR8 = 'koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt:206,236'; # $VAR9 = 'koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt:183,205'; # $VAR10 = 'koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt:382'; # $VAR11 = 'koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt:333'; # $VAR12 = 'koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt:217'; # $VAR13 = 'koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt:292,302'; # $VAR14 = 'koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt:290'; # $VAR15 = 'koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt:294'; # $VAR16 = 'koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt:191'; # $VAR17 = 'koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:1443'; # $VAR18 = 'koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt:152'; # $VAR19 = 'koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt:248,274'; # $VAR20 = 'koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:547,589'; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37309 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36192 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov, | |tomascohen@gmail.com Keywords| |RM_priority --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not good, but good that we caught them now. Who can work on resolving these? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- I can help, but not let alone. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|36192 | Depends on| |36192 --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- I can't do things like opac-illrequests.tt which would require that I spend several hours of my employer's money learning how to write a test plan for something we don't use, but I can do some of them. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37765 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37765 [Bug 37765] Fix forms that POST without an op in systempreferences -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37766 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37766 [Bug 37766] Fix forms that POST without an op in MARC bibliographic frameworks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37767 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37767 [Bug 37767] Fix forms that POST without an op in Authority types -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37768 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37768 [Bug 37768] Fix form that POSTs without an op in itemtype administration -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37769 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37769 [Bug 37769] Fix forms that POST without an op in currency administration -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #6 from Phil Ringnalda <phil@chetcolibrary.org> --- Wish I would have realized how many of these were "a cancel deletion button which should be a GET, and an OK button in a deletion confirmed page which currently doesn't even show but should be a GET" before I filed them as separate bugs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Thanks, Phil. Much appreciated! You've been killing it lately :D. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #3)
Who can work on resolving these?
I'll help out as well. I'm a bit worried about the stability of 24.05 and the upcoming 24.11, so I the present is a great time to get as much done as we can. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37779 [Bug 37779] Fix forms that POST without an op in tag moderation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #9 from Phil Ringnalda <phil@chetcolibrary.org> --- Not quite sure what to do with koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:1443 - JS inserts the op in the form in line 1859, and the form won't work without JS since it's also inserting the reserve_id, and without a reserve_id you aren't going to cancel. Do we just stick the op in normally instead of inserting it, to make the test happy? Or is there a reason I'm not seeing that it needs to be inserted by JS? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #10 from Phil Ringnalda <phil@chetcolibrary.org> --- And although I was thinking of sticking it in normally right below the CSRF token, it would actually be much funnier to stick it in the empty <div id="inputs"> in the template, which would make the test happy, and then the very first thing the JS does is to empty() that div, so it can stay happy about putting in the op itself. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37783 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37783 [Bug 37783] Fix form that looks like it would POST without an op in reserve/request.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #11 from Phil Ringnalda <phil@chetcolibrary.org> --- Asked that question in the form of a Needs Signoff in bug 37783. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37785 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37785 [Bug 37785] Remove dead code in tools/letter.tt that looks like a form that would POST without an op -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37786 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37794 [Bug 37794] Fix form that POSTs without an op in Holds to pull -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #12 from Phil Ringnalda <phil@chetcolibrary.org> --- Current status after applying the patch and following dependencies (minus the one that's filed but not patched): # $VAR1 = 'koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt:260,293'; # $VAR2 = 'koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt:110'; # $VAR3 = 'koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt:152'; # $VAR4 = 'koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt:808'; # $VAR5 = 'koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt:327'; # $VAR6 = 'koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt:150,182'; # $VAR7 = 'koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt:209,270'; # $VAR8 = 'koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt:294'; # $VAR10 = 'koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt:152'; I don't have any current plans to touch those, since they are in areas where I don't know either the code or the UI, so they are up for grabs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Phil, awesome job! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #14 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- I can grab the acquisitions ones. I'll see if I have time to SO/QA some of yours after (the day got away from me... D:) Thanks for jumping on so many, Phil! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37797 [Bug 37797] Choosing not to delete a budget does not need to be a form submission -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37823 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37823 [Bug 37823] Remove unreachable code in aqcontract.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37827 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37827 [Bug 37827] Switch OPAC download list form from POST to GET -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37853 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37853 [Bug 37853] Returning to your account at the end of changing your password in the OPAC doesn't need to POST a form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #15 from Phil Ringnalda <phil@chetcolibrary.org> --- Shame I can't write a test plan for the opac-illrequests.tt one, because it looks like the patch would be an amusing [%# This will get its name="op" value="cud-" from the loop over whole.keys below %] to fake out the test. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should this be NSO? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #17 from Phil Ringnalda <phil@chetcolibrary.org> --- I could trivially sign off that it catches more missing 'op' in POSTed forms, but I can't sign off that it passes when there aren't any, since I haven't seen that. # $VAR1 = 'koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt:260,293'; # $VAR2 = 'koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt:152'; # $VAR3 = 'koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt:167'; # $VAR4 = 'koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt:209,270'; # $VAR5 = 'koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt:294'; # $VAR6 = 'koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt:158'; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37887 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37887 [Bug 37887] OPAC password recovery needs to use a cud- op while POSTing new password -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37913 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37913 [Bug 37913] Remove more unreachable code in aqcontract.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37914 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37914 [Bug 37914] Forms for budget planning filters and export should GET rather than POST -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #18 from Phil Ringnalda <phil@chetcolibrary.org> --- Seriously, I'm done. Somebody take these. # $VAR1 = 'koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt:260,293'; Requires having an ILL backend that does availability and knowing how to get to typedisclaimer and how to write a test plan so someone else can. # $VAR2 = 'koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt:294'; Requires knowing how to write an installer test plan, and knowing what on earth it's using to keep track of substeps. # $VAR3 = 'koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt:158'; Should be easy for someone who uses serials-collection, and thus knows whether it needs to keep POSTing because sometimes you do stuff to so many things at once that you exceed Apache's URL maxlength if it's a GET, or not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks a lot for your work, Phil! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37981 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37981 [Bug 37981] Switch installer/ste3.tt form from POST to GET -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37982 [Bug 37982] Serial collection edit form can be GET -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m Depends on| |37981, 37982 Blocks|37981, 37982 | --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Phil Ringnalda from comment #18)
Seriously, I'm done. Somebody take these.
# $VAR1 = 'koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt:260,293';
Requires having an ILL backend that does availability and knowing how to get to typedisclaimer and how to write a test plan so someone else can.
Not familiar with this, Pedro maybe?
# $VAR2 = 'koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt:294';
Requires knowing how to write an installer test plan, and knowing what on earth it's using to keep track of substeps.
Done on bug 37981.
# $VAR3 = 'koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt:158';
Should be easy for someone who uses serials-collection, and thus knows whether it needs to keep POSTing because sometimes you do stuff to so many things at once that you exceed Apache's URL maxlength if it's a GET, or not.
Done on bug 37982. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37981 [Bug 37981] Switch installer/ste3.tt form from POST to GET https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37982 [Bug 37982] Serial collection edit form can be GET -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #21 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #20)
(In reply to Phil Ringnalda from comment #18)
Seriously, I'm done. Somebody take these.
# $VAR1 = 'koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt:260,293';
Requires having an ILL backend that does availability and knowing how to get to typedisclaimer and how to write a test plan so someone else can.
Not familiar with this, Pedro maybe?
op is added dynamically in the following code: [% FOREACH key IN whole.keys %] [% value = whole.$key %] [% IF key != 'custom_key' && key != 'custom_value' && key != 'csrf_token' %] <input type="hidden" name="[% key | html %]" value="[% value | html %]"> [% END %] [% END %] op is part of the 'whole' sent by availability_template_params in Koha::ILL::Request::Workflow::Availability These hidden form inputs are added dynamically because we want to move all the params from the previous form to the next, the same logic applies for the type disclaimer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #22 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 171912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171912&action=edit Bug 37728: (follow-up) Tell the test that opac-illrequests.tt has an op xt/find-missing-op-in-forms.t wants to see name="op" value="cud-..." in any form with method="post", but opac-illrequests.tt inserts its op input by passing around whole and unpack and repacking whole.keys which includes the op. We just need to tell the test that it really exists. At first, I thought of this approach as a joke, faking out the test, but when I tried to be more responsible and put a whole <input type="hidden" etc. in the comment, I realized that would be more likely to confuse someone who thought that was uncommented and that they were making real changes than it would be to future-proof against changes in the test's approach. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170701|0 |1 is obsolete| | --- Comment #23 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 171913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171913&action=edit Bug 37728: Adjust test to catch more missing 'op' in POSTed forms The test is not catching missing op in forms that are not the first POST form of the template. Found when fixing the test for bug 37309. It was not catching the missing op in the second form. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Phil Ringnalda from comment #22)
Created attachment 171912 [details] [review] Bug 37728: (follow-up) Tell the test that opac-illrequests.tt has an op
xt/find-missing-op-in-forms.t wants to see name="op" value="cud-..." in any form with method="post", but opac-illrequests.tt inserts its op input by passing around whole and unpack and repacking whole.keys which includes the op. We just need to tell the test that it really exists.
At first, I thought of this approach as a joke, faking out the test, but when I tried to be more responsible and put a whole <input type="hidden" etc. in the comment, I realized that would be more likely to confuse someone who thought that was uncommented and that they were making real changes than it would be to future-proof against changes in the test's approach.
lol, well, why not! The test will need to stay as silly as it is now :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171912|0 |1 is obsolete| | Attachment #171913|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171916&action=edit Bug 37728: (follow-up) Tell the test that opac-illrequests.tt has an op xt/find-missing-op-in-forms.t wants to see name="op" value="cud-..." in any form with method="post", but opac-illrequests.tt inserts its op input by passing around whole and unpack and repacking whole.keys which includes the op. We just need to tell the test that it really exists. At first, I thought of this approach as a joke, faking out the test, but when I tried to be more responsible and put a whole <input type="hidden" etc. in the comment, I realized that would be more likely to confuse someone who thought that was uncommented and that they were making real changes than it would be to future-proof against changes in the test's approach. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171917&action=edit Bug 37728: Adjust test to catch more missing 'op' in POSTed forms The test is not catching missing op in forms that are not the first POST form of the template. Found when fixing the test for bug 37309. It was not catching the missing op in the second form. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- I think we can consider this signed off now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #28 from Phil Ringnalda <phil@chetcolibrary.org> --- Just 3 more QAs, 2 pushes, and 1 security release, and we can land this two-line test change :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171916|0 |1 is obsolete| | --- Comment #29 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171922&action=edit Bug 37728: (follow-up) Tell the test that opac-illrequests.tt has an op xt/find-missing-op-in-forms.t wants to see name="op" value="cud-..." in any form with method="post", but opac-illrequests.tt inserts its op input by passing around whole and unpack and repacking whole.keys which includes the op. We just need to tell the test that it really exists. At first, I thought of this approach as a joke, faking out the test, but when I tried to be more responsible and put a whole <input type="hidden" etc. in the comment, I realized that would be more likely to confuse someone who thought that was uncommented and that they were making real changes than it would be to future-proof against changes in the test's approach. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171917|0 |1 is obsolete| | --- Comment #30 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171923&action=edit Bug 37728: Adjust test to catch more missing 'op' in POSTed forms The test is not catching missing op in forms that are not the first POST form of the template. Found when fixing the test for bug 37309. It was not catching the missing op in the second form. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |pedro.amorim@ptfs-europe.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 --- Comment #32 from Phil Ringnalda <phil@chetcolibrary.org> --- Are we going to try to get this and its dependencies into 24.05, or just call 24.11 enough protection? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37786, which changed state. Bug 37786 Summary: members/cancel-charge.pl needs CSRF protection https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37786 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37768, which changed state. Bug 37768 Summary: Fix form that POSTs without an op in itemtype administration https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37768 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37783, which changed state. Bug 37783 Summary: Fix form that looks like it would POST without an op in reserve/request.tt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37783 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37765, which changed state. Bug 37765 Summary: Fix forms that POST without an op in systempreferences https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37765 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37785, which changed state. Bug 37785 Summary: Remove dead code in tools/letter.tt that looks like a form that would POST without an op https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37785 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED --- Comment #33 from Phil Ringnalda <phil@chetcolibrary.org> --- Looks like that ship has sailed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37779, which changed state. Bug 37779 Summary: Fix forms that POST without an op in tag moderation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37779 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37797, which changed state. Bug 37797 Summary: Choosing not to delete a budget does not need to be a form submission https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37797 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37767, which changed state. Bug 37767 Summary: Fix forms that POST without an op in Authority types https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37767 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37769, which changed state. Bug 37769 Summary: Fix forms that POST without an op in currency administration https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37769 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37913, which changed state. Bug 37913 Summary: Remove more unreachable code in aqcontract.tt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37913 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37887, which changed state. Bug 37887 Summary: OPAC password recovery needs to use a cud- op while POSTing new password https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37887 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37853, which changed state. Bug 37853 Summary: Returning to your account at the end of changing your password in the OPAC doesn't need to POST a form https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37853 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37827, which changed state. Bug 37827 Summary: Switch OPAC download list form from POST to GET https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37827 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37766, which changed state. Bug 37766 Summary: Fix forms that POST without an op in MARC bibliographic frameworks https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37766 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37794, which changed state. Bug 37794 Summary: Fix form that POSTs without an op in Holds to pull https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37794 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37914, which changed state. Bug 37914 Summary: Forms for budget planning filters and export should GET rather than POST https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37914 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 36192, which changed state. Bug 36192 Summary: [OMNIBUS] CSRF Protection for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37982, which changed state. Bug 37982 Summary: Serial collection edit form can be GET https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37982 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37981, which changed state. Bug 37981 Summary: Switch installer/step3.tt form from POST to GET https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37981 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728 Bug 37728 depends on bug 37823, which changed state. Bug 37823 Summary: Remove unreachable code in aqcontract.tt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37823 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org