[Bug 8172] New: Missing dereference marker for buildQuery parameter in addbooks.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 Priority: P5 - low Change sponsored?: --- Bug ID: 8172 Assignee: gmcharlt@gmail.com Summary: Missing dereference marker for buildQuery parameter in addbooks.pl Severity: major Classification: Unclassified OS: All Reporter: mtompset@hotmail.com Hardware: All Status: NEW Version: unspecified Component: Searching Product: Koha my ( $builterror,$builtquery,$simple_query,$query_cgi,$query_desc,$limit,$limit_cgi,$limit_desc,$stopwords_removed,$query_type) = buildQuery(\@operators,\@operands,\@indexes,@limits,\@sort_by,undef,undef); Which is roughly line 75 of addbooks.pl likely should have a \ on the @limits. Because C4::Search.pm around line 1044 shows the parameters being treated the same. I was hoping this would solve my Lingua::Stem::Snowball error, but I will have to continue to hunt deeper. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- I was looking originally at 3.6.3. I downloaded 3.8.1 and confirmed this bug exists in it as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 10564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10564&action=edit Added a missing dereference marker for an array parameter. As our library has been adding and editing lots of items, I have yet to see the bug resurface. I think the patch is self-evident. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10564|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 10576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10576&action=edit Bug 8172 - Missing dereference marker for buildQuery parameter in addbooks.pl Added a dereference to an array parameter of buildQuery. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10606&action=edit Bug 8172: Followup: Removes useless empty params QA Comment, Your patch is good, but I think this one adds more readability (It removes empty params passed to buildQuery). On the way, I replace an undefined variable ($debug with $DEBUG) in C4/Search.pm (introduces by the same commit 59f31b98361046af37646485f652f70e16a2e206, Bug 4116). Switch back to need signed off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10606|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11372&action=edit Bug 8172: Followup: Removes useless empty params Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Simple patch, Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable CC| |paul.poulain@biblibre.com Version|unspecified |rel_3_8 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Pushed to master today. Already in stable, so status set accordingly -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org