http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Savitra Sirohi <savitra.sirohi@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move autoi member |Move auto member cardnumber |cardnumber generation to |generation to occur when |occur when record is |record is "Saved" |"Saved" | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson@biblibre.com --- Comment #1 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- Confirmed. The method described by Savitra is the way it works when generating barcodes for items and it should indeed be the one used to generate card numbers as well. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Savitra Sirohi <savitra.sirohi@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Meenakshi <meenakshi.r@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- Michael, you can choose which fields are mandatory in the BorrowerMandatoryField syspref, cardnumber is mandatory by default. So with this patch if you activate autoMemberNum then you need to remove cardnumber form BorrowerMandatoryField. I would say either we just add it in the text that goes with the syspref : "Do / Don't default the card number field on the patron addition screen to the next available card number (for example, if the largest currently used card number is 26345000012941, then this field will default to 26345000012942). ++Remember to remove cardnumber from the BorrowerMandatoryField syspref if you switch this on++", or we remove it from BorrowerMandatoryField's default value (i think this would be a bad idea), or we find a way to bypass the mandatory behaviour on this field when autoMemberNum is on (This sounds like a complicated idea). I'll sign this off for now, and leave it to the QA team to decide wether we need to add something to make things clearer. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7068 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: some Perl comments: + if(C4::Context->preference("autoMemberNum")) { + if ($data{'cardnumber'} eq '') { + $data{'cardnumber'}= fixup_cardnumber($data{'cardnumber'},C4::Context->userenv->{'branch'}, $data{'categorycode'}); + } + } => you should write + if (C4::Context->preference("autoMemberNum") && $data{'cardnumber'} eq '') { + $data{'cardnumber'}= fixup_cardnumber($data{'cardnumber'},C4::Context->userenv->{'branch'}, $data{'categorycode'}); + } and +if (C4::Context->preference("autoMemberNum")) { + $template->param( autoMemberNum => 1); +} else { + $template->param( autoMemberNum => 0); +} could be set + $template->param( autoMemberNum => C4::Context->preference("autoMemberNum")); Marking failed QA for that reason, please fix & resubmit, i'll push quickly -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.