[Bug 6458] New: incorrect parsing result in translation processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Bug #: 6458 Summary: incorrect parsing result in translation processing Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: I18N/L10N AssignedTo: frederic@tamil.fr ReportedBy: semarie-koha@latrappe.fr QAContact: koha-bugs@lists.koha-community.org The translation processing issue no error (translate install fr-FR), but the resulting page for almost one template is incorrect (I don't speak about translated string, but structure of resulting file). In 'koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt', line 135: <input type="button" value="Renew Item" [% UNLESS ( renew ) %] name="confirm"[% END %] class="renew" onclick="this.form.confirmed.value='1';this.form.submit();" /> The result, 'koha-tmpl/opac-tmpl/prog/fr-FR/modules/sco/sco-main.tt', line 88: <input value="Renouveler document" name="confirm" unless="UNLESS" %]="%]" renew="renew" end="END" )=")" type="button" onclick="this.form.confirmed.value='1';this.form.submit();" class="renew" (="(" [%="[%" /> This kind of error arrived two times in 'sco/sco-main.tt'. Note: The result is in reality more complex: 7 lines of 'en' template are mixed in 1 line in 'fr-FR' result template. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #1 from Frère Sébastien Marie <semarie-koha@latrappe.fr> 2011-06-05 12:12:24 UTC --- It seems the problem is in 'misc/translator/TTParser.pm', in the processing of tag (function 'start', for handling opening html tags). It isn't expected to have "template text" at the tag level: <tagname attr1="value1" templateText attr2="value2" ...> So TTParser interprete this as: <tagname attr1="value1" templateText="templateText" attr2="value2" ...> In the reported example: <input type="button" value="Renew Item" [% UNLESS ( renew ) %] name="confirm"[% END %] class="renew" onclick="this.form.confirmed.value='1';this.form.submit();" /> TTParser read as: tagname=input attributes = { In template, the two only occurrences I found in this scheme are in 'modules/sco/sco-main.tt'... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #2 from Frère Sébastien Marie <semarie-koha@latrappe.fr> 2011-06-05 12:15:50 UTC --- sorry for comments before: tabulation don't work well in textarea, and the next focused item is 'Save Changes' button... Redo : <input type="button" value="Renew Item" [% UNLESS ( renew ) %] name="confirm"[% END %] class="renew" onclick="this.form.confirmed.value='1';this.form.submit();" /> TTParser read as: tagname=input attributes = { type = "button", value = "Renew Item", [% = "[%", unless = "UNLESS", %] = "%]", ... } The re-ordoring at the end is due to order in hashtable... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #3 from Frère Sébastien Marie <semarie-koha@latrappe.fr> 2011-06-05 13:53:00 UTC --- I have found few others cases with Template Directive in tag, but where there are not problem with transformation. - in 'opac-user.tt' <tr[% IF ( overdue ) %] class="overdue"[% END %]> - in 'opac-detail.tt' <li[% IF ( defaulttab == 'subscriptions' ) %] class="ui-tabs-selected"[% END %]> The difference seems to be that here, there are not string to be translated. So problem may be corrected in 'tmpl_process3.pl': function 'text_replace_tag'. Currently, if translation is found, the HTML element is "rewrited" based on attributes parsed (where directives are not tagged as DIRECTIVE, and in HASHTABLE [so order is lost]). So two solutions: - work in 'TTParser.pm' for correctly tag DIRECTIVE in tag-element, and processing accordingly in 'text_replace_tag' - work in 'tmpl_process3.pl' for another method (like regex, but it not a very strong method...) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #4 from Frère Sébastien Marie <semarie-koha@latrappe.fr> 2011-07-19 09:50:52 UTC --- here, a discussion about his problem: http://lists.koha-community.org/pipermail/koha-devel/2011-July/035917.html -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> 2011-07-21 06:48:12 UTC --- (In reply to comment #4)
here, a discussion about his problem: http://lists.koha-community.org/pipermail/koha-devel/2011-July/035917.html
Could list html tags within which TT directives can be found? I would like to port your test case, bug I'm not very fluent in haskell... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #6 from Frère Sébastien Marie <semarie-koha@latrappe.fr> 2011-07-21 07:12:56 UTC --- Currently, the parser search the string "[%" in *every* HTML tag. But it isn't a HTML parser. It just track when the string "[%" in placed after the string "<" (and not ">" between "<" and "[%"), and not between two string '"'. (but need to track also CDATA and COMMENT because of false-positive else). It follow a *very simplified* HTML syntax for parsing. It is relatively simple (and commented), and based on a "context" concept: it just defined rules for enter in a "context", and to change the "context", when a specific string is encounter. For the INITIAL context (the default one): - when "<![CDATA[" string is encounter: go in CDATA context - when "<!--" string is encounter: go in COMMENT context - when "<" string encounter: go in TAG context For the TAG context: - when encounter the string '"' : enter in STRING context - when encounter the string "[%" : mark a problem, as a template directive is found in tag, but not in an attribute (because an attribute is a STRING context) - when encounter the string ">": go in INITIAL context For the STRING context: - when encounter the string '\"' : keep the STRING context - when encounter only the string '"' : go in TAG context (in CDATA context, how to go in INITIAL context : "]]>" encounter ; or in COMMENT context: "-->" ) That's all... (but the parser keep track the line number for reporting). I hope I answer your question, and that I have clarified how work the parser... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #7 from Frédéric Demians <frederic@tamil.fr> 2011-07-21 08:28:36 UTC --- Created attachment 4695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4695 Proposed patch Could you try this test case and check that it detects the appropriate TT issues? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #8 from Frère Sébastien Marie <semarie-koha@latrappe.fr> 2011-07-21 09:36:24 UTC --- (In reply to comment #7)
Created attachment 4695 [details] Proposed patch
Could you try this test case and check that it detects the appropriate TT issues?
Issues are incomplete: haskell version report 269 issues in 45 files, versus perl 34 issues in 14 files. The list could be consulted here: http://lists.koha-community.org/pipermail/koha-devel/2011-July/035922.html , in the attachment (but *.inc are not included, and "269 in 45 files" is the last count on master repo) There are multiples problems with this perl version: - it is line oriented versus stream oriented. So in case of opening tag on one line, and inclusion of directive in other line, the issue is not reported. (for examples: see ./koha-tmpl/opac-tmpl/prog/en/modules/opac-messaging.tt, line 74 see ./koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc, line 42 ) - it only check directive near the tagname (like <li[%IF ), and not more general construct (like <option value="10"[%IF ) (for examples: see ./koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt, line 135 see ./koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt, line 91 ) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #9 from Frédéric Demians <frederic@tamil.fr> 2011-07-21 10:38:04 UTC ---
There are multiples problems with this perl version:
You're correct. I have no solution in Perl, neither time. We have TTParser module. So we should use it to parse properly templates and identify invalid constructions. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Change sponsored?|--- |Seeking developer -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4695|0 |1 is obsolete| | --- Comment #10 from Frédéric Demians <frederic@tamil.fr> 2011-07-21 11:06:25 UTC --- Created attachment 4697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4697 Amended proposed patch Please try this new version of test case. It uses TTParser. Tell me if more invalid constructions are found. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4697|0 |1 is obsolete| | --- Comment #11 from Frédéric Demians <frederic@tamil.fr> 2011-07-21 11:44:28 UTC --- Created attachment 4699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4699 Proposed patch (2) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #12 from Frère Sébastien Marie <semarie-koha@latrappe.fr> 2011-07-23 08:28:56 UTC --- (In reply to comment #11)
Created attachment 4699 [details] Proposed patch (2)
This version works very well. There are some differences between the haskell version and the perl one, but there are not generally problematic: - problems not related of TT template - haskell version report also problems with CDATA section, partial quoting attribute (and a false-positive for use of single-quoting in attributes) - differences but not a problem - haskell version report multiple errors for a tag (if multiple directive inclusion) - haskell version report line number of the directive, although perl version report line number of the beginning of tag with directive. The only amelioration to do, is to include the *.inc for parsing: some of them included directive in tag... else perfect ! So in don't sign-off, waiting the corrected version; and I also need more time to check for side-effect due to move of TTParser files in C4. Thanks. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4699|0 |1 is obsolete| | --- Comment #13 from Frédéric Demians <frederic@tamil.fr> 2011-07-23 14:40:32 UTC --- Created attachment 4729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4729 Proposed patch for testing and signing off With the last proposed patch, .inc files are also validated. I agree that moving translation modules into C4 requires some testing. I've tested using standard translation tools: ./translate create | update | install. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4729|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-11 16:07:36 UTC --- Created attachment 4968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4968 [SIGNED-OFF] Bug 6458 Template Toolkit files test case This test validate Template Toolkit (TT) Koha files. For the time being an unique validation is done: Test if TT files contain TT directive within HTML tag. For example: <li[% IF This kind of constuction MUST be avoided because it break Koha translation process. This patch transform also translation specific modules into C4 modules in order to be able to use them in test case: C4::TTPaser C4::TmplToken C4::TmplTokenType This patch is a Perl adaptation of a Haskell script from Frère Sébastien Marie. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Notes on testing: - translate install de-DE - worked ok - translate update de-DE > translate install de-DE - worked ok - running the test xt/tt_valid.t - worked ok and pointed out lots of problems. Found no problems. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-18 09:13:46 UTC --- Pushed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 MJ Ray (software.coop) <mjr@ttllp.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mjr@ttllp.co.uk -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-20 16:34:11 UTC --- Created attachment 5070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5070 Bug 6458: Incorrect parsing result in translation processing Patch removes template directives from within HTML tags from OPAC detail view. Problems were related to the items tabs for holdings, subscriptions, and serial collection. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-20 17:05:17 UTC --- Created attachment 5071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5071 Bug 6458: Incorrect translation processing / sco-main.tt Patch removes templates directives from HTML tags in sco-main.tt Problems were related to buttons for renewing items. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-20 17:44:12 UTC --- Created attachment 5072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5072 Bug 6458: Incorrect translation processing - masthead.inc Patch removes templates directives from HTML tags in masthead.inc Problem was related to library pull down shown when OpacAddMastheadLibraryPulldown is activated. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-21 22:14:01 UTC --- Created attachment 5074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5074 Bug 6458: Incorrect translation processing - doc-head-close/open.inc Patch removes templates directives from HTML tags in masthead.inc -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4968|0 |1 is obsolete| | Attachment #5070|0 |1 is obsolete| | --- Comment #20 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-22 03:46:21 UTC --- Created attachment 5078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5078 Bug 6458: Incorrect parsing result in translation processing Patch removes template directives from within HTML tags from OPAC detail view. Problems were related to the items tabs for holdings, subscriptions, and serial collection. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Before patch opac-tmpl/prog/en/modules/opac-detail.tt: 325, 353, 369 After, no errors for opac-detail.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5071|0 |1 is obsolete| | --- Comment #21 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-22 03:48:02 UTC --- Created attachment 5079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5079 Bug 6458: Incorrect translation processing / sco-main.tt Patch removes templates directives from HTML tags in sco-main.tt Problems were related to buttons for renewing items. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Before opac-tmpl/prog/en/modules/sco/sco-main.tt: 135, 222 After, no errors -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5072|0 |1 is obsolete| | --- Comment #22 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-22 03:49:10 UTC --- Created attachment 5080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5080 Bug 6458: Incorrect translation processing - masthead.inc Patch removes templates directives from HTML tags in masthead.inc Problem was related to library pull down shown when OpacAddMastheadLibraryPulldown is activated. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Before opac-tmpl/prog/en/includes/masthead.inc: 83 After no errors -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #23 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-22 03:52:00 UTC --- I have signed off on 3 of these patches, but the doc-head-close and open still needs a bit more work Before # opac-tmpl/prog/en/includes/doc-head-close.inc: 41, 77 # opac-tmpl/prog/en/includes/doc-head-open.inc: 3 After # opac-tmpl/prog/en/includes/doc-head-close.inc: 80 So still needs some work -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #24 from Frère Sébastien Marie <semarie-koha@latrappe.fr> 2011-08-22 04:34:58 UTC --- Comment on attachment 5078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5078 Bug 6458: Incorrect parsing result in translation processing Hi, The patch on 'opac-detail.tt' don't preserve the semantic, of original IF/ELSE clause: in the correction the IF clause and the ELSE clause are the same... The code is currently: +[% IF ( defaulttab == 'holdings' ) %]<li class="ui-tabs-selected"> +[% ELSE %]<li class="ui-tabs-selected">[% END %] But it should be: +[% IF ( defaulttab == 'holdings' ) %]<li class="ui-tabs-selected"> +[% ELSE %]<li>[% END %] The same problem occurs for all corrections in opac-detail.tt (but others patchs seems good). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5074|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-22 06:25:32 UTC --- Created attachment 5081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5081 Bug 6458: Incorrect translation processing - doc-head-close/open.inc Patch removes templates directives from HTML tags in masthead.inc Fixes all 3 problems now. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5078|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-22 06:30:42 UTC --- Created attachment 5082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5082 Bug 6458: Incorrect translation processing / opac-detail.tt Patch removes template directives from within HTML tags from OPAC detail view. Problems were related to the items tabs for holdings, subscriptions, and serial collection. Fixed the problem spotted by Frère Sébastien Marie - thx! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-22 20:49:30 UTC --- Created attachment 5090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5090 Bug 6458: Incorrect translation processing / overdue.tt Patch removes template directives from within HTML tags from circulation > overdues. Problems were related to patron flags pull down and sort by loop for patron attributes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-22 21:01:22 UTC --- Created attachment 5091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5091 Bug 6458: Incorrect translation processing / review.tt Patch removes template directives from within HTML tags from Tools > Tags. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-22 21:17:15 UTC --- Created attachment 5092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5092 Bug 6458: Incorrect translation processing / authorities.tt Patch removes template directives from within HTML tags from authorities > modify authority. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-22 21:29:12 UTC --- Created attachment 5093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5093 Bug 6458: Incorrect translation processing / 3x reports/... Patch removes template directives from within HTML tags from - Reports > Guided Reports - Reports > Items with no checkouts - Reports > Patron statistics -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-22 21:52:10 UTC --- Created attachment 5094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5094 Bug 6458: Incorrect translation processing / acqui/... Patch removes template directives from within HTML tags from - acquisitions > new vendor / modify vendor / vendor details - acquisitions > late orders - acquisitons > vendor x > basket groups -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-22 22:14:14 UTC --- Created attachment 5095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5095 Bug 6458: Incorrect translation processing / cataloguing/... Patch removes template directives from within HTML tags from - cataloging > new record - cataloging - UNIMARC plugin for 4XX There is one problem remaining in the UNIMARC plugin: <option value="[% frameworkcodeloo.value %]" [% frameworkcodeloo.selected %]> [% frameworkcodeloo.frameworktext %] </option> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5095|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-22 22:22:10 UTC --- Created attachment 5096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5096 Bug 6458: Incorrect translation processing / cataloguing/... Patch removes template directives from within HTML tags from - cataloging > new record - cataloging - UNIMARC plugin for 4XX There is one problem remaining in addbiblio: <option value="[% frameworkcodeloo.value %]" [% frameworkcodeloo.selected %]> [% frameworkcodeloo.frameworktext %] </option> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-24 17:51:42 UTC --- Created attachment 5121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5121 Bug 6458: Incorrect translation processing - rotating_collections/... Patch removes templates directives from HTML tags in the rotating collections module. The module is currently not interated into Koha's staff interface. Fixing templats to make Jenkins happy. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5080|0 |1 is obsolete| | --- Comment #35 from Owen Leonard <oleonard@myacpl.org> 2011-08-24 20:06:47 UTC --- Created attachment 5125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5125 Signed off patch correcting masthead.inc -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5090|0 |1 is obsolete| | --- Comment #36 from Owen Leonard <oleonard@myacpl.org> 2011-08-24 20:08:02 UTC --- Created attachment 5126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5126 Signed off patch correcting overdue.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5091|0 |1 is obsolete| | --- Comment #37 from Owen Leonard <oleonard@myacpl.org> 2011-08-24 20:09:11 UTC --- Created attachment 5127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5127 Signed-off patch correcting review.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5092|0 |1 is obsolete| | --- Comment #38 from Owen Leonard <oleonard@myacpl.org> 2011-08-24 20:10:02 UTC --- Created attachment 5128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5128 Signed-off patch correcting authorities.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5093|0 |1 is obsolete| | --- Comment #39 from Owen Leonard <oleonard@myacpl.org> 2011-08-24 20:11:03 UTC --- Created attachment 5129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5129 Signed off patch correcting 3x reports -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5080|1 |0 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5125|Signed off patch correcting |Signed off patch correcting description|masthead.inc |doc-head-close.inc and | |doc-head-open.inc -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5081|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5080|0 |1 is obsolete| | --- Comment #40 from Owen Leonard <oleonard@myacpl.org> 2011-08-24 20:15:46 UTC --- Created attachment 5130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5130 Signed off patch correcting masthead.inc -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5094|0 |1 is obsolete| | --- Comment #41 from Owen Leonard <oleonard@myacpl.org> 2011-08-24 20:20:55 UTC --- Created attachment 5131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5131 Signed off patch correcting acqui templates -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5096|0 |1 is obsolete| | --- Comment #42 from Owen Leonard <oleonard@myacpl.org> 2011-08-24 20:26:15 UTC --- Created attachment 5132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5132 Signed off patch correcting cataloging templates -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-24 20:39:41 UTC --- Created attachment 5133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5133 Bug 6458: Incorrect translation processing / serials/... Fixes problems with template toolkit directives within HTML tags for the serials module. Serials > add/modify subsciption serial-issues-full.tt seems to be unused? I couldn't find the page in the serials module. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5082|0 |1 is obsolete| | --- Comment #44 from Owen Leonard <oleonard@myacpl.org> 2011-08-25 16:54:47 UTC --- Created attachment 5147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5147 Signed off patch correcting opac-detail.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5121|0 |1 is obsolete| | --- Comment #45 from Owen Leonard <oleonard@myacpl.org> 2011-08-25 17:13:29 UTC --- Created attachment 5148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5148 Signed off patch correcting rotating collections -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5133|0 |1 is obsolete| | --- Comment #46 from Owen Leonard <oleonard@myacpl.org> 2011-08-25 17:22:49 UTC --- Created attachment 5149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5149 Signed off patch correcting serials templates -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5079|0 |1 is obsolete| | --- Comment #47 from Owen Leonard <oleonard@myacpl.org> 2011-08-25 17:49:32 UTC --- Created attachment 5150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5150 Signed-off patch correcting sco-main.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #48 from Owen Leonard <oleonard@myacpl.org> 2011-08-25 19:50:18 UTC --- Working on memberentrygen.tt. Somebody please stop me if they are too! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-25 22:53:43 UTC --- Created attachment 5152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5152 Bug 6458: Incorrect translation processing / suggestion Removes template toolkit directives from within HTML tags. Acquisitions > Suggestions -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-25 22:54:33 UTC --- Created attachment 5153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5153 Bug 6458: Incorrect translation processing / results Removed template toolkit directives from within HTML tags. Advanced Search > Scan Index > Search results Additional changes: - removes entry 'Series Title' from the index pull down as it was the same index as 'Series' -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #51 from Owen Leonard <oleonard@myacpl.org> 2011-08-26 13:33:35 UTC --- Created attachment 5155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5155 Proposed fix for opac-reserve.tt Correction in opac holds template. Corrections made are logically consistent, but I couldn't reproduce the combination of factors to trigger the "disabled" attribute on the branch selector. In that respect this patch hasn't been tested 100%. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5152|0 |1 is obsolete| | --- Comment #52 from Owen Leonard <oleonard@myacpl.org> 2011-08-26 13:45:28 UTC --- Created attachment 5156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5156 Signed off patch correcting suggestions -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5153|0 |1 is obsolete| | --- Comment #53 from Owen Leonard <oleonard@myacpl.org> 2011-08-26 13:54:53 UTC --- Created attachment 5157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5157 Signed off patch correcting results.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #54 from Owen Leonard <oleonard@myacpl.org> 2011-08-26 14:06:39 UTC --- Created attachment 5158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5158 Proposed fix for opac-messaing.tt Correction for opac-messaging.tt tops tag attribute markup from being passed to the template directly in favor of using template logic. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #55 from Owen Leonard <oleonard@myacpl.org> 2011-08-26 14:23:11 UTC --- Created attachment 5159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5159 Proposed fix for memberentrygen.tt Fixing improperly nested template logic inside HTML tags in member entry form. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #56 from Owen Leonard <oleonard@myacpl.org> 2011-08-26 14:59:08 UTC --- Created attachment 5160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5160 Proposed fix for patron-attr-types.tt Correction for patron-attr-types.tt stops tag attribute markup from being passed to the template directly in favor of using template logic. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #57 from Owen Leonard <oleonard@myacpl.org> 2011-08-26 19:59:19 UTC --- Created attachment 5168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5168 Proposed fix for admin/clone-rules.tt Fixing improperly nested template logic inside HTML tags in clone circulation rules form. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #58 from Owen Leonard <oleonard@myacpl.org> 2011-08-26 20:11:11 UTC --- Created attachment 5169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5169 Proposed fix for admin/branches.tt Correction for branch admin template stops tag attribute markup from being passed to the template directly in favor of using template logic. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #59 from Owen Leonard <oleonard@myacpl.org> 2011-08-26 20:18:28 UTC --- Created attachment 5170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5170 Proposed fix for admin/branch_transfer_limits.tt Fixing improperly nested template logic inside HTML tags in branch transfer limits template. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #60 from Frère Sébastien Marie <semarie-koha@latrappe.fr> 2011-08-27 07:18:57 UTC --- Comment on attachment 5156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5156 Signed off patch correcting suggestions In the patch 'suggestion/suggestion.tt', in the second block of corrections, the semantic seems to not be preserved: Here, just an example, for the first line (of second block): Orign: [% IF ( suggestion.statusselected_ASKED ) %] Patch: [% IF (statusselected_ASKED ) %] -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #61 from Owen Leonard <oleonard@myacpl.org> 2011-09-01 13:47:04 UTC --- Created attachment 5258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5258 Proposed fix for header.inc Fixing improperly nested template logic inside HTML tags in header.inc. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #62 from Owen Leonard <oleonard@myacpl.org> 2011-09-01 14:14:03 UTC --- Created attachment 5259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5259 Proposed fix for admin/aqplan.tt Fixing improperly nested template logic inside HTML tags in aqplan template. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #63 from Owen Leonard <oleonard@myacpl.org> 2011-09-01 14:28:56 UTC --- Created attachment 5260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5260 Proposed fix for moremember.tt Fixing improperly nested template logic inside HTML tags in member details template. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #64 from Owen Leonard <oleonard@myacpl.org> 2011-09-01 14:39:10 UTC --- Created attachment 5261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5261 Proposed fix for labels/spinelabel-print.tt Fixing improperly nested template logic inside HTML tags in spine label print template. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #65 from Owen Leonard <oleonard@myacpl.org> 2011-09-01 14:56:36 UTC --- Created attachment 5262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5262 Proposed fix for admin/systempreferences.tt Fixing improperly nested template logic inside HTML tags in system preferences editor. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5158|0 |1 is obsolete| | --- Comment #66 from Owen Leonard <oleonard@myacpl.org> 2011-09-01 15:02:18 UTC --- Comment on attachment 5158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5158 Proposed fix for opac-messaing.tt This patch should be combined with one for includes/messaging-preference-form.inc. I'll submit a new patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #67 from Owen Leonard <oleonard@myacpl.org> 2011-09-01 15:17:50 UTC --- Created attachment 5263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5263 Proposed fix for addbiblio.tt Fixing improperly nested template logic inside HTML tags in MARC editor. Modifying script to stop tag attribute markup from being passed to the template directly in favor of using template logic. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #68 from Owen Leonard <oleonard@myacpl.org> 2011-09-01 15:21:05 UTC --- Whoops, forgot that some fixes had already been applied to addbiblio.tt. That last one may not apply in conjunction with attachment 5132. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #69 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-02 06:07:21 UTC --- STATUS UPDATE Assuming all patches proposed patches get signed off, this is the current output of xt/tt_valid.t: # Files list: # opac-tmpl/prog/en/modules/opac-messaging.tt: 62, 71, 81 # intranet-tmpl/prog/en/modules/tools/csv-profiles.tt: 104 # intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt: 160 # intranet-tmpl/prog/en/includes/messaging-preference-form.inc: 57, 62, 75, 80, 93, 98 # intranet-tmpl/prog/en/includes/doc-head-open.inc: 3 # intranet-tmpl/prog/en/includes/budgets-admin-search.inc: 64 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5263|0 |1 is obsolete| | --- Comment #70 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-02 06:12:42 UTC --- Created attachment 5273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5273 [SIGNED-OFF] Fix for Bug 6458 - incorrect parsing result in translation processing Fixing improperly nested template logic inside HTML tags in MARC editor. Modifying script to stop tag attribute markup from being passed to the template directly in favor of using template logic. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I fixed the conflict with previous patch for addbiblio.tt. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5262|0 |1 is obsolete| | --- Comment #71 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-02 06:21:47 UTC --- Created attachment 5274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5274 [SIGNED-OFF] Fix for Bug 6458 - incorrect parsing result in translation processing Fixing improperly nested template logic inside HTML tags in the system preferences editor. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5274|[SIGNED-OFF] Fix for Bug |[SIGNED-OFF] Fix for Bug description|6458 - incorrect parsing |6458 - incorrect parsing |result in translation |result in translation |processing |processing / | |systempreferences -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5273|[SIGNED-OFF] Fix for Bug |[SIGNED-OFF] Fix for Bug description|6458 - incorrect parsing |6458 - incorrect parsing |result in translation |result in translation |processing |processing / addbiblio -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5159|0 |1 is obsolete| | --- Comment #72 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-02 12:16:57 UTC --- Created attachment 5286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5286 [SIGNED-OFF] Fix for Bug 6458 - incorrect parsing result in translation processing Fixing improperly nested template logic inside HTML tags in member entry form. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Fixes lots of problems. Spotted one small problem. I am sending a follow-up. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #73 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-02 12:17:16 UTC --- Created attachment 5287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5287 Fix for Bug 6458 Follow-up for memberentrygen.tt The registration date field would show up twice after applying the first patch for memberentrygen.tt. This patch fixes the problem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5286|[SIGNED-OFF] Fix for Bug |[SIGNED-OFF] Fix for Bug description|6458 - incorrect parsing |6458 - incorrect parsing |result in translation |result in translation |processing |processing / memberentrygen -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5160|0 |1 is obsolete| | --- Comment #74 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-02 12:35:25 UTC --- Created attachment 5288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5288 Fix for Bug 6458 - incorrect parsing result in translation processing Correction for patron-attr-types.tt stops tag attribute markup from being passed to the template directly in favor of using template logic. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Read the patch and tested the page, didn't find any problems. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5288|0 |1 is obsolete| | --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-02 12:37:41 UTC --- Created attachment 5289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5289 [SIGNED-OFF] Fix for Bug 6458 - incorrect parsing result in translation processing / patron-attr-types Correction for patron-attr-types.tt stops tag attribute markup from being passed to the template directly in favor of using template logic. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Read the patch and tested the page, didn't find any problems. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #76 from Owen Leonard <oleonard@myacpl.org> 2011-09-02 14:03:20 UTC --- (In reply to comment #60)
In the patch 'suggestion/suggestion.tt', in the second block of corrections, the semantic seems to not be preserved:
Here, just an example, for the first line (of second block): Orign: [% IF ( suggestion.statusselected_ASKED ) %] Patch: [% IF (statusselected_ASKED ) %]
I think this modification is correct. Line 305 of suggestion.pl: $template->param( "statusselected_$$suggestion_ref{'STATUS'}" =>1); It doesn't look like that variable needs any scope. My search of the source indicates that there isn't any other place where a variable with that name is created. The behavior of the page seems to be the same with our without the variable scope, and I think this is because the variable never evaluates as true. I think the logic around that <option> is unused. I can't see what circumstances would lead to that status having a preselected value. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5155|0 |1 is obsolete| | --- Comment #77 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-02 14:04:37 UTC --- Created attachment 5292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5292 [SIGNED-OFF] Fix for Bug 6458 - incorrect parsing result in translation processing Correction in opac holds template. Corrections made are logically consistent, but I couldn't reproduce the combination of factors to trigger the "disabled" attribute on the branch selector. In that respect this hasn't been tested 100%. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5292|[SIGNED-OFF] Fix for Bug |[SIGNED-OFF] Fix for Bug description|6458 - incorrect parsing |6458 - incorrect parsing |result in translation |result in translation |processing |processing / opac-reserve -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #78 from Owen Leonard <oleonard@myacpl.org> 2011-09-02 14:21:11 UTC --- Created attachment 5293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5293 Proposed fix for tools/manage-marc-import.tt There is template logic in manage-marc-import.tt which is intended to set the "selected" option for the framework chooser ("Add new bibliographic records into this framework"). However, I can't see any place in the code which sends the "selected" variable to the template, and I can't see any circumstance in which a value would be passed to the template. This patch removes the "selected" variable from the template. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5168|0 |1 is obsolete| | --- Comment #79 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-02 18:52:25 UTC --- Created attachment 5299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5299 [SIGNED-OFF] Fix for Bug 6458 - incorrect parsing result in translation processing / clone-rules Fixing improperly nested template logic inside HTML tags in clone circulation rules form. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5169|0 |1 is obsolete| | --- Comment #80 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-02 19:18:23 UTC --- Created attachment 5300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5300 [SIGNED-OFF] Fix for Bug 6458 - incorrect parsing result in translation processing / branches Correction for branch admin template stops tag attribute markup from being passed to the template directly in favor of using template logic. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #81 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-12 21:35:36 UTC --- I have pushed up to Signed off patch correcting results.tt, please sign off the others and I will push the rest -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #82 from Owen Leonard <oleonard@myacpl.org> 2011-09-13 14:06:24 UTC --- Created attachment 5416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5416 Proposed fix for budgets-admin-search.inc Fixing improperly nested template logic inside HTML tags in budgets admin search form. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #83 from Owen Leonard <oleonard@myacpl.org> 2011-09-13 14:09:17 UTC --- Created attachment 5417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5417 Proposed fix for tools/csv-profiles.tt Fixing improperly nested template logic inside HTML tags in CSV profiles template Also fixing improperly scoped template variable which prevented the current profile from being preselected under the edit tab. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #84 from Owen Leonard <oleonard@myacpl.org> 2011-09-13 16:33:02 UTC --- Created attachment 5418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5418 Follow-up fix for addbiblio.tt Somehow some markup which should have been deleted by one of this bug's pushed patches has reappeared, messing up the display of the MARC editor. This patch removes that section again. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5125|0 |1 is obsolete| | Attachment #5126|0 |1 is obsolete| | Attachment #5127|0 |1 is obsolete| | Attachment #5128|0 |1 is obsolete| | Attachment #5129|0 |1 is obsolete| | Attachment #5130|0 |1 is obsolete| | Attachment #5131|0 |1 is obsolete| | Attachment #5132|0 |1 is obsolete| | Attachment #5147|0 |1 is obsolete| | Attachment #5148|0 |1 is obsolete| | Attachment #5149|0 |1 is obsolete| | Attachment #5150|0 |1 is obsolete| | Attachment #5156|0 |1 is obsolete| | Attachment #5157|0 |1 is obsolete| | Attachment #5170|0 |1 is obsolete| | Attachment #5258|0 |1 is obsolete| | Attachment #5259|0 |1 is obsolete| | Attachment #5260|0 |1 is obsolete| | Attachment #5261|0 |1 is obsolete| | --- Comment #85 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-13 22:12:40 UTC --- Created attachment 5419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5419 Follow-up fix for Bug 6458, incorrect parsing result in translation processing Somehow some markup which should have been deleted by a previous patch has reappeared, messing up the display of the MARC editor. This patch removes that section again. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5274|0 |1 is obsolete| | Attachment #5286|0 |1 is obsolete| | Attachment #5287|0 |1 is obsolete| | Attachment #5289|0 |1 is obsolete| | Attachment #5292|0 |1 is obsolete| | Attachment #5293|0 |1 is obsolete| | Attachment #5299|0 |1 is obsolete| | Attachment #5300|0 |1 is obsolete| | Attachment #5416|0 |1 is obsolete| | Attachment #5417|0 |1 is obsolete| | Attachment #5418|0 |1 is obsolete| | Attachment #5419|0 |1 is obsolete| | --- Comment #86 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-13 22:13:00 UTC --- Created attachment 5420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5420 Follow-up fix for Bug 6458, incorrect parsing result in translation processing Somehow some markup which should have been deleted by a previous patch has reappeared, messing up the display of the MARC editor. This patch removes that section again. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #87 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-13 22:13:25 UTC --- The content of attachment 5420 has been deleted by Chris Cormack <chris@bigballofwax.co.nz> without providing any reason. The token used to delete this attachment was generated at 2011-09-14 10:13:19 NZST. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Does not apply --- Comment #88 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-13 22:14:00 UTC --- I have pushed all the patches attached to this, apart from the one left which does not apply. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #89 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-13 22:15:37 UTC --- not ok 1 - TT syntax: not using TT directive within HTML tag # Failed test 'TT syntax: not using TT directive within HTML tag' # at xt/tt_valid.t line 55. # Files list: # opac-tmpl/prog/en/modules/opac-messaging.tt: 62, 71, 81 # intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: 782 # intranet-tmpl/prog/en/includes/messaging-preference-form.inc: 57, 62, 75, 80, 93, 98 # intranet-tmpl/prog/en/includes/doc-head-open.inc: 3 Here are the things left failing -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #90 from Owen Leonard <oleonard@myacpl.org> 2011-09-13 23:08:08 UTC --- I have patches ready to submit for the last few. Will do so ASAP. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5158|1 |0 is obsolete| | --- Comment #91 from Owen Leonard <oleonard@myacpl.org> 2011-09-14 12:50:27 UTC --- Comment on attachment 5158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5158 Proposed fix for opac-messaing.tt I'm removing obsolete status from this patch because it doesn't look like it got pushed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #92 from Owen Leonard <oleonard@myacpl.org> 2011-09-14 13:19:42 UTC --- Created attachment 5425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5425 Proposed fix Correcting doc-head-open.inc (again?) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5425|Proposed fix |Proposed fix for description| |doc-head-open.inc -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5273|0 |1 is obsolete| | --- Comment #93 from Owen Leonard <oleonard@myacpl.org> 2011-09-14 13:23:57 UTC --- Created attachment 5426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5426 Revised fix for addbiblio.tt -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #94 from Owen Leonard <oleonard@myacpl.org> 2011-09-14 19:23:33 UTC --- Created attachment 5427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5427 Proposed fix for messaging preference form Fixing improperly nested template logic inside HTML tags in messaging preferences include. NOTE: This patch requires the patch for opac-messaging.tt, which includes a change to C4/Form/MessagingPreferences.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Patch Pushed --- Comment #95 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-14 20:42:10 UTC --- Pushed, all TT tests now passing WOOT! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 --- Comment #96 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-10-26 18:02:12 UTC --- The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Frère Sébastien Marie <semarie-koha@latrappe.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #97 from Frère Sébastien Marie <semarie-koha@latrappe.fr> 2011-10-27 04:19:30 UTC --- (In reply to comment #96)
The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report.
Thanks. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6458 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8407 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org