[Bug 16871] New: Translatability: Avoid [ %%-problem fix related sentence splitting in catalogue/detail.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Bug ID: 16871 Summary: Translatability: Avoid [%%-problem fix related sentence splitting in catalogue/detail.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt, fix line splitted TT directives and sentence splitting leading to translatability problems with following, errorprone monster: %s %s at%sfor delivery at %s %s %s since %s %s %s (placed %s) %s %s %s [%% UNLESS ( item.itemnotforloan or item.notforloan_per_itemtype or item.onloan or item.itemlost or item.withdrawn or item.damaged or item.transfertwhen or item.reservedate ) %%] Available %s %s -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translatability: Avoid |Translatability: Avoid |[%%-problem fix related |[%%-problem and fix related |sentence splitting in |sentence splitting in |catalogue/detail.tt |catalogue/detail.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 53184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53184&action=edit Bug 16871 - Translatability: Avoid [%%-problem and fix related sentence splitting in catalogue/detail.tt In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt, fix line splitted TT directives and sentence splitting leading to translatability problems. (See first comment). To test: - Apply patch - Go to detail pages of biblios with waiting holds - Verify that messages in column 'Status' are OK - Examine code in patch to make sure that the simplification in logic makes sense and that no TT directive is splitted - Bonus test: - Go to folder misc/translator. Run perl translate create xx-XX - Verify that monster mentioned in first comment no longer exists (in po/xx-XX-staff-prog.po) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16559 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10492 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53184|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 53477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53477&action=edit [SIGNED-OFF]Bug 16871: Translatability: Avoid [%%-problem and fix related sentence splitting in catalogue/detail.tt In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt, fix line splitted TT directives and sentence splitting leading to translatability problems. (See first comment). To test: - Apply patch - Go to detail pages of biblios with waiting holds - Verify that messages in column 'Status' are OK - Examine code in patch to make sure that the simplification in logic makes sense and that no TT directive is splitted - Bonus test: - Go to folder misc/translator. Run perl translate create xx-XX - Verify that monster mentioned in first comment no longer exists (in po/xx-XX-staff-prog.po) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1/ Looking at the logic it seems that reservedate could be missing (?) 2/ Before the patch the string was "waiting at LIBRARY since DATE", now it's "waiting since DATE at LIBRARY". I don't think it represents a big change but I would prefer to get the opinion of English native speakers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 --- Comment #4 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #3)
1/ Looking at the logic it seems that reservedate could be missing (?) (...)
We had two conditions [% IF ( item.waitingdate ) %] at the same level (line 693ff and 707ff before patch). I merged them (line 693ff with patch), including reservedate.
2/ Before the patch the string was "waiting at LIBRARY since DATE", now it's "waiting since DATE at LIBRARY". I don't think it represents a big change but I would prefer to get the opinion of English native speakers.
I will ask on IRC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Claire Gravely <c.gravely@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |c.gravely@arts.ac.uk --- Comment #5 from Claire Gravely <c.gravely@arts.ac.uk> --- Responding from IRC conversation: You would want to use "waiting at LIBRARY since DATE". The other sentence structure doesn't sound right. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 53719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53719&action=edit Bug 16871: Translatability: Avoid [%%-problem and fix related sentence splitting in catalogue/detail.tt In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt, fix line splitted TT directives and sentence splitting leading to translatability problems. (See first comment). To test: - Apply patch - Go to detail pages of biblios with waiting holds - Verify that messages in column 'Status' are OK - Examine code in patch to make sure that the simplification in logic makes sense and that no TT directive is splitted - Bonus test: - Go to folder misc/translator. Run perl translate create xx-XX - Verify that monster mentioned in first comment no longer exists (in po/xx-XX-staff-prog.po) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Amended for wording (comment #5) 2016-07-26 mv -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53477|0 |1 is obsolete| | Attachment #53719|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53838&action=edit Bug 16871: Translatability: Avoid [%%-problem and fix related sentence splitting in catalogue/detail.tt In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt, fix line splitted TT directives and sentence splitting leading to translatability problems. (See first comment). To test: - Apply patch - Go to detail pages of biblios with waiting holds - Verify that messages in column 'Status' are OK - Examine code in patch to make sure that the simplification in logic makes sense and that no TT directive is splitted - Bonus test: - Go to folder misc/translator. Run perl translate create xx-XX - Verify that monster mentioned in first comment no longer exists (in po/xx-XX-staff-prog.po) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Amended for wording (comment #5) 2016-07-26 mv -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's ok for me. I let the RM takes care of the wording. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #9 from Brendan Gallagher <brendan@bywatersolutions.com> --- Wording is good for me... Pushed to master. Should be in the November 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.03. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17200 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17200 [Bug 17200] Badly formatted "hold for" patron name on catalog detail page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org