[Bug 36878] New: Spurious warnings in C4::ILSDI::AuthenticatePatron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36878 Bug ID: 36878 Summary: Spurious warnings in C4::ILSDI::AuthenticatePatron Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: andreas.jonsson@kreablo.se QA Contact: testopia@bugs.koha-community.org Spurious warning about undefined variable in logfiles. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36878 --- Comment #1 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 166803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166803&action=edit Bug 36878: Silence spurious warning in C4::ILSDI Test plan: Review patch and verify that: * the only effect is that no warning will be emitted in the event the variable $status is undefined, and * the variable $status being undefined is normal and harmless. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36878 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36878 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Assignee|oleonard@myacpl.org |andreas.jonsson@kreablo.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36878 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36878 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166803|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 167561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167561&action=edit Bug 36878: Silence spurious warning in C4::ILSDI Test plan: Review patch and verify that: * the only effect is that no warning will be emitted in the event the variable $status is undefined, and * the variable $status being undefined is normal and harmless. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36878 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- In what case is status expected to be undefined? It is the first return variable from checkpw which should be 1,0,-1 according to the code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36878 --- Comment #4 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- The warnings in the logfile makes it apparent that $status occasionally is undefined. checkpw is a messy subroutine, but two apparent cases where $status is undefined is $patron->account_locked and $stored_hash eq '!'. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org