[Bug 14018] New: Ordering from suggestion shows 'copy. year:2014'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 Bug ID: 14018 Summary: Ordering from suggestion shows 'copy. year:2014' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org To test: - create a suggestion with the publication year - accect suggestion - create a new order from that suggestion - in the list of suggestions to order, the display problem should be visible: copy. year:2014 I'd rather avoid using the copyright symbol here as it has often caused problems in translations for us and probably others. Maybe just having the year would be ok? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 38154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38154&action=edit Enter and display a full suggestion Screenshots with form for new suggestions, list display of suggestion and HTML. The list display is handled in suggestion.tt line ca. 510 following. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marc, I think we are not looking in the same spot maybe? The display problem only occurs if you create an order from the suggestion afaikt - on the screen where you pick from the accepted orders. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 38169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38169&action=edit Display suggestion in "Add order from a suggestion" See 'copy year:2015' near ISBN -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 --- Comment #4 from Marc Véron <veron@veron.ch> --- - We have a copyright date and a publication year in the database, but it seems that only the copyright date is used. The copyright date then pupulates the field "Publication year" in the "New order" form. - The forms for creating an new suggestion in staff client and OPAC display the copyright date only. - Both the list views in newordersuggestion.tt and suggestion.tt are prepared to display the copyright date and the publication year. - They display the same overall information in a slightly different way. - I think the display should be streamlined (using an include?) to have a more consistent and translation friendly display. For the moment I will replace the text 'copy. year.' with te copyright-sign (as it is in suggestion.tt) plus some similar minor changes ( 'in' instead of 'at' for publication place). For the streamlining I propose to have a separat bug because this will need some more analyzing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 38172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38172&action=edit Bug 14018 - Ordering from suggestion shows 'copy. year:2014' This patch fixes some minor display issues in 'Add order from a suggestion' To test: - Add order form a suggestion - The copyright date iss dispayed like 'copy.year:2015' - Apply patch - The copyright date now displays as (copyright sign) 2014, similar to the display in suggestion management -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14019 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38172|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38609&action=edit Bug 14018 - Ordering from suggestion shows 'copy. year:2014' This patch fixes some minor display issues in 'Add order from a suggestion' To test: - Add order form a suggestion - The copyright date iss dispayed like 'copy.year:2015' - Apply patch - The copyright date now displays as (copyright sign) 2014, similar to the display in suggestion management Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38609|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38615&action=edit [PASSED QA] Bug 14018 - Ordering from suggestion shows 'copy. year:2014' This patch fixes some minor display issues in 'Add order from a suggestion' To test: - Add order form a suggestion - The copyright date iss dispayed like 'copy.year:2015' - Apply patch - The copyright date now displays as (copyright sign) 2014, similar to the display in suggestion management Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org