[Bug 12135] New: Pending suggestions table width is wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Bug ID: 12135 Summary: Pending suggestions table width is wrong Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com It looks like the table for pending suggestions is out of whack. All the other tabs are formatting to a width of 1006px, but the pending request are formatting the table to a width of 1256px. Apparently this can't be fixed with jQuery. I can adjust the widths of the tables on the other tabs, but for some reason it won't work on this particular table. This is the jQuery I used: $("#ASKEDt").css("width","1006px"); If I change the ID to one of the other tables, it works just fine. May be part of the bug. It looks like it applies, but when you click the tab to look at this table, the old size appears, which makes me think the style is being applied when the tab is clicked, and overridden. The funny thing is that it doesn't do this with the other tabs. The jQuery override is applied and sticks, even after changing between the tabs. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- There is code in the template which is supposed to fix this which stopped working when we upgraded jQueryUI. The width of tables which are hidden in non-visible tabs cannot be correctly calculated until they are shown--hidden elements have no width. This code fixed it before the jQueryUI upgrade: $('#suggestiontabs').tabs({ // Correct table sizing for tables hidden in tabs // http://www.datatables.net/examples/api/tabs_and_scrolling.html "show": function(event, ui) { var oTable = $('div.dataTables_wrapper>table', ui.panel).dataTable(); if ( oTable.length > 0 ) { oTable.fnAdjustColumnSizing(); } } }); The jQueryUI API has changed, so this needs to be corrected on this page and others. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38567&action=edit Bug 12135: Fix suggestions table width The trick to update the suggestions table width is outdated since jQuery UI has been updated. Test plan: 0/ Don't apply this patch 1/ Go on the suggestions page (suggestion/suggestion.pl), change tabs: the table width is wrong 2/ Apply this patch 4/ Repeat 1 and confirm the width is now updated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- I think this patch is working. I definitely see differences. The problem is that with the table width being dynamic and not fixed to the width of the screen, it is very difficult to tell. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 38612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38612&action=edit [SIGNED OFF] Bug 12135: Fix suggestions table width The trick to update the suggestions table width is outdated since jQuery UI has been updated. Test plan: 0/ Don't apply this patch 1/ Go on the suggestions page (suggestion/suggestion.pl), change tabs: the table width is wrong 2/ Apply this patch 4/ Repeat 1 and confirm the width is now updated. Signed-off-by: Christopher Brannon <cbrannon@cdalibary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Attachment #38567|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38617&action=edit [PASSED QA] Bug 12135: Fix suggestions table width The trick to update the suggestions table width is outdated since jQuery UI has been updated. Test plan: 0/ Don't apply this patch 1/ Go on the suggestions page (suggestion/suggestion.pl), change tabs: the table width is wrong 2/ Apply this patch 4/ Repeat 1 and confirm the width is now updated. Signed-off-by: Christopher Brannon <cbrannon@cdalibary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> The table sizes still vary slightly, but this is an improvement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Christopher Brannon from comment #3)
I think this patch is working. I definitely see differences. The problem is that with the table width being dynamic and not fixed to the width of the screen, it is very difficult to tell.
(In reply to Katrin Fischer from comment #5)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> The table sizes still vary slightly, but this is an improvement.
Yes, it's how it is supposed to behave. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Attachment #38612|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org