[Bug 12528] New: Enable staff to deny message setting access to patrons on the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bug ID: 12528 Summary: Enable staff to deny message setting access to patrons on the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: simith.doliveira@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Enable staff to deny message setting access to patrons on the OPAC The problem: The preference EnhancedMessagingPreferences control access to patron message setting in both intranet (Patrons -> Details or Patrons -> Edit) and OPAC ( user's settings - > your messaging). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com | |, | |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #1 from simith.doliveira@inlibro.com --- Created attachment 29505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29505&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC This fix permits the staff to pull apart the access to patron message setting. Modified: installer/data/mysql/sysprefs.sql -OPACEnhancedMessagingPreferences preference added koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref -OPACEnhancedMessagingPreferences preference added koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -access to message setting changed Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 30259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30259&action=edit [Signed-off] Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC This fix permits the staff to pull apart the access to patron message setting. Modified: installer/data/mysql/sysprefs.sql -OPACEnhancedMessagingPreferences preference added koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref -OPACEnhancedMessagingPreferences preference added koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -access to message setting changed Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. Patch behaves as expected Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29505|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |simith.doliveira@inlibro.co |ity.org |m Severity|new feature |enhancement --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Simith, please remember to assign patches to yourself :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really like this, as I have been asked to hide the message settings quite often and right now there is no solution the user can't get around. But there is a problem with this patch there: it just deactivates the visibility of the tab in the templates, but it doesn't block accessing the message settings page if you know the URL. I know we have fixed that for other pages in patron account, could you take a look and try to fix this? Database update looks good, the new condition could be added to the existing [%IF ...%], but not a blocker. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #5 from simith.doliveira@inlibro.com --- Created attachment 30348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30348&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC This fix permits the staff to pull apart the access to patron message setting. Modified: installer/data/mysql/sysprefs.sql -OPACEnhancedMessagingPreferences preference added koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref -OPACEnhancedMessagingPreferences preference added koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -access to message setting changed Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30348|0 |1 is obsolete| | --- Comment #6 from simith.doliveira@inlibro.com --- Created attachment 30349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30349&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC This fix permits the staff to pull apart the access to patron message setting. Modified: installer/data/mysql/sysprefs.sql -OPACEnhancedMessagingPreferences preference added koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref -OPACEnhancedMessagingPreferences preference added koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -access to message setting changed Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from simith.doliveira@inlibro.com --- Fix done, Url access blocked -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30349|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30487&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC QA Follow up This patch will stop a person without access hitting the url directly and being able to change their messaging preferences. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Hi Simith As your first patch was already signed off, I reformatted your second to only include the new changes and signed off on that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, those patches look ok, but the database update is missing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #11 from simith.doliveira@inlibro.com --- Created attachment 31047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31047&action=edit Patch with updatedatabase.pl included -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Attachment #30259|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30259|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30259|0 |1 is obsolete| | --- Comment #12 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 36511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36511&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC This fix permits the staff to pull apart the access to patron message setting. Modified: installer/data/mysql/sysprefs.sql -OPACEnhancedMessagingPreferences preference added koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref -OPACEnhancedMessagingPreferences preference added koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -access to message setting changed Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. Patch behaves as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> I fixed some minor conflicts, so I'm sending all patches w/ signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30487|0 |1 is obsolete| | --- Comment #13 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 36512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36512&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC QA Follow up This patch will stop a person without access hitting the url directly and being able to change their messaging preferences. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> I fixed some minor conflicts, so I'm sending all patches w/ signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31047|0 |1 is obsolete| | --- Comment #14 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 36513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36513&action=edit Bug 12528 Patch with updatedatabase.pl included Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #15 from Mirko Tietgen <mirko@abunchofthings.net> --- The description of EnhancedMessagingPreferences should probably be reworded as it does not make much sense in combination with OPACEnhancedMessagingPreferences. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 36512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36512 Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC Review of attachment 36512: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12528&attachment=36512) ----------------------------------------------------------------- ::: opac/opac-messaging.pl @@ +69,5 @@
SMSnumber => defined $borrower->{'smsalertnumber'} ? $borrower->{'smsalertnumber'} : $borrower->{'mobile'}, SMSSendDriver => C4::Context->preference("SMSSendDriver"), + TalkingTechItivaPhone => C4::Context->preference("TalkingTechItivaPhoneNotification"), + admin => C4::Context->preference('KohaAdminEmailAddress'), + Authorized => C4::Context->preference('OPACEnhancedMessagingPreferences'));
Please use the Koha plugin to access system preference values from the templates ([% IF Koha.Preference('OPACEnhancedMessagingPreferences') %]). And maybe EnhancedMessagingPreferences should be checked too, according to the description of the syspref. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #17 from simith.doliveira@inlibro.com --- Created attachment 36818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36818&action=edit Fix koha plugin to access system pref. and EnhancedMessagingPreferences description -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #18 from Marc Véron <veron@veron.ch> --- Patch does not apply: Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani@inlibro.com Assignee|simith.doliveira@inlibro.co |bouzid.fergani@inlibro.com |m | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36511|0 |1 is obsolete| | Attachment #36512|0 |1 is obsolete| | Attachment #36513|0 |1 is obsolete| | Attachment #36818|0 |1 is obsolete| | --- Comment #19 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 44302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44302&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC This fix permits the staff to pull apart the access to patron message setting. Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #20 from Bouzid <bouzid.fergani@inlibro.com> --- I redone all patch because it's necessary, I create one good patch work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Needs Signoff |Failed QA --- Comment #21 from Frédéric Demians <frederic@tamil.fr> --- In opac-messaging.pl, you should remove 'Authorized' parameter, and use in opac-messaging.tt: [% IF Koha.Preference( 'OPACEnhancedMessagingPreferences' ) %] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44302|0 |1 is obsolete| | --- Comment #22 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 44820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44820&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC This fix permits the staff to pull apart the access to patron message setting. Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #23 from Bouzid <bouzid.fergani@inlibro.com> --- I removed 'Authorized' parameter in opac-messaging.pl and used in opac-messaging.tt [% IF Koha.Preference( 'OPACEnhancedMessagingPreferences' ) %]. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #24 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Bouzid from comment #23)
I removed 'Authorized' parameter in opac-messaging.pl and used in opac-messaging.tt [% IF Koha.Preference( 'OPACEnhancedMessagingPreferences' ) %].
Thanks. The code seems OK now. I realize that the wording of the 2 sysprefs are not that clear. The two together. And it's not your syspref which sound strange bug the initial: EnhancedMessagingPreferences: Allow/Don't allow patrons to choose which notices they receive and when they receive them. Note that this only applies to certain kinds of notices. This give the feeling that the patron will be allowed to change their notifications themselves. Anyway your patch works. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44820|0 |1 is obsolete| | --- Comment #25 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 44826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44826&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC This fix permits the staff to pull apart the access to patron message setting. Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Works as expected. With the new syspref, patrons can be forbidden to modify themselves their own messaging preferences. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 44826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44826 Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC Review of attachment 44826: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12528&attachment=44826) ----------------------------------------------------------------- The description for EnhancedMessagingPreferences is "allow/don't allow patrons to choose which notices they receive and when they receive them. I think it could be updated to highlight that it's for the staff interface only, or at least a reference to the new pref? Why don't you want the patrons to show the type of messages they receive? I could understand not to let the patrons change the settings, but I don't see the point to hide them completely. ::: installer/data/mysql/atomicupdate/sysprefs_Bug12528.sql @@ +1,3 @@
+INSERT INTO systempreferences ( variable, value, options, explanation,type ) VALUES +('OPACEnhancedMessagingPreferences', '1', NULL, 'If ON, show patrons messaging setting on the OPAC.', 'YesNo') +;
It would be better to set the value of the other pref, to avoid any confusion. ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt @@ +131,5 @@
</form> </div> <!-- / #usermessaging --> + [% ELSE %] + <h4>You are not allowed to call this page directly</h4> + <span> To report this problem, you can <a href="mailto:[% admin %]">email the Koha Administrator</a>.</span>
"admin" does not seem to be sent to the template. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #27 from Francois Charbonnier <francois.charbonnier@inlibro.com> --- (In reply to Jonathan Druart from comment #26)
Comment on attachment 44826 [details] [review] Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC
Review of attachment 44826 [details] [review]: -----------------------------------------------------------------
The description for EnhancedMessagingPreferences is "allow/don't allow patrons to choose which notices they receive and when they receive them. I think it could be updated to highlight that it's for the staff interface only, or at least a reference to the new pref?
You're right. We will change the preference description. It will be : [Allow/Don't allow] staff to manage which notices patrons will receive and when they will receive them. Note : this only applies to courtesy notices. To manage if patrons have also access to these settings, use OPACEnhancedMessagingPreferences.
Why don't you want the patrons to show the type of messages they receive? I could understand not to let the patrons change the settings, but I don't see the point to hide them completely.
By hiding them, you avoid the question : "Why can't I change my settings by myself?" ;^)
::: installer/data/mysql/atomicupdate/sysprefs_Bug12528.sql @@ +1,3 @@
+INSERT INTO systempreferences ( variable, value, options, explanation,type ) VALUES +('OPACEnhancedMessagingPreferences', '1', NULL, 'If ON, show patrons messaging setting on the OPAC.', 'YesNo') +;
It would be better to set the value of the other pref, to avoid any confusion.
EnhancedMessagingPreference is already setup by updatedatabase so I don't think this should be change by the atomicupdate here. Moreover, we don't want to change the current setting when the library will run this update.
::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt @@ +131,5 @@
</form> </div> <!-- / #usermessaging --> + [% ELSE %] + <h4>You are not allowed to call this page directly</h4> + <span> To report this problem, you can <a href="mailto:[% admin %]">email the Koha Administrator</a>.</span>
"admin" does not seem to be sent to the template.
We are currently working on this. :^) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Francois Charbonnier from comment #27)
Why don't you want the patrons to show the type of messages they receive? I could understand not to let the patrons change the settings, but I don't see the point to hide them completely.
By hiding them, you avoid the question : "Why can't I change my settings by myself?" ;^)
But can answer the question "Why am I receiving email for that?" We can imagine a quick sentence "Contact your library if you want to change them"
::: installer/data/mysql/atomicupdate/sysprefs_Bug12528.sql @@ +1,3 @@
+INSERT INTO systempreferences ( variable, value, options, explanation,type ) VALUES +('OPACEnhancedMessagingPreferences', '1', NULL, 'If ON, show patrons messaging setting on the OPAC.', 'YesNo') +;
It would be better to set the value of the other pref, to avoid any confusion.
EnhancedMessagingPreference is already setup by updatedatabase so I don't think this should be change by the atomicupdate here. Moreover, we don't want to change the current setting when the library will run this update.
OPACEnhancedMessagingPreferences is added (for existing install, so in updatedatabase.pl) and enabled. It does not hurt if EnhancedMessagingPreference is disabled, because in the code both are checked. But it would be better to enable OPACEnhancedMessagingPreferences only if EnhancedMessagingPreference is enabled too. It will avoid to have "OPACEnhancedMessagingPreference is enabled but not really because EnhancedMessagingPreference is not" on the admin pref page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #29 from Frédéric Demians <frederic@tamil.fr> --- Suggestion for OPACEnhancedMessagingPreferences. It could have 3 values rather than 2: 0- Not displayed 1- Displayed 2- Modifiable When updating an existing DB (see Jonathan comment): my $emp = C4::Context->preference('EnhancedMessagingPreferences') ? 2 : 0; INSERT INTO systempreferences (variable, value, options, explanation, type) VALUES ('OPACEnhancedMessagingPreferences', $emp, NULL, 'Not display/display/modify patrons messaging setting on the OPAC.', 'YesNo') -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #30 from Marc Véron <veron@veron.ch> --- For the sake of better translatability (no string spltting by html tags), I propose to change koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt line 135: <span> To report this problem, you can <a href="mailto:[% admin %]">email the Koha Administrator</a>.</span> ... to something like: <span> To report this problem, please contact the Koha Administrator: <a href="mailto:[% admin %]">Email.</a></span> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #31 from Francois Charbonnier <francois.charbonnier@inlibro.com> --- (In reply to Jonathan Druart from comment #28)
::: installer/data/mysql/atomicupdate/sysprefs_Bug12528.sql @@ +1,3 @@
+INSERT INTO systempreferences ( variable, value, options, explanation,type ) VALUES +('OPACEnhancedMessagingPreferences', '1', NULL, 'If ON, show patrons messaging setting on the OPAC.', 'YesNo') +;
It would be better to set the value of the other pref, to avoid any confusion.
EnhancedMessagingPreference is already setup by updatedatabase so I don't think this should be change by the atomicupdate here. Moreover, we don't want to change the current setting when the library will run this update.
OPACEnhancedMessagingPreferences is added (for existing install, so in updatedatabase.pl) and enabled. It does not hurt if EnhancedMessagingPreference is disabled, because in the code both are checked. But it would be better to enable OPACEnhancedMessagingPreferences only if EnhancedMessagingPreference is enabled too. It will avoid to have "OPACEnhancedMessagingPreference is enabled but not really because EnhancedMessagingPreference is not" on the admin pref page.
I agree. We will change the atomic update to enable the OPACEnhancedMessagingPreferences only if EnhancedMessagingPreference is enable as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #32 from Francois Charbonnier <francois.charbonnier@inlibro.com> --- (In reply to Jonathan Druart from comment #28)
(In reply to Francois Charbonnier from comment #27)
Why don't you want the patrons to show the type of messages they receive? I could understand not to let the patrons change the settings, but I don't see the point to hide them completely.
By hiding them, you avoid the question : "Why can't I change my settings by myself?" ;^)
But can answer the question "Why am I receiving email for that?" We can imagine a quick sentence "Contact your library if you want to change them"
I like Frederic's option but we will not do it. :^) If anyone want his third option, I'll suggest to open a new ticket for the enhancement. My thoughts on this are : this patch does not change the current behaviour if not activated. For libraries who can see how useful it is (like the one who sponsored it, use it for more than a year now and hasn't got any complaint so far), it's there. For libraries who doesn't see it, they just don't activate it. Everybody's happy! :^) In the end, I'll just take the opportunity to say that I know how developers don't like new system preferences (I understand their points) but us, librarians, do like them a lot. They allow us to be even more in control of our ILS which I think is fantastic. We can all agree Koha is all about empowering librarians with new features, right? But, the difficulty is to find the better way do it. I think we should always see it as a step by step process. This patch is the first step for a better courtesy notices management. Once this patch is pushed, it will benefit the libraries who see its usefullness and change nothing for libraries who can't see it. AND it will let anybody who want to enhanced it to go further. So please, lets not abandoned this patch in the small enhancement patches limbo of bugzilla because we want to move two steps at a time. Let's do it step by step! Thanks!!! :^) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #33 from David Cook <dcook@prosentient.com.au> --- No idea where this is at now (even after reading most of the comments), but it's exciting nonetheless! I usually hide these using jQuery, which isn't really the best solution, so it would be great to have a system preference for this... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #34 from Marc Véron <veron@veron.ch> --- (In reply to Francois Charbonnier from comment #32) (...)
So please, lets not abandoned this patch in the small enhancement patches limbo of bugzilla because we want to move two steps at a time. Let's do it step by step!
Step by step ++ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #35 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Francois Charbonnier from comment #32)
So please, lets not abandoned this patch in the small enhancement patches limbo of bugzilla because we want to move two steps at a time. Let's do it step by step!
I agree. You have to strike while the iron is hot. I'd be pleased to re-sign-off this patch as soon as issue rightly raised by Jonathan will be addressed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Frédéric Demians from comment #35)
(In reply to Francois Charbonnier from comment #32)
So please, lets not abandoned this patch in the small enhancement patches limbo of bugzilla because we want to move two steps at a time. Let's do it step by step!
I agree. You have to strike while the iron is hot. I'd be pleased to re-sign-off this patch as soon as issue rightly raised by Jonathan will be addressed.
And I will be happy to re-qa it ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44826|0 |1 is obsolete| | --- Comment #37 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 45885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45885&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC Change the preference Enhancedmessagingpreference description. Enable default EnhancedMessagingPreferences and OPACEnhancedMessagingPreferences. not sent e-mail it's necessary, when user call opac-messaging.pl directly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45885|0 |1 is obsolete| | --- Comment #38 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 45886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45886&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC - Change the preference Enhancedmessagingpreference description. - Enable default EnhancedMessagingPreferences and OPACEnhancedMessagingPreferences. - not sent e-mail it's necessary, when user call opac-messaging.pl directly.. Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Works as expected. With the new syspref, patrons can be forbidden to modify themselves their own messaging preferences. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45886|0 |1 is obsolete| | --- Comment #39 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 45962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45962&action=edit Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC - Change the preference Enhancedmessagingpreference description. - Enable default EnhancedMessagingPreferences and OPACEnhancedMessagingPreferences. - not sent e-mail it's necessary, when user call opac-messaging.pl directly.. Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Works as expected. With the new syspref, patrons can be forbidden to modify themselves their own messaging preferences. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Also, I like sysprefs http://www.quickmeme.com/img/d9/d99723bc544e8d33572dc92f242a6f6e2dbe0126a2e3... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 45962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45962 Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC Review of attachment 45962: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12528&attachment=45962) ----------------------------------------------------------------- Please provide a quick fix, it's easy :) ::: installer/data/mysql/atomicupdate/sysprefs_Bug12528.sql @@ +1,4 @@
+INSERT INTO systempreferences ( variable, value, options, explanation,type ) VALUES +('OPACEnhancedMessagingPreferences', '1', NULL, 'If ON, show patrons messaging setting on the OPAC.', 'YesNo') ON DUPLICATE KEY UPDATE value ='1'; +INSERT INTO systempreferences ( variable, value, options, explanation,type ) VALUES +('EnhancedMessagingPreferences', '1', NULL, 'If ON, allows patrons to select to receive additional messages about items due or nearly due.', 'YesNo') ON DUPLICATE KEY UPDATE value ='1';
Why do you want to modify the values on duplicate? You just need to insert the new pref OPACEnhancedMessagingPreferences with the same value as EnhancedMessagingPreferences. ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref @@ +157,5 @@
+ - pref: OPACEnhancedMessagingPreferences + choices: + yes: Show + no: "Don't show" + - "patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."
No need to uppercase NOTE. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #41 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 46003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46003&action=edit Bug 12528 - fix problem when insert OPACEnhancedMessagingPreferences -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46003|0 |1 is obsolete| | --- Comment #42 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 46015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46015&action=edit Bug 12528 - fix problem when insert OPACEnhancedMessagingPreferences Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mirko@abunchofthings.net | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Actually, this bug is a duplicate of bug 12528, sorry not to have see that before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9254 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #43)
Actually, this bug is a duplicate of bug 12528, sorry not to have see that before.
Read bug 9254. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- See Kyle's followup bug 9254 comment 4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Another issue is that there is no check in the opac/opac-messaging.pl script to forbid the user to modify the messaging changes, see my quick patch on bug 9254 comment 16. The correct way to continue here would be to mark this one as a duplicate of bug 9254 and work on it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #47 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 46082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46082&action=edit Bug 12528 - add check EnhancedMessagingPreference when call directly opac/opac-messaging.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Bouzid from comment #47) Please answer before switching back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #49 from Francois Charbonnier <francois.charbonnier@inlibro.com> --- Hi Jonathan, We should work on this patch because we have someone to work on it right now. The other one will be an enhancement of this one. Thanks et bonne année! ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #50 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Francois Charbonnier from comment #49)
Hi Jonathan, We should work on this patch because we have someone to work on it right now. The other one will be an enhancement of this one. Thanks et bonne année! ;)
Have you read the comments on bug 9254 I have pointed out? It's not an enhancement, both bug reports have the same goal. There is no need to ask for a signoff, it will fail QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #51 from Eric Bégin <eric.begin@inLibro.com> --- Howdy !
There is no need to ask for a signoff, it will fail QA. The latest commit by Bouzid fixed the problem from accessing the page when disabled (BTW, I asked him to change the code to have a single IF / ELSE statement in the .tt and change the pref name for EnhancedMessagingPreferencesOPAC which he will commit soon).
Concerning bug 9254, it basically add another option to the EnhancedMessagingPreferencesOPAC, so, from my understanding it's not quite a duplicate, but an enhancement of this one, as Francois pointed out. @Jonathan : Just want to check with you that this bug will move forward if we fix the behaviour when accessing the URL and changing the pref name. Cheers ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Eric Bégin from comment #51)
Howdy !
There is no need to ask for a signoff, it will fail QA. The latest commit by Bouzid fixed the problem from accessing the page when disabled (BTW, I asked him to change the code to have a single IF / ELSE statement in the .tt and change the pref name for EnhancedMessagingPreferencesOPAC which he will commit soon).
No, it's not. Please see, read and follow link on comment 46: "Another issue is that there is no check in the opac/opac-messaging.pl script to forbid the user to modify the messaging changes, see my quick patch on bug 9254 comment 16." It's not because a page is not accessible that a user cannot call it and pass parameters via POST or GET.
Concerning bug 9254, it basically add another option to the EnhancedMessagingPreferencesOPAC, so, from my understanding it's not quite a duplicate, but an enhancement of this one, as Francois pointed out.
We already discussed about that here, and we all on that. The discussions are exactly the same on both bug report, that's why I said it's a duplicate.
@Jonathan : Just want to check with you that this bug will move forward if we fix the behaviour when accessing the URL and changing the pref name.
Yes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46082|0 |1 is obsolete| | --- Comment #53 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 46156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46156&action=edit Bug 12528 - Rename OPACEnhancedMessagingPreferences and add redirect to 404 if at least 1 pref is off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46156|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46217&action=edit Bug 12528: Bug 9254: Followup - Rename pref to EnhancedMessagingPreferencesOPAC If the new pref is named EnhancedMessagingPreferencesOPAC, it will show up adjacent to EnhancedMessagingPreferences -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #55 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46218&action=edit Bug 12528: redirect to 404 if at least 1 pref is off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #56 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please keep authorship -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org