http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #31 from Francois Charbonnier <francois.charbonnier@inlibro.com> --- (In reply to Jonathan Druart from comment #28)
::: installer/data/mysql/atomicupdate/sysprefs_Bug12528.sql @@ +1,3 @@
+INSERT INTO systempreferences ( variable, value, options, explanation,type ) VALUES +('OPACEnhancedMessagingPreferences', '1', NULL, 'If ON, show patrons messaging setting on the OPAC.', 'YesNo') +;
It would be better to set the value of the other pref, to avoid any confusion.
EnhancedMessagingPreference is already setup by updatedatabase so I don't think this should be change by the atomicupdate here. Moreover, we don't want to change the current setting when the library will run this update.
OPACEnhancedMessagingPreferences is added (for existing install, so in updatedatabase.pl) and enabled. It does not hurt if EnhancedMessagingPreference is disabled, because in the code both are checked. But it would be better to enable OPACEnhancedMessagingPreferences only if EnhancedMessagingPreference is enabled too. It will avoid to have "OPACEnhancedMessagingPreference is enabled but not really because EnhancedMessagingPreference is not" on the admin pref page.
I agree. We will change the atomic update to enable the OPACEnhancedMessagingPreferences only if EnhancedMessagingPreference is enable as well. -- You are receiving this mail because: You are watching all bug changes.