http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Srdjan, I think adding granular permissions for administration is a good idea and I can think of more to be added later :) But I am not sure the system preference is needed here. We already have granular permissions for other modules. All granular permissions used to be controlled by a system preference that got removed after some time, because granular got to be standard over permissions on module level only. I think it should also be ok on update if both granular permissions are checked by default. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083 --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- I totally agree. The suspref was suggested in order not to disrupt other people, but when I looked at the workflow it did not make any sense. I've already removed it, just did not update the bug. Assigning both permissions goes without saying :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083 --- Comment #5 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- I have blocked "Circ and Fines rules" link if manage_circ_rules permission is missing, but did not do similar for all other links in case parameters_remaining_permissions is missing - I did not know how to do it and still have a decent looking screen. Any ideas welcome. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083 --- Comment #7 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 9686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9686&action=edit pa -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9578|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10638|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 10639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10639&action=edit [SIGNED-OFF] bug_8083: parameters subpermissions: manage_circ_rules and parameters_remaining_permissions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment, I was about passing QA this patch, when I saw in the updatedatabase: + $dbh->do("INSERT INTO user_permissions (borrowernumber, module_bit, code) + SELECT borrowernumber, 3, 'parameters_remaining_permissions' + FROM borrowers WHERE flags & (1 << 3)"); I think it gives the permission to all patrons that already had the 'admin' permission. But: 1- please confirm 2- a comment just before the request would be usefull for a future reader. Site comment: we have to find a way to handle translated user permission : our libraries are complaining that new ones are not translated. That's because the updatedatabase is in english & in english only. But that's another topic... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083 --- Comment #12 from Srdjan Jankovic <srdjan@catalyst.net.nz> ---

I think it gives the permission to all patrons that already had the 'admin' permission. But: 1- please confirm

Confirmed, except it is 'parameters' permission

2- a comment just before the request would be usefull for a future reader.

Done -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|unspecified |rel_3_10 --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- I tried to access all admin pages with a superlibrarian account after applying the patch, no problem displaying those pages. Good job srdjan. @all = follow-ups welcomed (in separate bugs) for introducing other admin granular permissions ! -- You are receiving this mail because: You are watching all bug changes.