[Bug 8487] New: C4::Installer::PerlDependencies needs Test::Strict hash corrected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8487 Priority: P5 - low Change sponsored?: --- Bug ID: 8487 Assignee: gmcharlt@gmail.com Summary: C4::Installer::PerlDependencies needs Test::Strict hash corrected Severity: critical Classification: Unclassified OS: All Reporter: mtompset@hotmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Installation and upgrade (command-line installer) Product: Koha In my koha development system, I was doing testing: Valid Cases to check ------------------------- ./koha_perl_deps ./koha_perl_deps -h ./koha_perl_deps -a ./koha_perl_deps -m ./koha_perl_deps -i ./koha_perl_deps -u ./koha_perl_deps -a -c ./koha_perl_deps -m -c ./koha_perl_deps -i -c ./koha_perl_deps -u -c ./koha_perl_deps -m -u ./koha_perl_deps -m -u -c ------------------------- Invalid Cases to check ------------------------- ./koha_perl_deps -s ./koha_perl_deps -s -u ./koha_perl_deps -s -u -c ------------------------- Cases 3, 4, 7, 8, 11, and 12 (Numbered from 1 sequentially in the above list) would fail on Test::Strict which is does not have a defined version required. I thought of patching koha_perl_deps.pl, which bypasses the problem. However, I think the problem lies in the C4::Installer::PerlDependencies module. Only Test::Strict is lacking a 'min_ver'. The 'required' is set to the version number. All other 'required' values are '1' or '0'. This leads me to believe that 'required' should be 'min_ver' and 'required' => '1' be added. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8487 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 11060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11060&action=edit Added 'require' => '1', and moved old value to a 'min_ver' => '0.14' line Before the patch: koha_perl_deps.pl -a should generate an error on Test::Strict After the patch: koha_perl_deps.pl -a should not generate an error on Test::Strict -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8487 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8487 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #1)
Created attachment 11060 [details] Added 'require' => '1', and moved old value to a 'min_ver' => '0.14' line
Before the patch: koha_perl_deps.pl -a should generate an error on Test::Strict After the patch: koha_perl_deps.pl -a should not generate an error on Test::Strict
I'm not sure Test::Strict is required, I think it could be 0. Its only used by one database dependent test, so will not be run when calling make test. If you rework the patch to make it not required, I'll sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8487 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- See also bug 7368 latest patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8487 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Okay, I see that the patch for bug 7368 does fix this problem as Chris desired. I think I'll mark this as DUPLICATE as a result. Thanks for pointing this out, M. de Rooy. *** This bug has been marked as a duplicate of bug 7368 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org