https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41747 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192287&action=edit Bug 41747: Tidy js/ill-availability.js xt/js_tidy.t does not check all files every run (it's using the incremental runs). Something happened (node version changed?) and this is triggered because bug 41512 modified those files Test plan: 0. Do not apply this patch 1. KOHA_CI_INCREMENTAL_RUNS=1 prove xt/js_tidy.t => fail 2. Apply this patch 3. Run prove again => pass 4. Run prove without the env var set => pass (i.e. there are no other JS files not tidy) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41747 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Status|Signed Off |Failed QA --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- For me, running the qa tools in ktd says this file is untidy.. I run the suggested tidy and it reverses your changes here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41747 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- It's actually failing on Jenkins last run (Koha_Main/3560), that's why I submitted the patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41747 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Martin Renvoize (ashimema) from comment #2)

For me, running the qa tools in ktd says this file is untidy.. I run the suggested tidy and it reverses your changes here.

For me this solves the tidy issue and the tool does not try to re-tidy it badly. I am using `KOHA_IMAGE=main-bookworm ktd up` when I bring up KTD. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41747 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192287|0 |1 is obsolete| | --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192808&action=edit Bug 41747: Tidy js/ill-availability.js xt/js_tidy.t does not check all files every run (it's using the incremental runs). Something happened (node version changed?) and this is triggered because bug 41512 modified those files Test plan: 0. Do not apply this patch 1. KOHA_CI_INCREMENTAL_RUNS=1 prove xt/js_tidy.t => fail 2. Apply this patch 3. Run prove again => pass 4. Run prove without the env var set => pass (i.e. there are no other JS files not tidy) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41747 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #9 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- kohadev-koha@kohadevbox:koha(main)$ KOHA_CI_INCREMENTAL_RUNS=1 prove xt/js_tidy.t xt/js_tidy.t .. ls: cannot access '/tmp/koha-ci-results/js_tidy/bookworm': No such file or directory xt/js_tidy.t .. ok All tests successful. Files=1, Tests=365, 605 wallclock secs ( 0.21 usr 0.05 sys + 426.26 cusr 84.12 csys = 510.64 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.