[Bug 42272] New: Purchase Suggestion search by bibliographic information broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42272 Bug ID: 42272 Summary: Purchase Suggestion search by bibliographic information broken Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lisette@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: Create a suggestion with a title "Calico Captive" with a branch that matches your branch. Go to the suggestion page and use the left hand side "Bibliographic Information" search to search for your title. No results are returned, even if there is one that should be. With copyright date it also throws a datatable error. The title can still be filtered in the table filter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42272 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42272 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41999 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42272 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #1 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- We're seeing this on our production server, but staff report that they only see the problem with some titles and not others. The example that was given to me was "Cactus Hotel" by Brenda Guiberson. After much experimentation, I've found I can control whether or not the error is reproduced by changing the title and search term: If I search by "hotel", the suggestion is returned. If I search by "Cactus", no results are returned. If I change the first word of the suggestion and then search by the new first word... "actus" - no results "cctus" - no results "atus" - the suggestion is returned "plum" - the suggestion is returned It's the end of my workday and I'll experiment more tomorrow, but it seems like the exact characters in the title are causing the error somehow? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42272 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov --- Comment #2 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Aha! The API string isn't getting escaped properly, and the wildcard % gets added behind the scenes to make it a "contains" search rather than an exact match...so if the first two characters of the search term happen to be a valid hex code (for instance, "ca"), then the characters (in this case, "%ca") get interpreted as a special character and break the search. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42272 --- Comment #3 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 196936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196936&action=edit Bug 42272: Escape api string To test: 1. Go to Acquisitions > Suggestions 2. Create a purchase suggestion with a title "Calico Captive" with a branch that matches your branch 3. Go to the suggestion page and use the left-hand side "Bibliographic information" search to search for the title --> The suggestions table is empty 4. Apply patch, clear browser cache, and refresh the page 5. Use the "Bibliographic information" search to search for the title again --> The suggestion is found -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42272 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42272 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42272 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42272 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42272 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42272 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196936|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42272 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 196974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196974&action=edit Bug 42272: Escape api string To test: 1. Go to Acquisitions > Suggestions 2. Create a purchase suggestion with a title "Calico Captive" with a branch that matches your branch 3. Go to the suggestion page and use the left-hand side "Bibliographic information" search to search for the title --> The suggestions table is empty 4. Apply patch, clear browser cache, and refresh the page 5. Use the "Bibliographic information" search to search for the title again --> The suggestion is found Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42272 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes searching for release notes| |suggestions using the | |"Bibliographic information" | |filter on the acquisitions | |page in the staff interface | |(Acquisitions > | |Suggestions). | | | |Searching was not working | |as expected in some | |situations. For example, | |searching for a title of an | |existing suggestion did not | |return any results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42272 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Signed Off |RESOLVED --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 41783 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org