[Bug 22116] New: Add price formatting to rental charge and replacement price on items tab in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116 Bug ID: 22116 Summary: Add price formatting to rental charge and replacement price on items tab in staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: katrin.fischer@bsz-bw.de Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 22112 Target Milestone: --- Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112 [Bug 22112] Omnibus: Use Price filter everywhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22112 Status|NEW |ASSIGNED Depends on|22112 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112 [Bug 22112] Omnibus: Use Price filter everywhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 83836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83836&action=edit Bug 22116: Add price formatting to rental charge and replacement price on items tab in staff Adds formatting to replacement price and rental charge on items tab. To test: - Add a rental charge to one or more of your item types - Edit a record with some items, add replacement cost to some - Find or create a record with your rental charged itemtype (MARC21:942$c) - Go to the staff detail page of those records - Check "Items" tab for - Rental charge on top - Replacement price for items - Verify information is displayed correctly when toggling CurrencyFormat system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22117 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116 Jack <jke0429@stacmail.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116 Jack <jke0429@stacmail.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83836|0 |1 is obsolete| | --- Comment #2 from Jack <jke0429@stacmail.net> --- Created attachment 83922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83922&action=edit Bug 22116: Add price formatting to rental charge and replacement price on items tab in staff Adds formatting to replacement price and rental charge on items tab. To test: - Add a rental charge to one or more of your item types - Edit a record with some items, add replacement cost to some - Find or create a record with your rental charged itemtype (MARC21:942$c) - Go to the staff detail page of those records - Check "Items" tab for - Rental charge on top - Replacement price for items - Verify information is displayed correctly when toggling CurrencyFormat system preference Signed-off-by: Jack Kelliher <jke0429@stacmail.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you, Jack! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83922|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84888&action=edit Bug 22116: Add price formatting to rental charge and replacement price on items tab in staff Adds formatting to replacement price and rental charge on items tab. To test: - Add a rental charge to one or more of your item types - Edit a record with some items, add replacement cost to some - Find or create a record with your rental charged itemtype (MARC21:942$c) - Go to the staff detail page of those records - Check "Items" tab for - Rental charge on top - Replacement price for items - Verify information is displayed correctly when toggling CurrencyFormat system preference Signed-off-by: Jack Kelliher <jke0429@stacmail.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Simple QA.. Passed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22116 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org