https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21751 CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Confirmed :( Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 [Bug 21751] fixFloat toolbar not displaying properly in Chrome -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22293 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84864&action=edit Bug 22293: Sticky toolbar making vendor form uneditable The new floating toolbar plugin doesn't like a particular combination of markup: A toolbar inside a form which is styled "display:inline." The staff client CSS styles forms that way globally, so it must be explicitly overridden in these situations. Changing the default will have broad consequences, so I propose an inline style to fix this. To test, apply the patch and go to Acquisitions. Add or edit a vendor and confirm that after scrolling down the page the form is still editable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22293 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84864|0 |1 is obsolete| | --- Comment #3 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 84865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84865&action=edit Bug 22293: Sticky toolbar making vendor form uneditable The new floating toolbar plugin doesn't like a particular combination of markup: A toolbar inside a form which is styled "display:inline." The staff client CSS styles forms that way globally, so it must be explicitly overridden in these situations. Changing the default will have broad consequences, so I propose an inline style to fix this. To test, apply the patch and go to Acquisitions. Add or edit a vendor and confirm that after scrolling down the page the form is still editable. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22293 Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84865|0 |1 is obsolete| | --- Comment #4 from Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> --- Created attachment 84904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84904&action=edit Bug 22293: Sticky toolbar making vendor form uneditable The new floating toolbar plugin doesn't like a particular combination of markup: A toolbar inside a form which is styled "display:inline." The staff client CSS styles forms that way globally, so it must be explicitly overridden in these situations. Changing the default will have broad consequences, so I propose an inline style to fix this. To test, apply the patch and go to Acquisitions. Add or edit a vendor and confirm that after scrolling down the page the form is still editable. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22293 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for the quick fix and 2 sign-offs! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22293 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.