[Bug 31336] New: In-progress background jobs give incorrect progress message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31336 Bug ID: 31336 Summary: In-progress background jobs give incorrect progress message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: andrewfh@dubcolib.org QA Contact: testopia@bugs.koha-community.org Depends on: 31245 If one loads the background job details page (background_jobs.pl) for a job that has started but not yet completed, Koha shows a message of "No items modified." We should give an accurate message along the lines of "This job is still in progress." A completed job lists all of the modified items/bibs/whatever. I'm ambivalent about whether or not we need to list the already-modified records when loading this page for an incomplete job. To recreate: 1 - write a report, SELECT itemnumber FROM items. With the default dev data, that's 961 items. 2 - use your report to send all of those to batch mod. The page will take a while to load 3 - while your batch mod page is loading, open background_jobs.pl in another tab and have it ready to go 4 - modify something in all 961 records -- add a public note or something -- once you submit this job it should take about 45 seconds to complete 5 - BEFORE THE JOB IS DONE - reload background_jobs.pl, see your job is listed and shows status=started. click to the details view for your job, see it shows a message of "No items modified." Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245 [Bug 31245] Job detail view for batch mod explode if job not started -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31336 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Also true for deletion "All records have been deleted successfully!” -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31336 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31336 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- I rise to major importance, this could lead to misunderstanding. I see in template : [% IF job.status != 'new' %][% PROCESS 'report' %][% END %] https://git.koha-community.org/Koha-community/Koha/src/commit/9c565eff1357c2... Should we simply change for job.status finished, canceled or failed ? Also : I see some templates are managing the cancel status : https://git.koha-community.org/Koha-community/Koha/src/commit/00e33f87580876... It is missing in batch biblio record deletion. Maybe we should change includes to define "report_sucess", "report_canceled" ... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31336 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah also I see the template uses : [% SET report = job.report %] [% IF report %] But job.report returns empty hashref : https://git.koha-community.org/Koha-community/Koha/src/commit/2eca0fe3632bf0... May we return undef ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31336 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35092 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35092 [Bug 35092] [OMNIBUS] Remaining background job/worker issues -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org