[Bug 41880] New: Logs for moved holds don't indicate original bib number/item number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Bug ID: 41880 Summary: Logs for moved holds don't indicate original bib number/item number Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com If a hold is moved from bib A to bib B (or from item A to item B), and no change was made to the hold before the move, there is no way to identify the bib or item number of the original hold. To replicate: -Place a hold on bib A (or item A) -View it in Tools > Logs using the reserve_id. As is standard, no details other than the reserve_id show in the Info column. -Move the hold to bib B (or item B) -Run the holds log again for the reserve_id. Note that an entry is generated for the move, but only the bib number (or item number) it was *moved to* shows. There is no way to know what bib or item the hold was moved *from*. If a change is made to a hold before it's moved, staff will be able to see the original bib number/item number in logs. But there are likely to be many cases where the first change made to a hold is moving it to a new bib/item, which means that the original bib number/item number will be untraceable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|25.11 |Main CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- The way to identify the bib or item number of the original hold is via the 'diff' column. See Bug 39628 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39628 However, I still notice a bug when logging a hold. The Old and New itemnumbers are the same. I will attempt to fix that here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- To recreate: 1. Place a hold on bib A (or item A) 2. Move the hold to bib B (or item B) 3. Observe the diff column: The Old (O) and New (N) biblionumbers are the same. This is incorrect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31698 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 [Bug 31698] Add ability to move a hold to a new bibliographic record/item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 194039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194039&action=edit Bug 41880: Keep original copy of hold for proper logging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 194040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194040&action=edit Bug 41880: Add a unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194039|0 |1 is obsolete| | --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 194181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194181&action=edit Bug 41880: Keep original copy of hold for proper logging To test: 0. APPLY PATCH, restart_all. 1. Make sure HoldsLog is enabled 2. Place a record/bib level hold on bib A. 3. Move the hold to bib B. 4. Look at the diff column in the holds log. You should see the Old (0) biblionumber and the New (N) biblionumber. You should see nothing about itemnumber because this is a record level hold. 5. Ensure that the New and Old biblionumbers are the correct ones. 6. Place an item level hold on item A. 7. Mobe the hold to item B 8. Look at the diff column in the holds log. You should see the Old (0) biblionumber and the New (N) biblionumber. You should also see the New and Old itemnumbers since this is an item level hold. 8. Ensure that the New and Old biblionumbers AND the New and Old itemnumbers are correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194040|0 |1 is obsolete| | --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 194182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194182&action=edit Bug 41880: Add a unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 194183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194183&action=edit Bug 41880: Add a unit test for item level holds logging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194181|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 194188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194188&action=edit Bug 41880: Keep original copy of hold for proper logging To test: 0. APPLY PATCH, restart_all. 1. Make sure HoldsLog is enabled 2. Place a record/bib level hold on bib A. 3. Move the hold to bib B. 4. Look at the diff column in the holds log. You should see the Old (0) biblionumber and the New (N) biblionumber. You should see nothing about itemnumber because this is a record level hold. 5. Ensure that the New and Old biblionumbers are the correct ones. 6. Place an item level hold on item A. 7. Mobe the hold to item B 8. Look at the diff column in the holds log. You should see the Old (0) biblionumber and the New (N) biblionumber. You should also see the New and Old itemnumbers since this is an item level hold. 8. Ensure that the New and Old biblionumbers AND the New and Old itemnumbers are correct. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194182|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 194189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194189&action=edit Bug 41880: Add a unit test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194183|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 194190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194190&action=edit Bug 41880: Add a unit test for item level holds logging Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |If a record-level hold is release notes| |moved from one record to | |another (or an item-level | |hold is moved from one item | |to another), and no change | |was made to the hold before | |it was moved, there was no | |way to identify the record | |or item for the original | |hold (when HoldsLog is | |enabled). | | | |With this change, both the | |old record (or item) number | |and new record number (or | |item) are now shown in the | |log viewer Info and Diff | |columns. | | | |This is shown in the diff | |column as O for the old | |biblionumber (or | |itemnumber) and N for the | |new biblionumber (or | |itemnumber). | | | |Example for the Diff column | |for a record-level hold | |that was moved: | | | |- Before (note "O":"11" and | |"N":11): | | | |{"D":{"biblionumber":{"O":" | |11","N":11},"timestamp":{"O | |":"2026-02-28 | |02:39:44","N":"2026-02-28 | |02:42:02"}}} | | | |- After (note "N":11 and | |"O":262): | | | |{"D":{"biblionumber":{"N":1 | |1,"O":262},"timestamp":{"O" | |:"2026-02-28 | |02:54:57","N":"2026-02-28 | |02:55:18"}}} | | | |Example for the Diff column | |for a record-level hold | |that was moved: | | | |- Before (note that no | |biblionumbers or | |itemnumbers are shown): | | | |{"D":{"timestamp":{"N":"202 | |6-02-28 | |02:51:07","O":"2026-02-28 | |02:50:00"}}} | | | |- After (note that the new | |and old biblionumbers and | |itemnumbers are now shown): | | | |{"D":{"biblionumber":{"O":1 | |39,"N":255},"itemnumber":{" | |N":563,"O":296},"timestamp" | |:{"N":"2026-02-28 | |02:59:33","O":"2026-02-28 | |02:58:34"}}} CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196713&action=edit Bug 41880: Keep original copy of hold for proper logging To test: 0. APPLY PATCH, restart_all. 1. Make sure HoldsLog is enabled 2. Place a record/bib level hold on bib A. 3. Move the hold to bib B. 4. Look at the diff column in the holds log. You should see the Old (0) biblionumber and the New (N) biblionumber. You should see nothing about itemnumber because this is a record level hold. 5. Ensure that the New and Old biblionumbers are the correct ones. 6. Place an item level hold on item A. 7. Mobe the hold to item B 8. Look at the diff column in the holds log. You should see the Old (0) biblionumber and the New (N) biblionumber. You should also see the New and Old itemnumbers since this is an item level hold. 8. Ensure that the New and Old biblionumbers AND the New and Old itemnumbers are correct. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196714&action=edit Bug 41880: Add a unit test Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196715&action=edit Bug 41880: Add a unit test for item level holds logging Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 --- Comment #15 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Pushed to stable |Needs documenting --- Comment #16 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Missing dependencies, not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org