[Bug 32203] New: Refactor checkauth() auth rejected to improve maintainability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32203 Bug ID: 32203 Summary: Refactor checkauth() auth rejected to improve maintainability Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org checkauth() appears to be 706 lines at the time of this writing. The "AUTH rejected" section is 154 lines or over 20% of the function. It's a section devoted mainly to setting up the authentication template, so it's a very low risk part to change, and for the most part easy to change, since you just need to check the display on a failed auth. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32203 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32203 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 143888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143888&action=edit Bug 32203: Add render_auth_page() function This change adds a "render_auth_page()" function to C4::Auth for rendering the login page for a failed auth/login. Test plan: 0. Don't apply patch yet 1. In new tab, go to http://localhost:8081/ and do a failed login 2. In new tab, go to http://localhost:8080/ and do a failed login 3. Apply patch 4. In new tab, go to http://localhost:8081/ and do a failed login 5. In new tab, go to http://localhost:8080/ and do a failed login 6. Note how the failed login screens look the same after the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32203 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook@prosentient.com.au |koha-bugs@lists.koha-commun | |ity.org --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I think I let my excitement to refactor C4::Auth get the better of me. Resetting this one to default assignee as I've run out of steam. This patch probably needs to be split out into 30-50 smaller patches to make the amount of testing actually workable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32203 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32205 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32203 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32203 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Actually, I think I made a mistake taking out "suggestion" as it doesn't use Koha.Preference() in the masthead, so the purchase suggestions wouldn't show up correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32203 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- This one is still worthwhile but I think it would be a good idea to break it up into multiple more easily testable bug reports. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32203 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Things have changed a bit but still looks like some cleanup could be done -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org