[Bug 34021] New: Add option to search within results on the opac interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Bug ID: 34021 Summary: Add option to search within results on the opac interface Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: hagud@orex.es QA Contact: testopia@bugs.koha-community.org related: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546 In 22.11 has been added the option of searching within results of a search, it should be nice to add also to opac. Or even it could be improved with the chance of search within subcollections.. It should be great if a search could be filtered by default via itypetype, ccode or anyother value in item or perhaps and biblio and koha keeps the filter in all searches of a user does. For example: if a library have a special collection of old books, and a user starts a search limiting by collection, let the filter on and being able to search within results now a facet filter od ccode limitation is lost when launch a search BR -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 153693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153693&action=edit Bug 34021: Add 'search within' to OPAC This change adds a "Search within results" box to the OPAC, which complements the feature already in the staff interface. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 2. Type "e" in the search box and click the search button 3. Click the "Books" value for the "Item types" facet, and note there are fewer search results 4. Type "test" into the "Search within results" box and click the Search button next to the box 5. Note that now there are only 2 results. 6. Also note that the "Books" facet is still selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add option to search within |Add option to search within |results on the opac |results in the OPAC |interface | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153693|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 153729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153729&action=edit Bug 34021: Add 'search within' to OPAC This change adds a "Search within results" box to the OPAC, which complements the feature already in the staff interface. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 2. Type "e" in the search box and click the search button 3. Click the "Books" value for the "Item types" facet, and note there are fewer search results 4. Type "test" into the "Search within results" box and click the Search button next to the box 5. Note that now there are only 2 results. 6. Also note that the "Books" facet is still selected Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Hey David, I imagine some libraries will want to hide this altogether. Could we possibily wrap it label/input in a HTML element w/ a class or ID? That would make it easy to do so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 155872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155872&action=edit Bug 34021: wrap search within using block with an ID for styling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Lucas Gass from comment #3)
Hey David,
I imagine some libraries will want to hide this altogether. Could we possibily wrap it label/input in a HTML element w/ a class or ID? That would make it easy to do so.
Sure thing. Popped this back to Signed Off as it was a simple change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153729|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158137&action=edit Bug 34021: Add 'search within' to OPAC This change adds a "Search within results" box to the OPAC, which complements the feature already in the staff interface. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 2. Type "e" in the search box and click the search button 3. Click the "Books" value for the "Item types" facet, and note there are fewer search results 4. Type "test" into the "Search within results" box and click the Search button next to the box 5. Note that now there are only 2 results. 6. Also note that the "Books" facet is still selected Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155872|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158138&action=edit Bug 34021: wrap search within using block with an ID for styling Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #8 from David Cook <dcook@prosentient.com.au> --- I hate failing my own stuff, but I noticed a problem. If you do a search like this one: http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=an%3A104&weight_search=1 You can try to "Search within results" using "Alcestis" but it won't work. The reason is that this URL is the one that is constructed: http://localhost:8080/cgi-bin/koha/opac-search.pl?q=ccl%3Dan%3A104&idx=kw&q=Alcestis&sort_by=relevance&addto=Add+to... The an:104 has a ccl= prefix which causes the rest of the query string to be ignored. So either Search.pm needs a change or this change needs to be changed. -- It looks like a fix could be to follow the code from bug 27546 and instead of adding a "idx=kw and q=X" just add a "limit=X". At a glance, that looks like it would work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #8)
It looks like a fix could be to follow the code from bug 27546 and instead of adding a "idx=kw and q=X" just add a "limit=X". At a glance, that looks like it would work.
Technically, that will yield a worse version of "search within" than I had in some ways, but it would make it consistent with the staff interface version. In order to get limit to work like "idx=kw and q=X", we'd need to add "kw,wrdl,rtrn:" in front of "X" which would need some Javascript. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- Created attachment 158166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158166&action=edit Bug 34021: Make search within OPAC consistent with staff interface Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 2. Type "an:104" in the search box and click the search button 3. Type "Alcestis" into the "Search within results" box and click the Search button next to the box 4. Note that now there are only 2 results 5. Type "Dale" into the "Search within results" box and click the Search button next to the box 6. Note that you're taken directly to the last result -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158137|0 |1 is obsolete| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158579&action=edit Bug 34021: Add 'search within' to OPAC This change adds a "Search within results" box to the OPAC, which complements the feature already in the staff interface. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 2. Type "e" in the search box and click the search button 3. Click the "Books" value for the "Item types" facet, and note there are fewer search results 4. Type "test" into the "Search within results" box and click the Search button next to the box 5. Note that now there are only 2 results. 6. Also note that the "Books" facet is still selected Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158138|0 |1 is obsolete| | --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158580&action=edit Bug 34021: wrap search within using block with an ID for styling Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158166|0 |1 is obsolete| | --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158581&action=edit Bug 34021: Make search within OPAC consistent with staff interface Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 2. Type "an:104" in the search box and click the search button 3. Type "Alcestis" into the "Search within results" box and click the Search button next to the box 4. Note that now there are only 2 results 5. Type "Dale" into the "Search within results" box and click the Search button next to the box 6. Note that you're taken directly to the last result Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- The new limit does not show up in the search results description. It does in the staff search. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #15 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Boosting this again -- this would be a great feature to have in the Koha OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- For some reason I thought this had been added in. I'll have to revisit at some point... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org