[Bug 10607] New: JavaScript indexOf function not supported by IE 7 and 8
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10607 Bug ID: 10607 Summary: JavaScript indexOf function not supported by IE 7 and 8 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleonard@myacpl.org Reporter: gmcharlt@gmail.com QA Contact: testopia@bugs.koha-community.org The indexOf JavaScript function is not supported by IE 7 and 8. This bug is a omnibus for replacing it in Koha JavaScript code. Grepping indicates that the following files may be affected: gmc@zadi:~/koha$ grep -rl indexOf koha-tmpl/intranet-tmpl/prog/en/{includes,modules,js} koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt koha-tmpl/intranet-tmpl/prog/en/js/additem.js koha-tmpl/intranet-tmpl/prog/en/js/xmlControlfield.js koha-tmpl/intranet-tmpl/prog/en/js/acq.js koha-tmpl/intranet-tmpl/prog/en/js/basket.js koha-tmpl/intranet-tmpl/prog/en/js/datatables.js gmc@zadi:~/koha$ grep -rl indexOf koha-tmpl/opac-tmpl/prog/en/{includes,modules,js} koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tt koha-tmpl/opac-tmpl/prog/en/js/browserid_include.js koha-tmpl/opac-tmpl/prog/en/js/amazonimages.js koha-tmpl/opac-tmpl/prog/en/js/basket.js koha-tmpl/opac-tmpl/prog/en/js/datatables.js koha-tmpl/opac-tmpl/prog/en/js/bakertaylorimages.js The following external JavaScript library files may use it as well, but that isn't necessarily a problem, as they may be doing so in a cross-browser way: gmc@zadi:~/koha$ grep -rl indexOf koha-tmpl/opac-tmpl/prog/en/lib koha-tmpl/opac-tmpl/prog/en/lib/greybox/GreyBox_v5_5/greybox_source/auto_deco.js koha-tmpl/opac-tmpl/prog/en/lib/greybox/GreyBox_v5_5/greybox_source/base/base.js koha-tmpl/opac-tmpl/prog/en/lib/greybox/GreyBox_v5_5/greybox_source/base/AJS.js koha-tmpl/opac-tmpl/prog/en/lib/greybox/AJS.js koha-tmpl/opac-tmpl/prog/en/lib/greybox/gb_scripts.js koha-tmpl/opac-tmpl/prog/en/lib/jquery/jquery.js koha-tmpl/opac-tmpl/prog/en/lib/jquery/jquery-ui.js koha-tmpl/opac-tmpl/prog/en/lib/jquery/plugins/jquery.metadata.min.js koha-tmpl/opac-tmpl/prog/en/lib/jquery/plugins/jquery.highlight-3.js koha-tmpl/opac-tmpl/prog/en/lib/jquery/plugins/jquery.dataTables.min.js gmc@zadi:~/koha$ grep -rl indexOf koha-tmpl/intranet-tmpl/prog/en/lib koha-tmpl/intranet-tmpl/prog/en/lib/yui/container/container_core-debug.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/container/container_core.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/container/container-min.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/container/container.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/container/container-debug.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/container/container_core-min.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/yahoo-dom-event/yahoo-dom-event.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/utilities/utilities.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/menu/menu-min.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/menu/menu-debug.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/menu/menu.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/plugins/bubbling-min.js koha-tmpl/intranet-tmpl/prog/en/lib/greybox/GreyBox_v5_5/greybox_source/auto_deco.js koha-tmpl/intranet-tmpl/prog/en/lib/greybox/GreyBox_v5_5/greybox_source/base/base.js koha-tmpl/intranet-tmpl/prog/en/lib/greybox/GreyBox_v5_5/greybox_source/base/AJS.js koha-tmpl/intranet-tmpl/prog/en/lib/greybox/AJS.js koha-tmpl/intranet-tmpl/prog/en/lib/greybox/gb_scripts.js koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.uitablefilter.js koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery-ui-timepicker-addon.js koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.dataTables.min.js koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.dataTables.columnFilter.js [1] http://kangax.github.io/es5-compat-table/#Array.prototype.indexOf -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10607 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10541 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10607 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think one of the problems possibly related to the use of IndexOf is the inability to select irregularities when creating subscriptions in serials. I can't test it here as I don't have an old IE, so that's from my training notes. koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10607 --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Katrin Fischer from comment #1)
I think one of the problems possibly related to the use of IndexOf is the inability to select irregularities when creating subscriptions in serials. I can't test it here as I don't have an old IE, so that's from my training notes. koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
Based on my (and others) testing of the patch for bug 10541, this sort of thing can be tested in IE 9 or 10 by using "F12 developer tools" to set the browser mode to IE 7 or IE 8. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10607 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Cool, thx! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10607 --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- I've found one template in the Bootstrap theme that is affected: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10607 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Where IE emulation fails, you can always try an IE testing VM as well: www.modern.ie I've been using the Win 7 IE 8 recently and have no complaints. Mind you, they expire after a set period of time, so if it's not easy to "refresh" it...I'll be a bit cranky. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10607 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org