[Bug 14505] New: single quotes in journal number cause print routing list window to not appear
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Bug ID: 14505 Summary: single quotes in journal number cause print routing list window to not appear Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com To replicate: Have a serial, receive a serial with a number as follows: iam 1000: The World's Leading Patent Professionals 2015 Set up a routing list for this serial. Click on "Serial Collection" [Fail condition] Click "Print routing list" - the window will not appear. Edit the received serials, remove the single quote from the number, save it. [Success condition] Click "Print routing list" - the window will appear, and the list can be printed. There may be other characters that cause this as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 --- Comment #1 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 41705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41705&action=edit Bug 14505: single quotes in journal number cause print routing list window to not appear Escapes single quotes from serial.serialseq string. Test plan: 1. Have a serial with a number which has single quote in it. 2. Go to Serials -> Find some serial subscription -> Serial collection. 3. Set up a routing list for this serial. 4. Click on Print list under the column Routing. 5. Notice that the print window doesn't open. 6. Apply patch. 7. Notice that the print window opens. Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14691 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |j.kylmala@gmail.com |ity.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- I was looking at something similar for bug 14691 and David pointed out http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 which may fix this sort of problem across the board. I just haven't had a chance to investigate whether or not that is true. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #3 from Joonas Kylmälä <j.kylmala@gmail.com> --- If we use something like Template::Stash::AutoEscape then we can get this fixed quite soon but if we wait for the Template Toolkit version 2.26 in Debian then it might take a while. We will wait and see what happens. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- It will fix it, but the patch for that isn't ready and may take a while - it would be good to get bugfixes like this at least back into stable versions. Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #5 from Joonas Kylmälä <j.kylmala@gmail.com> --- (In reply to Liz Rea from comment #4)
It will fix it, but the patch for that isn't ready and may take a while - it would be good to get bugfixes like this at least back into stable versions.
Liz
I'll then change the status to "needs sign off". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 42106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42106&action=edit [Signed-off] Bug 14505: single quotes in journal number cause print routing list window to not appear Escapes single quotes from serial.serialseq string. Test plan: 1. Have a serial with a number which has single quote in it. 2. Go to Serials -> Find some serial subscription -> Serial collection. 3. Set up a routing list for this serial. 4. Click on Print list under the column Routing. 5. Notice that the print window doesn't open. 6. Apply patch. 7. Notice that the print window opens. Sponsored-by: Vaara-kirjastot Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #41705|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42106|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42140&action=edit Bug 14505: single quotes in journal number cause print routing list window to not appear Escapes single quotes from serial.serialseq string. Test plan: 1. Have a serial with a number which has single quote in it. 2. Go to Serials -> Find some serial subscription -> Serial collection. 3. Set up a routing list for this serial. 4. Click on Print list under the column Routing. 5. Notice that the print window doesn't open. 6. Apply patch. 7. Notice that the print window opens. Sponsored-by: Vaara-kirjastot Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14744 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Joonas! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org