https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114535|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 114562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114562&action=edit Bug 27282: Add window.onafterprint function TO TEST: -set up a new list with a few items -go to /cgi-bin/koha/virtualshelves/shelves.pl and view that list. -Click 'Print List' in Chrome. -The tab opens but immediately closes itself. -Apply patch and clear cache -Try again, the print dialouge remains open Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114562|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114685&action=edit Bug 27282: Add window.onafterprint function TO TEST: -set up a new list with a few items -go to /cgi-bin/koha/virtualshelves/shelves.pl and view that list. -Click 'Print List' in Chrome. -The tab opens but immediately closes itself. -Apply patch and clear cache -Try again, the print dialouge remains open Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There are two other occurrences, should not we fix them as well? koha-tmpl/intranet-tmpl/prog/en/includes/slip-print.inc: setTimeout('window.close()', 1); koha-tmpl/opac-tmpl/bootstrap/en/includes/slip-print.inc: setTimeout('window.close()', 1); -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Waiting for an answer. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #5)

There are two other occurrences, should not we fix them as well?

koha-tmpl/intranet-tmpl/prog/en/includes/slip-print.inc: setTimeout('window.close()', 1);

koha-tmpl/opac-tmpl/bootstrap/en/includes/slip-print.inc: setTimeout('window.close()', 1);

Yes, I think we should fix it everywhere for consistency. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 114933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114933&action=edit Bug 27282: fix all occurrences This patch fixes all the occurrences, staff and OPAC. The problem only happens on some versions of Chrome. TO TEST: -set up a new list with a few items -go to /cgi-bin/koha/virtualshelves/shelves.pl and view that list. -Click 'Print List' in Chrome. -The tab opens but immediately closes itself. -Apply patch and clear cache -Try again, the print dialouge remains open -Go to cgi-bin/koha/sco/sco-main.pl in Chrome, make sure you can finish and print successfully -In the staff client in Chrome makes sure printing works in the following areas: 1. /cgi-bin/koha/circ/circulation.pl Print Slip and Print Quick Slip 2. /cgi-bin/koha/members/boraccount.pl Make a payment and make sure you can print the invoice 3. cgi-bin/koha/labels/spinelabel-home.pl Make a quick spine label in Chrome and make sure that prints. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Printing in some versions release notes| |of Google Chrome does not | |work correctly making it | |impossible to print. This | |patch alters the JavaScript | |which controls the print | |dialogues in order to make | |for a better a printing | |experience across all | |browsers. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |timothy_alexis.vass@ub.lu.s | |e --- Comment #9 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- I tried to sign off but the printing worked in this version of Chrome. Version 88.0.4324.146 (Official Build) (64-bit) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Lucas Gass from comment #10)

(In reply to Timothy Alexis Vass from comment #9)

...

I tried to sign off but the printing worked in this version of Chrome. Version 88.0.4324.146 (Official Build) (64-bit)

This was last happening for me in Chrome 78.0.3904.97

According to https://en.wikipedia.org/wiki/Google_Chrome_version_history, Chrome 78 has been discontinued. Versions 87 and 88 are stable. (I've actually been playing with Chromium 90 lately too as Playwright uses it but that's a dev build. Puppeteer uses Chromium 88.) I reckon it should be safe to target only stable versions? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Margaret Hade <margaret@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret@bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- (In reply to Lucas Gass from comment #12)

...

I reckon it should be safe to target only stable versions?

In Bug 24061 we fixed this for the OPAC. For consistency sake shouldn't we add this fix everywhere?

Sounds fair to me heh. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119339&action=edit Bug 27282: fix all occurrences This patch fixes all the occurrences, staff and OPAC. The problem only happens on some versions of Chrome. TO TEST: -set up a new list with a few items -go to /cgi-bin/koha/virtualshelves/shelves.pl and view that list. -Click 'Print List' in Chrome. -The tab opens but immediately closes itself. -Apply patch and clear cache -Try again, the print dialouge remains open -Go to cgi-bin/koha/sco/sco-main.pl in Chrome, make sure you can finish and print successfully -In the staff client in Chrome makes sure printing works in the following areas: 1. /cgi-bin/koha/circ/circulation.pl Print Slip and Print Quick Slip 2. /cgi-bin/koha/members/boraccount.pl Make a payment and make sure you can print the invoice 3. cgi-bin/koha/labels/spinelabel-home.pl Make a quick spine label in Chrome and make sure that prints. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119338|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119752&action=edit Bug 27282: Add window.onafterprint function TO TEST: -set up a new list with a few items -go to /cgi-bin/koha/virtualshelves/shelves.pl and view that list. -Click 'Print List' in Chrome. -The tab opens but immediately closes itself. -Apply patch and clear cache -Try again, the print dialouge remains open Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06 |21.05.00,20.11.06,20.05.12 released in| | CC| |victor@tuxayo.net Status|Pushed to stable |Pushed to oldstable --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- note: it was pushed to 20.05.x for 20.05.12 -- You are receiving this mail because: You are watching all bug changes.