[Bug 27232] New: Missing spaces in member-alt-contact-style.inc make some strings appearing twice in po
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Bug ID: 27232 Summary: Missing spaces in member-alt-contact-style.inc make some strings appearing twice in po Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org
From the koha-translate ML:
#. %1$s: END #: koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-contact-style.inc:162 #, c-format msgid "%s State:" msgstr "%s Provincia:" #. For the first occurrence, #. %1$s: END #: koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style.inc:177 #: koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style.inc:168 #, c-format msgid "%s State: " msgstr "%s Stato: " We need to add a space between ":" and "</label>" https://lists.koha-community.org/pipermail/koha-translate/2020-December/0028... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 114383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114383&action=edit Bug 27232: Add missing space between : and </label> in member-alt-contact-style.inc It caused the strings to appear twice in the po file Test plan: Apply this patch and regenerate the PO for a given language. Notice that the string "%s State: " only appears once in the PO file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- There is also <span class="label">Surname: </span> in moremember.tt : https://git.koha-community.org/Koha-community/Koha/src/commit/ec1979a385cb35... Creating : msgid "Surname: " So maybe better add a span in other places : <span>Surname: </span></label> It removes the %s which is not a real PO var, it must not be moved. What do you think ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes good idea, but feeling lazy to add the missing span tags. Feel free to follow-up :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114383|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119638&action=edit Bug 27232: Add missing space between : and </label> in member-alt-contact-style.inc It caused the strings to appear twice in the po file Test plan: Apply this patch and regenerate the PO for a given language. Notice that the string "%s State: " only appears once in the PO file Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119638|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119805&action=edit Bug 27232: Add missing space between : and </label> in member-alt-contact-style.inc It caused the strings to appear twice in the po file Test plan: Apply this patch and regenerate the PO for a given language. Notice that the string "%s State: " only appears once in the PO file Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.06 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06 |21.05.00,20.11.06,20.05.12 released in| | CC| |andrew@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org