[Bug 25919] New: Desks link is available in left side menu even if UseCirculationDesks is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 Bug ID: 25919 Summary: Desks link is available in left side menu even if UseCirculationDesks is disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com I noticed the 'Desks' link in the administration menu on the left side is displayed even if the UseCirculationDesks syspref is turned off. To reproduce: 1- Make sure UseCirculationDesks is set to 'Don't use' 2- Go in Administration > Libraries (or any other section of the admin module) 3- Notice the 'Desks' link in the left side menu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Actually, I just turned on the syspref and 'Desks' still does not appear on my main administration page... Maybe it's just my installation that's buggy. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 107057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107057&action=edit Bug 25919: Only show Desks in admin navigation when UseCirculationDesks is used We were missing a check for the UseCirculationDesks in the template so the "Desks" link would only appear in the admin navigation when the pref feature is activated. To test: - Turn off UseCirculationDesks - Go to any administration page that shows the navigation on the left - Verify Desks shows - Apply patch - Reload the admin page - Desks should be gone - Turn on UseCirculationDesks - Verify the Desks reappear -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107057|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 107433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107433&action=edit Bug 25919: Only show Desks in admin navigation when UseCirculationDesks is used We were missing a check for the UseCirculationDesks in the template so the "Desks" link would only appear in the admin navigation when the pref feature is activated. To test: - Turn off UseCirculationDesks - Go to any administration page that shows the navigation on the left - Verify Desks shows - Apply patch - Reload the admin page - Desks should be gone - Turn on UseCirculationDesks - Verify the Desks reappear Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107433|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 107937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107937&action=edit Bug 25919: Only show Desks in admin navigation when UseCirculationDesks is used We were missing a check for the UseCirculationDesks in the template so the "Desks" link would only appear in the admin navigation when the pref feature is activated. To test: - Turn off UseCirculationDesks - Go to any administration page that shows the navigation on the left - Verify Desks shows - Apply patch - Reload the admin page - Desks should be gone - Turn on UseCirculationDesks - Verify the Desks reappear Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Works as described. One question: even after this I can access the page and define desks if the syspref is disabled - should we block this too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.03 released in| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- UseCirculationDesks not in 19.11.x, not backported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25919 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- For the sake of the release notes, I'm marking this as a bug rather than an enhancement, as it does not add/modify any functionality. Feel free to change it back if you are opposed to it. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org