https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25747 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Don't display , when patron |Don't display a comma when |has no firstname |patron has no firstname -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25747 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 105871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105871&action=edit Bug 25747: Don't display a comma when patron has no firstname This patch adds a check for the existence of "firstname" to patron-title.inc so that if the patron has no firstname the "invert name" setting doesn't cause an unnecessary comma to appear. To test, apply the patch and locate or create a patron with no first name. - When checking out to the patron, examine the page title. It should say "Checking out to <lastname> (<cardnumber>). - When checking out to a patron with first and last name it should show as before, "Checking out to <lastname>, <firstname> (<cardnumber) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25747 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25747 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105883|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106115&action=edit Bug 25747: Don't display a comma when patron has no firstname This patch adds a check for the existence of "firstname" to patron-title.inc so that if the patron has no firstname the "invert name" setting doesn't cause an unnecessary comma to appear. To test, apply the patch and locate or create a patron with no first name. - When checking out to the patron, examine the page title. It should say "Checking out to <lastname> (<cardnumber>). - When checking out to a patron with first and last name it should show as before, "Checking out to <lastname>, <firstname> (<cardnumber) Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25747 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25747 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25555 CC| |aleisha@catalyst.net.nz --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backporting to 19.11.x Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25555 [Bug 25555] Holds Queue sorts patrons by firstname -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25747 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.