[Bug 43561] New: Local use system preferences are shown in autocomplete but not found in searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43561 Bug ID: 43561 Summary: Local use system preferences are shown in autocomplete but not found in searches Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 41995 Target Milestone: --- To reproduce: - in admin, type "OPACdid" into the system preference search - see "OPACdidyoumean" is offered as a search term - click OPACdidyoumean, get an error that no such syspref exists - click into the Local Use system preferences, see OPACdidyoumean is there Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41995 [Bug 41995] Autocomplete for syspref search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43561 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43561 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 206208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206208&action=edit Bug 43561: Redirect to local use sysprefs instead of 'not found' If a user search for a local use syspref, the name will appear in the autocomplete but when choosen "not found" will be return. This patch suggests to redirect to the "local use" syspref view if we found a local use syspref that match the search term. Test plan: - in admin, type "OPACdid" into the system preference search - see "OPACdidyoumean" is offered as a search term - click OPACdidyoumean => Without this patch you get an error that no such syspref exists => With this patch you are redirected to the local use syspref view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43561 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Hi Andrew, do you think this patch is enough? Certainly not perfect but it fixes the "not found" error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43561 --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Tested successfully. Confirmed that searching for OPACdid offers OPACdidyoumean in the autocomplete and selecting it redirects to the Local use system preferences page, where OPACdidyoumean is present. Also confirmed that normal system preference searches continue to work as expected and display the matching preference rather than redirecting to Local use. QA checks pass. Signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43561 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206208|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43561 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 206263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206263&action=edit Bug 43561: Redirect to local use sysprefs instead of 'not found' If a user search for a local use syspref, the name will appear in the autocomplete but when choosen "not found" will be return. This patch suggests to redirect to the "local use" syspref view if we found a local use syspref that match the search term. Test plan: - in admin, type "OPACdid" into the system preference search - see "OPACdidyoumean" is offered as a search term - click OPACdidyoumean => Without this patch you get an error that no such syspref exists => With this patch you are redirected to the local use syspref view Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43561 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43561 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jvinke@austinseminary.edu |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43561 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from John Vinke <jvinke@austinseminary.edu> --- Tested this for every value in the "local use" section and it worked for all with the exception of "Version" which we aren't supposed to touch anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43561 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206263|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43561 --- Comment #6 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 206754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206754&action=edit Bug 43561: Redirect to local use sysprefs instead of 'not found' If a user search for a local use syspref, the name will appear in the autocomplete but when choosen "not found" will be return. This patch suggests to redirect to the "local use" syspref view if we found a local use syspref that match the search term. Test plan: - in admin, type "OPACdid" into the system preference search - see "OPACdidyoumean" is offered as a search term - click OPACdidyoumean => Without this patch you get an error that no such syspref exists => With this patch you are redirected to the local use syspref view Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: John Vinke <jvinke@austinseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43561 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43561 --- Comment #7 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org