https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43361 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43361 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43361 --- Comment #2 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 206477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206477&action=edit Bug 43361: Prevent subscription orders from being included in invoice item counts Test plan: 1. Go to <staff_url>/cgi-bin/koha/acquisition/vendors/1. Click "New" → "Basket", name it, "Save". 2. "Add to basket" → "From a new (empty) record". Fill Title, Quantity=1, Fund, Vendor price=100, "Save". 3. Click "Close basket", confirm. 4. "My Vendor" breadcrumb → "Receive shipments" → type any "Vendor invoice" name → "Next". 5. Click "Receive" on the order row. Set Quantity received=1, check "Receive?", confirm Actual cost ≠ 0, "Confirm" → "Finish receiving". 6. "My Vendor" → "Receive shipments" again. Note the Item count and Items expeected for your invoice. 7. On that same pending-orders page, click the invoice (should lead you to /cgi-bin/koha/acqui/parcel.pl?invoiceid=1), then click the order's title link directly (under 'Summary' column). Click "New" → "New subscription", fill required fields, "Next", "Save subscription". Repeat once more on that exact record. 8. Reload "Receive shipments": Item count and Items expected for the same invoice are now doubled. 9. Apply patch and restart_all 10. Refresh the page, the invoice counts should now be correct Signed-off-by: John Vinke <jvinke@austinseminary.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43361 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43361 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207143&action=edit Bug 43361: Prevent subscription orders from being included in invoice item counts Test plan: 1. Go to <staff_url>/cgi-bin/koha/acquisition/vendors/1. Click "New" → "Basket", name it, "Save". 2. "Add to basket" → "From a new (empty) record". Fill Title, Quantity=1, Fund, Vendor price=100, "Save". 3. Click "Close basket", confirm. 4. "My Vendor" breadcrumb → "Receive shipments" → type any "Vendor invoice" name → "Next". 5. Click "Receive" on the order row. Set Quantity received=1, check "Receive?", confirm Actual cost ≠ 0, "Confirm" → "Finish receiving". 6. "My Vendor" → "Receive shipments" again. Note the Item count and Items expeected for your invoice. 7. On that same pending-orders page, click the invoice (should lead you to /cgi-bin/koha/acqui/parcel.pl?invoiceid=1), then click the order's title link directly (under 'Summary' column). Click "New" → "New subscription", fill required fields, "Next", "Save subscription". Repeat once more on that exact record. 8. Reload "Receive shipments": Item count and Items expected for the same invoice are now doubled. 9. Apply patch and restart_all 10. Refresh the page, the invoice counts should now be correct Signed-off-by: John Vinke <jvinke@austinseminary.edu> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43361 --- Comment #4 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43361 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 26.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.