https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Blocks|18928 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65239&action=edit Bug 18925 - Update Schema Files -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65238|0 |1 is obsolete| | --- Comment #4 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 67024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67024&action=edit Bug 18925 - Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65240|0 |1 is obsolete| | --- Comment #6 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 67026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67026&action=edit Bug 18925 - Remove schema files for deleted tables -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #8 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 67621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67621&action=edit Bug 18925: (follow-up) Change name of rule to fix ambiguity There was previously an ambiguity between the branch/category/itemtype specific max{,onsite}issueqty and the total-per-patron max{,onsite}issueqty. The latter has been renamed to patron_max{,onsite}issueqty. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67025|0 |1 is obsolete| | --- Comment #10 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 70993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70993&action=edit Bug 18925 - Update Schema Files -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67621|0 |1 is obsolete| | --- Comment #12 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 70995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70995&action=edit Bug 18925: (follow-up) Change name of rule to fix ambiguity There was previously an ambiguity between the branch/category/itemtype specific max{,onsite}issueqty and the total-per-patron max{,onsite}issueqty. The latter has been renamed to patron_max{,onsite}issueqty. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70992|0 |1 is obsolete| | --- Comment #14 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 71032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71032&action=edit Bug 18925 - Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71032|0 |1 is obsolete| | --- Comment #16 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 71043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71043&action=edit Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70994|0 |1 is obsolete| | --- Comment #18 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 71045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71045&action=edit Bug 18925: Remove schema files for deleted tables -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71033|0 |1 is obsolete| | --- Comment #20 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 71047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71047&action=edit Bug 18925: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71044|0 |1 is obsolete| | --- Comment #22 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72226&action=edit Bug 18925: Update schema files -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71046|0 |1 is obsolete| | --- Comment #24 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72228&action=edit Bug 18925: (follow-up) Change name of rule to fix ambiguity There was previously an ambiguity between the branch/category/itemtype specific max{,onsite}issueqty and the total-per-patron max{,onsite}issueqty. The latter has been renamed to patron_max{,onsite}issueqty. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #26 from Séverine Queune <severine.queune@bulac.fr> --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules fatal: sha1 information is lacking or useless (Koha/CirculationRules.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules The copy of the patch that failed is found in: /var/repositories/koha/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18925-Move-maxissueqty-and-maxonsiteissueqty-t-lf7fNZ.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72225|0 |1 is obsolete| | Attachment #72226|0 |1 is obsolete| | Attachment #72227|0 |1 is obsolete| | Attachment #72228|0 |1 is obsolete| | Attachment #72229|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77225&action=edit Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77227&action=edit Bug 18925: Remove schema files for deleted tables -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77229&action=edit Bug 18925: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note: C4::Circulation::GetBranchBorrowerCircRule 1640 my $rule = Koha::CirculationRules->search( should certainly be replaced by Koha::CirculationRules->get_effective_rule -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77225|0 |1 is obsolete| | Attachment #77226|0 |1 is obsolete| | Attachment #77227|0 |1 is obsolete| | Attachment #77228|0 |1 is obsolete| | Attachment #77229|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78881&action=edit Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78883&action=edit Bug 18925: Remove schema files for deleted tables -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78885&action=edit Bug 18925: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78881|0 |1 is obsolete| | Attachment #78882|0 |1 is obsolete| | Attachment #78883|0 |1 is obsolete| | Attachment #78884|0 |1 is obsolete| | Attachment #78885|0 |1 is obsolete| | Attachment #78886|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79642&action=edit Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79644&action=edit Bug 18925: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79646&action=edit Bug 18925: Update schema files -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Bug 18925 depends on bug 18887, which changed state. Bug 18887 Summary: Introduce new table 'circulation_rules', use for 'max_holds' rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81092&action=edit Bug 18925: (follow-up) Change name of rule to fix ambiguity There was previously an ambiguity between the branch/category/itemtype specific max{,onsite}issueqty and the total-per-patron max{,onsite}issueqty. The latter has been renamed to patron_max{,onsite}issueqty. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81094&action=edit Bug 18925: Replace logic in GetBranchBorrowerCircRule with get_effective_rule -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 82928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82928&action=edit Bug 18925: (follow-up) Change name of rule to fix ambiguity There was previously an ambiguity between the branch/category/itemtype specific max{,onsite}issueqty and the total-per-patron max{,onsite}issueqty. The latter has been renamed to patron_max{,onsite}issueqty. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 82930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82930&action=edit Bug 18925: Replace logic in GetBranchBorrowerCircRule with get_effective_rule -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nick@bywatersolutions.com --- Comment #56 from Nick Clemens <nick@bywatersolutions.com> --- Attempted rebase due to bug 21753 - got tests failures after that -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82927|0 |1 is obsolete| | Attachment #82928|0 |1 is obsolete| | Attachment #82929|0 |1 is obsolete| | Attachment #82930|0 |1 is obsolete| | Attachment #82931|0 |1 is obsolete| | --- Comment #57 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85480&action=edit Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85482&action=edit Bug 18925: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85484&action=edit Bug 18925: Update schema files -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #63 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85486&action=edit Bug 18925: Update new occurrences -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #65 from Tomás Cohen Arazi <tomascohen@gmail.com> --- All looks good to me. The only doubt is why aren't the maxissueqty and maxonsiteissureqty columns removed from issuingrules. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85481|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85483|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85485|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #66 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85939&action=edit Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #68 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85941&action=edit Bug 18925: (follow-up) Fix null/empty behavior Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #70 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85943&action=edit Bug 18925: Update schema files Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #72 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85945&action=edit Bug 18925: Update new occurrences Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #74 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85947&action=edit Bug 18925: (QA follow-up) Fix indentation characters in smart-rules.tt Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #76 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85948&action=edit Bug 18925: (QA follow-up) Fix basic_workflow.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #77 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85949&action=edit Bug 18925: Move existing rules -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #79 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85951&action=edit Bug 18925: Fix 'Default checkout, hold policy by patron category' block We want ->Search to return undef if the rule does not exist. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85940|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85942|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85944|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85946|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85948|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85950|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #81 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85953&action=edit Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #83 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85955&action=edit Bug 18925: (follow-up) Fix null/empty behavior Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #85 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85957&action=edit Bug 18925: Update schema files Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #87 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85959&action=edit Bug 18925: Update new occurrences Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #89 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85961&action=edit Bug 18925: (QA follow-up) Fix indentation characters in smart-rules.tt Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #91 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85963&action=edit Bug 18925: Move existing rules Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #93 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85965&action=edit Bug 18925: Fix 'Default checkout, hold policy by patron category' block We want ->Search to return undef if the rule does not exist. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85954|0 |1 is obsolete| | --- Comment #95 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86069&action=edit Bug 18925: (follow-up) Change name of rule to fix ambiguity There was previously an ambiguity between the branch/category/itemtype specific max{,onsite}issueqty and the total-per-patron max{,onsite}issueqty. The latter has been renamed to patron_max{,onsite}issueqty. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85956|0 |1 is obsolete| | --- Comment #97 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86071&action=edit Bug 18925: Replace logic in GetBranchBorrowerCircRule with get_effective_rule Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85958|0 |1 is obsolete| | --- Comment #99 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86073&action=edit Bug 18925: Fix null/empty behavior, again Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85960|0 |1 is obsolete| | --- Comment #101 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86075&action=edit Bug 18925: (QA follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85962|0 |1 is obsolete| | --- Comment #103 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86077&action=edit Bug 18925: (QA follow-up) Fix basic_workflow.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85964|0 |1 is obsolete| | --- Comment #105 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86079&action=edit Bug 18925: (follow-up) DBIC schema changes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #107 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86081&action=edit Bug 18925: (QA follow-up) Fix Circulation.t Test plan: t/db_dependent/Circulation.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #109 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Josef Moravec from comment #108)

Just a note: The patron_maxissueqty, and maxissueqty rules represents the same thing: it is number of max issues possible.

There is no setting from "Default checkout, hold policy by patron category" you can't make in the main circulation rules settings table. But as this is the same on master and as this development leads to revamp circulation rules setting UI, this could be fixed in the future. Hopefully the solution arise during developing/testing...

Reading your discussion with Joubu in IRC I think this is incorrect. Let say Branch A has rules for 'Patron' catgory: itype = BOOK, Current checkouts allowed = 5 itype = All, Current checkouts allowed = 5 This patron can checkout 5 books and 5 of anything else. If you also set "Default checkout, hold policy by patron category" for 'Patron' to 5 then the patron can only checkout 5 items total (e.g. 3 books, 2 anything else) The top section always checks the most specific rule and 'All' rules are really 'All not defined elsewhere' or 'Default' or 'Generic' - All is really a bad name when you look at it this way -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #111 from Nick Clemens <nick@bywatersolutions.com> --- QA tool complaint: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt FAIL filters missing_filter at line 12 ( [% categorycodes.push( pc.id ) %]) Is this a false positive? Or how can we filter on pushing to an array? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #113 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #115 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Tomás Cohen Arazi from comment #114)

(In reply to Nick Clemens from comment #113)

...

Awesome work all!

Pushed to master for 19.05

\o/

\o/ from me as well! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #117 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 2 new commits added to misc4dev to insert the circ rules correctly: commit 8eb9c2489ce376e719fcc0a9a1549c83207a8a20 Fix insert circ rules since bug 18925 And its followup... commit 02e6701eb923947a3939e27884c354dc4cb05401 (follow-up) Fix insert circ rules since bug 18925 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #119 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #118)

(In reply to Tomás Cohen Arazi from comment #116)

...

Created attachment 86165 [details] [review] [review] Bug 18925: (QA follow-up) Remove weird 'Null' values for integer column

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

As 0 is the default value defined at DBMS level we could have removed the lines :)

Sure, I prefered to make it explicit. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #121 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 86206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86206&action=edit Bug 18925: (RM follow-up) Remove schema files for deletedtables Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22489 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22679 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22679 [Bug 22679] circulation_rules are not deleted when accompanying issuingrules are deleted -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22759 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22759 [Bug 22759] Circulation rules for maxissueqty are applied per branch even for defaults -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Part of the ongoing effort release notes| |to improve the | |maintainability of our | |codebase. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 hannah.co@northwestu.edu changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|1 |0 CC| |hannah.co@northwestu.edu Status|RESOLVED |UNCONFIRMED Resolution|FIXED |--- --- Comment #124 from hannah.co@northwestu.edu --- After updating to 19.05 with this patch included, circulation rules treated "Unlimited" in "Current checkouts allowed" and "Current on-site checkouts allowed" as 0 (zero) instead of infinite. Attempting to checkout items with an "Unlimited" maxissueqty or maxonsiteissueqty resulted in the error "• Too many checked out. 0 checked out, only are allowed.• This patron can't check out this item per library circulation policy" Circulation was allowed again after changing "Unlimited" to a numerical value. Currently, leaving the "Current checkouts allowed"/maxissueqty and "Current on-site checkouts allowed"/maxonsiteissueqty blank defaults to "Unlimited". Should either the default value be changed, or the code changed to treat the default value as infinite again, instead of zero? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23104 --- Comment #125 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to hannah.co from comment #124)

After updating to 19.05 with this patch included, circulation rules treated "Unlimited" in "Current checkouts allowed" and "Current on-site checkouts allowed" as 0 (zero) instead of infinite. Attempting to checkout items with an "Unlimited" maxissueqty or maxonsiteissueqty resulted in the error "• Too many checked out. 0 checked out, only are allowed.• This patron can't check out this item per library circulation policy"

Circulation was allowed again after changing "Unlimited" to a numerical value.

Currently, leaving the "Current checkouts allowed"/maxissueqty and "Current on-site checkouts allowed"/maxonsiteissueqty blank defaults to "Unlimited". Should either the default value be changed, or the code changed to treat the default value as infinite again, instead of zero?

I have opened bug 23104 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23104 [Bug 23104] Regression (18925) in circ rules - unlimited vs 0 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23813 [Bug 23813] DB error on upgrade from 18.12 to 19.05.04 -- You are receiving this mail because: You are watching all bug changes.