[Bug 42147] New: Action logs for hold creation contain less data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 Bug ID: 42147 Summary: Action logs for hold creation contain less data Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com In 24.11, the "info" column in the action logs for a hold creation action contained the full hold data. As of 25.05 and onward, this is no longer the case. Holds created through the staff interface show only the reserve_id in the "info" column, and holds created by API show the API arguments, which is a bit more helpful, but still not as much data as the "info" column used to contain. This makes it harder to search for the logs of a specific hold, and in some cases harder to determine whether an unexpected hold option/status was user error on the part of whoever placed the hold, or whether that unexpected state occurred later. It would be very helpful to restore the behavior of logging the full hold object data in the "info" column. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40866 Assignee|koha-bugs@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 [Bug 40866] Corrections to override logging -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 --- Comment #1 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 195840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195840&action=edit Bug 42147: Log all relevant hold data on hold creation When logging a hold create action, include all hold fields that may be defined at hold creation. Fields that are not defined until later (such as found status, waiting date, etc) are not included to avoid clutter. To test: 1. System preference setup i. Enable HoldsLog system preference ii. Set AllowHoldPolicyOverride to Allow 2. Place a hold in the staff interface 3. View the action logs entry for that hold creation i. Go to Tools > Log viewer ii. Select Modules: Holds and Action: Create iii. Click Submit --> Note that the "info" column only shows the hold id 4. Apply patch and restart_all 5. Repeat steps 2-3 --> The "info" column should now show hold details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195840|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 --- Comment #2 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 195845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195845&action=edit Bug 42147: Log all relevant hold data on hold creation When logging a hold create action, include all hold fields that may be defined at hold creation. Fields that are not defined until later (such as found status, waiting date, etc) are not included to avoid clutter. To test: 1. System preference setup i. Enable HoldsLog system preference ii. Set AllowHoldPolicyOverride to Allow 2. Place a hold in the staff interface 3. View the action logs entry for that hold creation i. Go to Tools > Log viewer ii. Select Modules: Holds and Action: Create iii. Click Submit --> Note that the "info" column only shows the hold id 4. Apply patch and restart_all 5. Repeat steps 2-3 --> The "info" column should now show hold details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 --- Comment #3 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 195846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195846&action=edit Bug 42147: Update tests To test: prove t/db_dependent/Reserves.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Note: In testing this, I found that the hold override is not actually reflected in the logs with or without the patch (at least when overriding the holds allowed per record limit in the staff interface). Since the issue is present on main, I filed a separate bug 42153 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195845|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195846|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 --- Comment #5 from Emmanuel Bétemps <e.betemps@gmail.com> --- Created attachment 195851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195851&action=edit Bug 42147: Log all relevant hold data on hold creation When logging a hold create action, include all hold fields that may be defined at hold creation. Fields that are not defined until later (such as found status, waiting date, etc) are not included to avoid clutter. To test: 1. System preference setup i. Enable HoldsLog system preference ii. Set AllowHoldPolicyOverride to Allow 2. Place a hold in the staff interface 3. View the action logs entry for that hold creation i. Go to Tools > Log viewer ii. Select Modules: Holds and Action: Create iii. Click Submit --> Note that the "info" column only shows the hold id 4. Apply patch and restart_all 5. Repeat steps 2-3 --> The "info" column should now show hold details Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 --- Comment #6 from Emmanuel Bétemps <e.betemps@gmail.com> --- Created attachment 195852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195852&action=edit Bug 42147: Update tests To test: prove t/db_dependent/Reserves.t Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Prior to version 25.05.05, release notes| |the action logs for | |creating a hold used to | |show the full hold data in | |the "info" column, but | |starting in 25.05.05 the | |"info" column only shows | |the hold id, and other hold | |information is not logged | |when the hold is created. | |This restores other hold | |values to the hold creation | |action logs, so that | |libraries can easily look | |up the starting priority | |and options that were | |selected when the hold was | |first placed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195851|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195852|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196214&action=edit Bug 42147: Log all relevant hold data on hold creation When logging a hold create action, include all hold fields that may be defined at hold creation. Fields that are not defined until later (such as found status, waiting date, etc) are not included to avoid clutter. To test: 1. System preference setup i. Enable HoldsLog system preference ii. Set AllowHoldPolicyOverride to Allow 2. Place a hold in the staff interface 3. View the action logs entry for that hold creation i. Go to Tools > Log viewer ii. Select Modules: Holds and Action: Create iii. Click Submit --> Note that the "info" column only shows the hold id 4. Apply patch and restart_all 5. Repeat steps 2-3 --> The "info" column should now show hold details Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196215&action=edit Bug 42147: Update tests To test: prove t/db_dependent/Reserves.t Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42147 --- Comment #10 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org