[Bug 42149] New: The main navigation needs an aria-label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42149 Bug ID: 42149 Summary: The main navigation needs an aria-label Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: blawlor@clamsnet.org QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org When there are more than one <nav> elements on a page, it is best practice for each to have a unique aria-label to help screen readers be able to jump between the landmarks. The Breadcrumb nav is labeled, but the main nav is not. If the user pulls up a list of landmarks to navigate the page, they have to assume that the first nav is the main one. While technically using the nav element without the aria-label passes the minimum requirements for WCAG 4.1.2 (Name, Role, Value), it fails WCAG 2.4.1 (Bypass Blocks) because the user has to do extra work to know how to get to the main nav. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42149 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |blawlor@clamsnet.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42149 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42149 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 195710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195710&action=edit Bug 42149: Add aria-label to main nav The main <nav> should have a unique aria-label to differentiate it from the Breadcrumb nav To test: 1. View page source and confirm there are two <nav> elements 2. Notice the main <nav> does not have a unique aria-label 3. Apply patch and check again 4. Confirm the main <nav> is labeled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42149 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42149 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195710|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42149 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 195711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195711&action=edit Bug 42149: Add aria-label to main nav The main <nav> should have a unique aria-label to differentiate it from the Breadcrumb nav To test: 1. View page source and confirm there are two <nav> elements 2. Notice the main <nav> does not have a unique aria-label 3. Apply patch and check again 4. Confirm the main <nav> is labeled Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42149 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- There is also a third <nav> element on the staff interface home page: <nav id="shortcut" class="shortcut"> Not sure if this needs an aria label or not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42149 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42149 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195711|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42149 --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 196048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196048&action=edit Bug 42149: Add aria-label to main nav The main <nav> should have a unique aria-label to differentiate it from the Breadcrumb nav To test: 1. View page source and confirm there are two <nav> elements 2. Notice the main <nav> does not have a unique aria-label 3. Apply patch and check again 4. Confirm the main <nav> is labeled Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42149 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 196049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196049&action=edit Bug 42149: (QA follow-up) Add aria-label to shortcut nav - Add aria-label="Quick shortcuts" to the shortcut nav element in both the TT include and the Vue Help component - Ensures all nav landmarks on the staff interface are uniquely labeled for screen readers (WCAG 2.4.1) To test: - Apply the patch - Rebuild vue components with `yarn js:build` - Open the staff interface home page - View the page source and confirm the shortcut nav has aria-label="Quick shortcuts" - Confirm that all three nav elements (Main, Breadcrumb, Quick shortcuts) have unique aria-labels Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42149 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |me@paulderscheid.xyz |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42149 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42149 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42149 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42149 --- Comment #7 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org