[Bug 40892] New: ILL tab with no requests shows all instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40892 Bug ID: 40892 Summary: ILL tab with no requests shows all instead Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: ephetteplace@cca.edu QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com, pedro.amorim@openfifth.co.uk, tomascohen@gmail.com With the ILLRequestsTabs feature, if you create a tab for a status which has no matching ILL requests, that tab displays _all_ requests instead of none. We have a tab "new" tab (see below) that exhibits this behavior whenever there are no status=NEW requests. Here's a rough way to recreate this on a new system: - Enable ILLModule setting - Create a few ILL requests - Edit ILLRequestsTabs setting to have two tabs ``` - name: New status: - NEW - name: Completed status: - COMP ``` - Go to the requests module on the staff side - Select the "Completed" tab - There should be 0 requests; instead you see all of them -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40892 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30200 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30200 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 [Bug 30200] Add customizable tabs to interlibrary loan requests list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40892 --- Comment #1 from Lisette Scheer <lisette@bywatersolutions.com> ---
From a little testing it seems to work as long as all of the listed statuses have at least one item.
Example from INNReach today: - name: Lending status: - O_ITEM_CHECKED_IN - name: Borrowing status: - B_ITEM_REQUESTED If there's nothing currently in B_ITEM_REQUESTED the tabs don't work at all. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40892 Hans Pålsson <hans.palsson@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hans.palsson@hkr.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40892 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40892 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40892 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41854 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40892 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk --- Comment #2 from Aude Charillon <aude.charillon@openfifth.co.uk> --- I see the same issue as Eric on 25.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40892 Inkeri Hakulinen <inkeri.hakulinen+bugz@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |inkeri.hakulinen+bugz@helsi | |nki.fi --- Comment #3 from Inkeri Hakulinen <inkeri.hakulinen+bugz@helsinki.fi> --- Same here, using 25.11.03 in our test environment. The tabs that don't have ILL requests matching status(es) defined for that tab, should be empty. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40892 Bug 40892 depends on bug 30200, which changed state. Bug 30200 Summary: Add customizable tabs to interlibrary loan requests list https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40892 Irene Tortorella <i.tortorella@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i.tortorella@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40892 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi --- Comment #4 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- As Eric stated in bug 30200 (comment 50), keeping multi-select in sync with tab filtering broke the tab filtering if there are no items with a that status we want to filter with. Reverting multi-select sync fixes the problem but without it using status filtering combined with tab filtering will lead to some faulty behaviour. I think we should add all statuses to the status filter list, not just the ones found from existing ill requests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org