[Bug 30200] New: Add customizable tabs to interlibrary loan requests list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Bug ID: 30200 Summary: Add customizable tabs to interlibrary loan requests list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: lari.taskula@hypernova.fi In staff client, all interlibrary loan requests are loaded into a table regardless of their status. Ability to sort them by status under multiple tabs would make librarians life a lot easier. This Bug adds such feature. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 131305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131305&action=edit Bug 30200: Add a new system preference ILLRequestsTabs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #2 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 131306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131306&action=edit Bug 30200: Add custom tabs to View ILL requests page Prereqs: 1: Make sure you have enabled an ILL backend and enabled system preferecnce ILLModule. For more information see https://koha-community.org/manual/21.11/en/html/ILL_requests.html To test: 1: Note, the following branchcodes, statuses and backends depend on your test environment and which ILL backend you are using. This example is for Libris backend. Set system preference ILLRequestsTabs: - name: tab1 status: - IN_REM - name: tab2 status: - IN_UTEL - IN_LEV - name: tab3 status: - IN_ANK 2. Add at least 4 ILL requests with the following SQL: INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_REM', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_UTEL', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_LEV', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_ANK', 'Libris'); Note: Change values to whatever your test environment has set up. 3. Go to cgi-bin/koha/ill/ill-requests.pl 4. After the page loads, you should now see 4 different tabs: "All", "tab1", "tab2" and "tab3" 5. Confirm all ILL requests are present under "All" tab 6. Confirm only ILL requests with the statuses you defined in system preference ILLRequestsTabs are under tabs 1, 2 and 3 7. Go to cgi-bin/koha/members/ill-requests.pl?borrowernumber=1 8. Repeat steps 4-6 9. Clear system preference ILLRequestsTabs 10. Observe both ill/ill-requests.pl and members/ill-requests.pl now have only one tab "All" under which correct ILL requests are presented 11. Try some other status values in ILLRequestsTabs and observe expected behavior -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #3 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 131307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131307&action=edit Bug 30200: Update ill-list-table.js indentation To test: 1. git diff -w --word-diff-regex=[^[:space:]] HEAD~1 2. Observe no differences (above cmd ignores space changes) 3. Therefore patch only includes whitespace changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lari.taskula@hypernova.fi |ity.org | CC| |magnus@libriotech.no -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131306|0 |1 is obsolete| | Attachment #131307|0 |1 is obsolete| | --- Comment #4 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 131959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131959&action=edit Bug 30200: Add custom tabs to View ILL requests page Prereqs: 1: Make sure you have enabled an ILL backend and enabled system preferecnce ILLModule. For more information see https://koha-community.org/manual/21.11/en/html/ILL_requests.html To test: 1: Note, the following branchcodes, statuses and backends depend on your test environment and which ILL backend you are using. This example is for Libris backend. Set system preference ILLRequestsTabs: - name: tab1 status: - IN_REM - name: tab2 status: - IN_UTEL - IN_LEV - name: tab3 status: - IN_ANK 2. Add at least 4 ILL requests with the following SQL: INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_REM', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_UTEL', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_LEV', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_ANK', 'Libris'); Note: Change values to whatever your test environment has set up. 3. Go to cgi-bin/koha/ill/ill-requests.pl 4. After the page loads, you should now see 4 different tabs: "All", "tab1", "tab2" and "tab3" 5. Confirm all ILL requests are present under "All" tab 6. Confirm only ILL requests with the statuses you defined in system preference ILLRequestsTabs are under tabs 1, 2 and 3 7. Go to cgi-bin/koha/members/ill-requests.pl?borrowernumber=1 8. Repeat steps 4-6 9. Clear system preference ILLRequestsTabs 10. Observe both ill/ill-requests.pl and members/ill-requests.pl now have only one tab "All" under which correct ILL requests are presented 11. Try some other status values in ILLRequestsTabs and observe expected behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131959|0 |1 is obsolete| | --- Comment #5 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 131960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131960&action=edit Bug 30200: Add custom tabs to View ILL requests page Prereqs: 1: Make sure you have enabled an ILL backend and enabled system preferecnce ILLModule. For more information see https://koha-community.org/manual/21.11/en/html/ILL_requests.html To test: 1: Note, the following branchcodes, statuses and backends depend on your test environment and which ILL backend you are using. This example is for Libris backend. Set system preference ILLRequestsTabs: - name: tab1 status: - IN_REM - name: tab2 status: - IN_UTEL - IN_LEV - name: tab3 status: - IN_ANK 2. Add at least 4 ILL requests with the following SQL: INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_REM', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_UTEL', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_LEV', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_ANK', 'Libris'); Note: Change values to whatever your test environment has set up. 3. Go to cgi-bin/koha/ill/ill-requests.pl 4. After the page loads, you should now see 4 different tabs: "All", "tab1", "tab2" and "tab3" 5. Confirm all ILL requests are present under "All" tab 6. Confirm only ILL requests with the statuses you defined in system preference ILLRequestsTabs are under tabs 1, 2 and 3 7. Go to cgi-bin/koha/members/ill-requests.pl?borrowernumber=1 8. Repeat steps 4-6 9. Clear system preference ILLRequestsTabs 10. Observe both ill/ill-requests.pl and members/ill-requests.pl now have only one tab "All" under which correct ILL requests are presented 11. Try some other status values in ILLRequestsTabs and observe expected behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131960|0 |1 is obsolete| | --- Comment #6 from Magnus Enger <magnus@libriotech.no> --- Created attachment 134466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134466&action=edit Bug 30200: Add custom tabs to View ILL requests page Prereqs: 1: Make sure you have enabled an ILL backend and enabled system preferecnce ILLModule. For more information see https://koha-community.org/manual/21.11/en/html/ILL_requests.html To test: 1: Note, the following branchcodes, statuses and backends depend on your test environment and which ILL backend you are using. This example is for Libris backend. Set system preference ILLRequestsTabs: - name: tab1 status: - IN_REM - name: tab2 status: - IN_UTEL - IN_LEV - name: tab3 status: - IN_ANK 2. Add at least 4 ILL requests with the following SQL: INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_REM', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_UTEL', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_LEV', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_ANK', 'Libris'); Note: Change values to whatever your test environment has set up. 3. Go to cgi-bin/koha/ill/ill-requests.pl 4. After the page loads, you should now see 4 different tabs: "All", "tab1", "tab2" and "tab3" 5. Confirm all ILL requests are present under "All" tab 6. Confirm only ILL requests with the statuses you defined in system preference ILLRequestsTabs are under tabs 1, 2 and 3 7. Go to cgi-bin/koha/members/ill-requests.pl?borrowernumber=1 8. Repeat steps 4-6 9. Clear system preference ILLRequestsTabs 10. Observe both ill/ill-requests.pl and members/ill-requests.pl now have only one tab "All" under which correct ILL requests are presented 11. Try some other status values in ILLRequestsTabs and observe expected behavior Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131305|0 |1 is obsolete| | --- Comment #7 from Magnus Enger <magnus@libriotech.no> --- Created attachment 134467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134467&action=edit Bug 30200: Add a new system preference ILLRequestsTabs Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #8 from Magnus Enger <magnus@libriotech.no> --- I have tested this and as far as I can see it works nicely. I have been involved in the developing and testing this (not an independent tester), so I am not changing the status of the bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134466|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138863&action=edit Bug 30200: Add custom tabs to View ILL requests page Prereqs: 1: Make sure you have enabled an ILL backend and enabled system preferecnce ILLModule. For more information see https://koha-community.org/manual/21.11/en/html/ILL_requests.html To test: 1: Note, the following branchcodes, statuses and backends depend on your test environment and which ILL backend you are using. This example is for Libris backend. Set system preference ILLRequestsTabs: - name: tab1 status: - IN_REM - name: tab2 status: - IN_UTEL - IN_LEV - name: tab3 status: - IN_ANK 2. Add at least 4 ILL requests with the following SQL: INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_REM', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_UTEL', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_LEV', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_ANK', 'Libris'); Note: Change values to whatever your test environment has set up. 3. Go to cgi-bin/koha/ill/ill-requests.pl 4. After the page loads, you should now see 4 different tabs: "All", "tab1", "tab2" and "tab3" 5. Confirm all ILL requests are present under "All" tab 6. Confirm only ILL requests with the statuses you defined in system preference ILLRequestsTabs are under tabs 1, 2 and 3 7. Go to cgi-bin/koha/members/ill-requests.pl?borrowernumber=1 8. Repeat steps 4-6 9. Clear system preference ILLRequestsTabs 10. Observe both ill/ill-requests.pl and members/ill-requests.pl now have only one tab "All" under which correct ILL requests are presented 11. Try some other status values in ILLRequestsTabs and observe expected behavior Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134467|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138864&action=edit Bug 30200: Add a new system preference ILLRequestsTabs Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138865&action=edit Bug 30200: (follow-up) Fix missing TT filters Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138866&action=edit Bug 30200: (follow-up) Update database update and pref description * Rephrases the system preference description a bit * Adds IGNORE to the database statement * Update output message of database statement to include pref name Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Love this - an easy way to organize custom status and all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138863|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141338&action=edit Bug 30200: Add custom tabs to View ILL requests page Prereqs: 1: Make sure you have enabled an ILL backend and enabled system preferecnce ILLModule. For more information see https://koha-community.org/manual/21.11/en/html/ILL_requests.html To test: 1: Note, the following branchcodes, statuses and backends depend on your test environment and which ILL backend you are using. This example is for Libris backend. Set system preference ILLRequestsTabs: - name: tab1 status: - IN_REM - name: tab2 status: - IN_UTEL - IN_LEV - name: tab3 status: - IN_ANK 2. Add at least 4 ILL requests with the following SQL: INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_REM', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_UTEL', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_LEV', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_ANK', 'Libris'); Note: Change values to whatever your test environment has set up. 3. Go to cgi-bin/koha/ill/ill-requests.pl 4. After the page loads, you should now see 4 different tabs: "All", "tab1", "tab2" and "tab3" 5. Confirm all ILL requests are present under "All" tab 6. Confirm only ILL requests with the statuses you defined in system preference ILLRequestsTabs are under tabs 1, 2 and 3 7. Go to cgi-bin/koha/members/ill-requests.pl?borrowernumber=1 8. Repeat steps 4-6 9. Clear system preference ILLRequestsTabs 10. Observe both ill/ill-requests.pl and members/ill-requests.pl now have only one tab "All" under which correct ILL requests are presented 11. Try some other status values in ILLRequestsTabs and observe expected behavior Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138864|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141339&action=edit Bug 30200: Add a new system preference ILLRequestsTabs Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138865|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141340&action=edit Bug 30200: (follow-up) Fix missing TT filters Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138866|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141341&action=edit Bug 30200: (follow-up) Update database update and pref description * Rephrases the system preference description a bit * Adds IGNORE to the database statement * Update output message of database statement to include pref name Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize@ptfs-europe | |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great improvement, all works well and not obvious regressions. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- I'm trying to get this to work so I can provide a follow-up to switch out the jQueryUI tabs with Bootstrap. I'm not sure if I'm doing something wrong, but it isn't working for me. Whichever tab I'm on I see all requests. The value in ILLRequestsTabs: - name: New status: - NEW - name: Status1 status: - ILL_STATUS_1 - name: Status2 status: - ILL_STATUS_2 - name: Status3-4 status: - ILL_STATUS_3 - ILL_STATUS_4 I inserted the ILL statues into the ILLSTATUS authorized value category. I manually updated some ILL requests to have the new statuses. When I go to the ILL requests page I see the tabs, but the tabs don't work to filter anything. The "All" and "NEW" tabs show all requests, and the Status1, Status2, Status3-4 tabs don't show anything. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> ---
2. Add at least 4 ILL requests with the following SQL: INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_REM', 'Libris');
Another thing to note: If I manually update an ILL request with a custom status, the ILL requests table breaks completely: "Uncaught TypeError: can't access property "name", row.capabilities[row.status] is undefined" This problem happens in master too, but I mention it because it affects the usefulness of the test plan here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It definitely worked for me when I tested, both on the illrequests summary page and on the illrequest history. I'll try to have another look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Jonathan Field <jonathan.field@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Hans Pålsson <hans.palsson@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hans.palsson@hkr.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141338|0 |1 is obsolete| | --- Comment #22 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 179356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179356&action=edit Bug 30200: Add custom tabs to View ILL requests page Prereqs: 1: Make sure you have enabled an ILL backend and enabled system preferecnce ILLModule. For more information see https://koha-community.org/manual/21.11/en/html/ILL_requests.html To test: 1: Note, the following branchcodes, statuses and backends depend on your test environment and which ILL backend you are using. This example is for Libris backend. Set system preference ILLRequestsTabs: - name: tab1 status: - IN_REM - name: tab2 status: - IN_UTEL - IN_LEV - name: tab3 status: - IN_ANK 2. Add at least 4 ILL requests with the following SQL: INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_REM', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_UTEL', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_LEV', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_ANK', 'Libris'); Note: Change values to whatever your test environment has set up. 3. Go to cgi-bin/koha/ill/ill-requests.pl 4. After the page loads, you should now see 4 different tabs: "All", "tab1", "tab2" and "tab3" 5. Confirm all ILL requests are present under "All" tab 6. Confirm only ILL requests with the statuses you defined in system preference ILLRequestsTabs are under tabs 1, 2 and 3 7. Clear system preference ILLRequestsTabs 8. Observe only one tab "All" under which correct ILL requests are presented 9. Try some other status values in ILLRequestsTabs and observe expected behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141339|0 |1 is obsolete| | --- Comment #23 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 179357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179357&action=edit Bug 30200: Add a new system preference ILLRequestsTabs Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141341|0 |1 is obsolete| | --- Comment #24 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 179358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179358&action=edit Bug 30200: (follow-up) Update database update and pref description * Rephrases the system preference description a bit * Adds IGNORE to the database statement * Update output message of database statement to include pref name Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #25 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 179359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179359&action=edit Bug 30200: Add pref to right file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141340|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #26 from Lari Taskula <lari.taskula@hypernova.fi> --- Refactored tabs to use ILL status filter. I've changed the status filter to multiple select element. I removed sign-offs from the first patch as it has changed quite a bit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179357|0 |1 is obsolete| | --- Comment #27 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 179436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179436&action=edit Bug 30200: Add a new system preference ILLRequestsTabs Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179356|0 |1 is obsolete| | --- Comment #28 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 179437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179437&action=edit Bug 30200: Add custom tabs to View ILL requests page To test: 0: yarn css:build:prod 1. Set system preference ILLRequestsTabs: - name: New status: - NEW - name: Requested or reverted status: - REQ - REQREV - name: Queued status: - QUEUED - name: Empty status: - NONEXISTENT 2. Add some ILL requests with the following SQL: INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'NEW', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'NEW', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'REQ', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'REQREV', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'QUEUED', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'KILL', 'Standard'); 3. Go to cgi-bin/koha/ill/ill-requests.pl 4. After the page loads, you should now see 4 different tabs: "All", "New", "REQs", "Queued", and "Empty" 5. Confirm all ILL requests are present under "All" tab 6. Confirm only ILL requests with the statuses you defined in system preference ILLRequestsTabs are under tabs "New", "Requested or reverted" and "Queued" 7. Confirm no ILL requests are under tab Empty 8. Clear system preference ILLRequestsTabs 9. Observe only one tab "All" under which correct ILL requests are presented 10. Try some other status values in ILLRequestsTabs and observe expected behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179358|0 |1 is obsolete| | --- Comment #29 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 179438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179438&action=edit Bug 30200: (follow-up) Update database update and pref description * Rephrases the system preference description a bit * Adds IGNORE to the database statement * Update output message of database statement to include pref name Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179359|0 |1 is obsolete| | --- Comment #30 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 179439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179439&action=edit Bug 30200: Add pref to right file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179437|0 |1 is obsolete| | --- Comment #31 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 179442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179442&action=edit Bug 30200: Add custom tabs to View ILL requests page To test: 0: yarn css:build:prod 1. Set system preference ILLRequestsTabs: - name: New status: - NEW - name: Requested or reverted status: - REQ - REQREV - name: Queued status: - QUEUED - name: Empty status: - NONEXISTENT 2. Add some ILL requests with the following SQL: INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'NEW', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'NEW', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'REQ', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'REQREV', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'QUEUED', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'KILL', 'Standard'); 3. Go to cgi-bin/koha/ill/ill-requests.pl 4. After the page loads, you should now see 5 different tabs: "All", "New", "Requested or reverted", "Queued", and "Empty" 5. Confirm all ILL requests are present under "All" tab 6. Confirm only ILL requests with the statuses you defined in system preference ILLRequestsTabs are under tabs "New", "Requested or reverted" and "Queued" 7. Confirm no ILL requests are under tab "Empty" 8. Clear system preference ILLRequestsTabs 9. Observe only one tab "All" under which correct ILL requests are presented 10. Try some other status values in ILLRequestsTabs and observe expected behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179438|0 |1 is obsolete| | --- Comment #32 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 179443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179443&action=edit Bug 30200: (follow-up) Update database update and pref description * Rephrases the system preference description a bit * Adds IGNORE to the database statement * Update output message of database statement to include pref name Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179439|0 |1 is obsolete| | --- Comment #33 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 179444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179444&action=edit Bug 30200: Add pref to right file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179436|0 |1 is obsolete| | --- Comment #34 from Magnus Enger <magnus@libriotech.no> --- Created attachment 179910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179910&action=edit Bug 30200: Add a new system preference ILLRequestsTabs Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179442|0 |1 is obsolete| | --- Comment #35 from Magnus Enger <magnus@libriotech.no> --- Created attachment 179911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179911&action=edit Bug 30200: Add custom tabs to View ILL requests page To test: 0: yarn css:build:prod 1. Set system preference ILLRequestsTabs: - name: New status: - NEW - name: Requested or reverted status: - REQ - REQREV - name: Queued status: - QUEUED - name: Empty status: - NONEXISTENT 2. Add some ILL requests with the following SQL: INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'NEW', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'NEW', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'REQ', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'REQREV', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'QUEUED', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'KILL', 'Standard'); 3. Go to cgi-bin/koha/ill/ill-requests.pl 4. After the page loads, you should now see 4 different tabs: "All", "New", "Requested or reverted", "Queued", and "Empty" 5. Confirm all ILL requests are present under "All" tab 6. Confirm only ILL requests with the statuses you defined in system preference ILLRequestsTabs are under tabs "New", "Requested or reverted" and "Queued" 7. Confirm no ILL requests are under tab "Empty" 8. Clear system preference ILLRequestsTabs 9. Observe only one tab "All" under which correct ILL requests are presented 10. Try some other status values in ILLRequestsTabs and observe expected behavior Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179443|0 |1 is obsolete| | --- Comment #36 from Magnus Enger <magnus@libriotech.no> --- Created attachment 179912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179912&action=edit Bug 30200: (follow-up) Update database update and pref description * Rephrases the system preference description a bit * Adds IGNORE to the database statement * Update output message of database statement to include pref name Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179444|0 |1 is obsolete| | --- Comment #37 from Magnus Enger <magnus@libriotech.no> --- Created attachment 179913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179913&action=edit Bug 30200: Add pref to right file Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #38 from Magnus Enger <magnus@libriotech.no> --- I work for the company that paid for this work. I can confirm it works the way we want it to, so I have added my signoff to the patches. I leave the status at "Needs signoff", because an independent signoff is needed, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Jeremy Evans <jeremy.evans@ukhsa.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.evans@ukhsa.gov.uk Status|Needs Signoff |Signed Off --- Comment #39 from Jeremy Evans <jeremy.evans@ukhsa.gov.uk> --- I have tested this on a Sandbox and can confirm it is working as described. I had to create the test ILL records manually but I was able to edit the config to confirm that different request statuses would appear under the various tabs as specified in the config. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Oh, my apoologies, I'd missed that this had been reworked for the API datatables work.. Thank you so much Lari I'll QA it now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #41 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I love this.. but I think we need a tiny bit more.. I think the selected tab should filter down the available 'status' filters on the left side menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179910|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182025&action=edit Bug 30200: Add a new system preference ILLRequestsTabs Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179911|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182026&action=edit Bug 30200: Add custom tabs to View ILL requests page To test: 0: yarn css:build:prod 1. Set system preference ILLRequestsTabs: - name: New status: - NEW - name: Requested or reverted status: - REQ - REQREV - name: Queued status: - QUEUED - name: Empty status: - NONEXISTENT 2. Add some ILL requests with the following SQL: INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'NEW', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'NEW', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'REQ', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'REQREV', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'QUEUED', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'KILL', 'Standard'); 3. Go to cgi-bin/koha/ill/ill-requests.pl 4. After the page loads, you should now see 4 different tabs: "All", "New", "Requested or reverted", "Queued", and "Empty" 5. Confirm all ILL requests are present under "All" tab 6. Confirm only ILL requests with the statuses you defined in system preference ILLRequestsTabs are under tabs "New", "Requested or reverted" and "Queued" 7. Confirm no ILL requests are under tab "Empty" 8. Clear system preference ILLRequestsTabs 9. Observe only one tab "All" under which correct ILL requests are presented 10. Try some other status values in ILLRequestsTabs and observe expected behavior Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179912|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182027&action=edit Bug 30200: (follow-up) Update database update and pref description * Rephrases the system preference description a bit * Adds IGNORE to the database statement * Update output message of database statement to include pref name Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179913|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182028&action=edit Bug 30200: Add pref to right file Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #46 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182029&action=edit Bug 30200: (QA follow-up) Keep multiselect in sync This patch updates the multiselect status picker handling to ensure it remains in sync with the active tab. On tab change we now disable statuses that are not part of the tab select options, deselect any other status filters and then select all tab statuses. We allow further refinement of the filters still by allowing the user to deselect any of the available statuses. The filters should continue to work as before except using the 'Clear' button will now reapply the tab defined status set in full as apposed to removing all status filtering entirely. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like the multi-select for the statuses, but it seems almost like a second feature hidden inside this patch set. Please make it stand out in release notes at least :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds release notes| |system preference | |`ILLRequestsTabs`. The | |preference can be | |configured to show tabs | |that can optionally group | |multiple statuses together | |in the ILL requests table. | |Additionally, multiple | |statuses can be filtered on | |when filtering the ill | |request table. | |Tab format | |exampe: | |- name: New | | | |status: | | - NEW | |- name: | |Requested or reverted | | | |status: | | - REQ | | - | |REQREV | |- name: Queued | | | |status: | | - QUEUED | |- | |name: Empty | | status: | | - | |NONEXISTENT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #49 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu --- Comment #50 from Eric Phetteplace <ephetteplace@cca.edu> --- I think keeping multi-select in sync may have broken this feature when there is a tab with no matching requests. For instance, if I follow the test plan now on 25.05.03, the "EMPTY" category displays _all_ requests, not none. I noticed this because we have no NEW requests but our "new" tab shows all requests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40892 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40892 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40892 [Bug 40892] ILL tab with no requests shows all instead -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #51 from Magnus Enger <magnus@libriotech.no> --- (In reply to Eric Phetteplace from comment #50)
I think keeping multi-select in sync may have broken this feature when there is a tab with no matching requests. For instance, if I follow the test plan now on 25.05.03, the "EMPTY" category displays _all_ requests, not none. I noticed this because we have no NEW requests but our "new" tab shows all requests.
Yikes! Could you report it as a new bug, please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #52 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Magnus Enger from comment #51)
(In reply to Eric Phetteplace from comment #50)
I think keeping multi-select in sync may have broken this feature when there is a tab with no matching requests. For instance, if I follow the test plan now on 25.05.03, the "EMPTY" category displays _all_ requests, not none. I noticed this because we have no NEW requests but our "new" tab shows all requests.
Yikes! Could you report it as a new bug, please? Bug 40892 covers this
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41854 [Bug 41854] Could ILLRequestsTabs take authorized values from ILL_STATUS_ALIAS-settings into account? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #53 from Jonathan Druart <jonathan.druart@gmail.com> --- There is a JS error in the console that seems the be caused by this patchset. /cgi-bin/koha/members/ill-requests.pl?borrowernumber=5 Uncaught TypeError: $(...).multipleSelect is not a function addStatusOptions http://dev-intra.localhost/intranet-tmpl/prog/js/ill-list-table_25.1200040.j... populateStatusFilter http://dev-intra.localhost/intranet-tmpl/prog/js/ill-list-table_25.1200040.j... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Aude Charillon contact| | CC| |aude.charillon@openfifth.co | |.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42244 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42244 [Bug 42244] Fix JS TypeError on patrons ILL table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #54 from Eric Phetteplace <ephetteplace@cca.edu> --- I created bug 42244 and a patch to fix that JS error. I see it on our instance, too, when you view ILL history from the patron account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1199 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #55 from Aude Charillon <aude.charillon@openfifth.co.uk> --- New system preference added to the Koha Manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42850 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42850 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 [Bug 42850] ILL requests stylesheet is not installed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42939 [Bug 42939] Using ILL requests backend filter breaks status filter -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org