http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22198|0 |1 is obsolete| | --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 22252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22252&action=edit Bug 11097 - Hide duplicate patron button if logged in user lacks CAN_user_borrowers permission The "duplicate" button on the circ/patron toolbar should not appear if the logged in user lacks permission to edit patron records. This patch wraps the button in the required logic. To test, open a patron record in circulation or patrons and view as a staff client user who both has and doesn't have CAN_user_borrowers permission. The button should be shown and not shown accordingly. Signed-off-by: David Cook <dcook@prosentient.com.au> I was only able to open a patron record in circulation, but it works as described. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097 Ed Veal <ed.veal@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22252|0 |1 is obsolete| | --- Comment #3 from Ed Veal <ed.veal@bywatersolutions.com> --- Created attachment 22254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22254&action=edit [SIGN-OFF]Bug 11097 - Hide duplicate patron button if logged in user lacks CAN_user_borrowers permission The "duplicate" button on the circ/patron toolbar should not appear if the logged in user lacks permission to edit patron records. This patch wraps the button in the required logic. To test, open a patron record in circulation or patrons and view as a staff client user who both has and doesn't have CAN_user_borrowers permission. The button should be shown and not shown accordingly. Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097 Ed Veal <ed.veal@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22254|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22261&action=edit Bug 11097 - Hide duplicate patron button if logged in user lacks CAN_user_borrowers permission The "duplicate" button on the circ/patron toolbar should not appear if the logged in user lacks permission to edit patron records. This patch wraps the button in the required logic. To test, open a patron record in circulation or patrons and view as a staff client user who both has and doesn't have CAN_user_borrowers permission. The button should be shown and not shown accordingly. Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.