[Bug 10889] New: wrong description for a column of biblio table in kohastructure.sql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889 Bug ID: 10889 Summary: wrong description for a column of biblio table in kohastructure.sql Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Database Assignee: gmcharlt@gmail.com Reporter: mathieu.saby@univ-rennes2.fr QA Contact: testopia@bugs.koha-community.org I don't know if it deserved to be reported. Maybe, if the description is used to generate tables in schemaspy. For biblio table in kohastructure.sql, we have : `serial` tinyint(1) default NULL, -- foreign key, linking to the subscriptionid in the serial table But serial field is not linking to the subscriptionid in the serial table. It contains 1 if the record is a serial. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think that's only the case for UNIMARC currently, so maybe worth noting that too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, maybe that's not entirely true - I have 2 records marked with 1 in my database - but I am not sure when and how that is set? And I have way more serials and subscriptions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889 --- Comment #3 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- What do you mean? In Marc21 Koha, this field is used as a foreign key?? That's not the case at all in Rennes 2 (value = 1 / 0 / null) This should not be MARCflavordependant, so it deserves an other bug if Serials are not managed in Unimarc as in Marc21! Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889 --- Comment #4 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Oh, but it cannot be : The type Tinyint(1) cannot store a foreign key ;-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- nope, it's never a key, sorry for causing confusion. I just think that only UNIMARC really makes use of that field so far :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889 --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 22083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22083&action=edit Bug 10889: fix comment describing biblioitems.serial biblioitems.serial is not a foreign key; it's a Boolean indicating whether the biblio record is a serial, which in turn influences how serial items are displayed. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22083|0 |1 is obsolete| | --- Comment #7 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 22109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22109&action=edit Bug 10889: fix comment describing biblioitems.serial biblioitems.serial is not a foreign key; it's a Boolean indicating whether the biblio record is a serial, which in turn influences how serial items are displayed. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Joy Nelson <joy@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22109|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22312&action=edit Bug 10889: fix comment describing biblioitems.serial biblioitems.serial is not a foreign key; it's a Boolean indicating whether the biblio record is a serial, which in turn influences how serial items are displayed. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Joy Nelson <joy@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org