[Bug 12058] New: OverDrive search results page doesn't show cart, lists, or login links
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 Bug ID: 12058 Summary: OverDrive search results page doesn't show cart, lists, or login links Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/opac-overdrive-search.pl?q=X OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The template for the OverDrive search results page in the OPAC lacks "[% USE Koha %]," so all preference checks (e.g. "[% IF ( Koha.Preference( 'opacbookbag' ) == 1 ) %]") fail. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- More specifically, in the Bootstrap theme. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 26922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26922&action=edit Bug 12058 - OverDrive search results page doesn't show cart, lists, or login links The template for OverDrive search results in the Bootstrap OPAC doesn't show the cart, lists, or login links because the template's checks of related system preferences relies on [% USE Koha %], which is not present. This patch adds it. To test, enable the bootstrap theme and OverDrive integration (OverDriveClientKey, etc.). Perform a search in the OPAC and click to view results from your OverDrive library. Confirm that cart, lists, and login links appear in the header. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26922|0 |1 is obsolete| | --- Comment #3 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 27153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27153&action=edit Bug 12058 - OverDrive search results page doesn't show cart, lists, or login links The template for OverDrive search results in the Bootstrap OPAC doesn't show the cart, lists, or login links because the template's checks of related system preferences relies on [% USE Koha %], which is not present. This patch adds it. To test, enable the bootstrap theme and OverDrive integration (OverDriveClientKey, etc.). Perform a search in the OPAC and click to view results from your OverDrive library. Confirm that cart, lists, and login links appear in the header. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Bug confirmed, and this patch fixes it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27153|0 |1 is obsolete| | --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 27228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27228&action=edit Bug 12058 - OverDrive search results page doesn't show cart, lists, or login links The template for OverDrive search results in the Bootstrap OPAC doesn't show the cart, lists, or login links because the template's checks of related system preferences relies on [% USE Koha %], which is not present. This patch adds it. To test, enable the bootstrap theme and OverDrive integration (OverDriveClientKey, etc.). Perform a search in the OPAC and click to view results from your OverDrive library. Confirm that cart, lists, and login links appear in the header. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Bug confirmed, and this patch fixes it. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org