[Bug 10533] New: basketgroup js functions should in a separated js file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Bug ID: 10533 Summary: basketgroup js functions should in a separated js file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com acqui/basketgroup.tt loads acq.js and a lot of acqui/*.tt loads js functions only used for basketgroup management. These functions should be in a separated js file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10522 Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19359&action=edit Bug 10533: basketgroup js functions should in a separated js file This patch moves js functions used for managing basketgroup into a separated js file. Test plan: - Try all actions for basketgroup ( drag/drop, add, delete, close, print, reopen, edit, export as csv). - Check that there is no regression on others acquisition pages: * acqui/neworderempty.tt * acqui/uncertainprice.tt * acqui/addorderiso2709.tt * acqui/basketheader.tt * admin/aqbudgets.tt * admin/aqcontract.tt * admin/aqbudgetperiods.tt * admin/aqplan.tt * suggestion/suggestion.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19359|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 19875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19875&action=edit [SIGNED-OFF] Bug 10533: basketgroup js functions should in a separated js file This patch moves js functions used for managing basketgroup into a separated js file. Test plan: - Try all actions for basketgroup ( drag/drop, add, delete, close, print, reopen, edit, export as csv). - Check that there is no regression on others acquisition pages: * acqui/neworderempty.tt * acqui/uncertainprice.tt * acqui/addorderiso2709.tt * acqui/basketheader.tt * admin/aqbudgets.tt * admin/aqcontract.tt * admin/aqbudgetperiods.tt * admin/aqplan.tt * suggestion/suggestion.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19875|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20235&action=edit Bug 10533: basketgroup js functions should in a separated js file This patch moves js functions used for managing basketgroup into a separated js file. Test plan: - Try all actions for basketgroup ( drag/drop, add, delete, close, print, reopen, edit, export as csv). - Check that there is no regression on others acquisition pages: * acqui/neworderempty.tt * acqui/uncertainprice.tt * acqui/addorderiso2709.tt * acqui/basketheader.tt * admin/aqbudgets.tt * admin/aqcontract.tt * admin/aqbudgetperiods.tt * admin/aqplan.tt * suggestion/suggestion.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Comparing the acq.js with the new basketgroup.js reveals a bunch of diffs like this: - var answer = confirm(MSG_CONFIRM_CLOSE_BASKETGROUP); + var answer=confirm(_("Are you sure you want to close this basketgroup?")); - alert(MSG_CLOSE_EMPTY_BASKET); + alert(_("Why close an empty basket?")); - cantprint.innerHTML = MSG_SAVE_BEFORE_PRINTING; + cantprint.innerHTML=_("You need to save the page before printing"); In other words, this patch effectively causes a partial regression on bug 7598. Please try again; it may be better to start from scratch rather than to edit the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Galen Charlton from comment #4)
Comparing the acq.js with the new basketgroup.js reveals a bunch of diffs like this:
- var answer = confirm(MSG_CONFIRM_CLOSE_BASKETGROUP); + var answer=confirm(_("Are you sure you want to close this basketgroup?"));
- alert(MSG_CLOSE_EMPTY_BASKET); + alert(_("Why close an empty basket?"));
- cantprint.innerHTML = MSG_SAVE_BEFORE_PRINTING; + cantprint.innerHTML=_("You need to save the page before printing");
In other words, this patch effectively causes a partial regression on bug 7598.
Please try again; it may be better to start from scratch rather than to edit the patch.
It seems to be a merge error on the signed off patch. I will resubmit a new patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20235|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20292&action=edit Bug 10533: basketgroup js functions should in a separated js file This patch moves js functions used for managing basketgroup into a separated js file. Test plan: - Try all actions for basketgroup ( drag/drop, add, delete, close, print, reopen, edit, export as csv). - Check that there is no regression on others acquisition pages: * acqui/neworderempty.tt * acqui/uncertainprice.tt * acqui/addorderiso2709.tt * acqui/basketheader.tt * admin/aqbudgets.tt * admin/aqcontract.tt * admin/aqbudgetperiods.tt * admin/aqplan.tt * suggestion/suggestion.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10716 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #7 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #8 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- "- Try all actions for basketgroup ( drag/drop, add, delete, close, print, reopen, edit, export as csv)." => OK for me M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 --- Comment #9 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Is there really a risk of regression on the other pages? Is there a specific point to test? M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to mathieu saby from comment #9)
Is there really a risk of regression on the other pages? Is there a specific point to test?
No, it is a c/p code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-09-29 00:00:00 |2013-10-30 last check this| | --- Comment #11 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I looked at the move of this code from one file to the other. And made a quick compare between what you deleted and what you created in a git format file. Unfortunately this compare was not very helpful. Too much differences (including spacing etc.) Makes it harder to verify what happens here.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 27036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27036&action=edit Bug 10533: move JavaScript functions for basket groups to a separate file This patch moves JavaScript functions used for managing basket groups to a file. This has the effect of putting the last (active) use of the YUI JavaScript library by the staff interface in one file: koha-tmpl/intranet-tmpl/prog/en/js/basketgroup.js Test plan: - Try all actions for basketgroup ( drag/drop, add, delete, close, print, reopen, edit, export as csv). - Check that there is no regression on others acquisition pages: * acqui/neworderempty.tt * acqui/uncertainprice.tt * acqui/addorderiso2709.tt * acqui/basketheader.tt * admin/aqbudgets.tt * admin/aqcontract.tt * admin/aqbudgetperiods.tt * admin/aqplan.tt * suggestion/suggestion.tt Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20292|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to M. de Rooy from comment #12)
I looked at the move of this code from one file to the other. And made a quick compare between what you deleted and what you created in a git format file. Unfortunately this compare was not very helpful. Too much differences (including spacing etc.) Makes it harder to verify what happens here..
Indeed. However, with some use of diff -bw to compare the old acq.js, the new acq.js, and basketgroup.js (and with testing of the acq pages, of course), I was able to convince myself that the patch implements a clean move of those functions. Plus, it has the benefit of sticking the last active use of YUI by the staff interface in one file. Signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27036|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27293&action=edit [PASSED QA] Bug 10533: move JavaScript functions for basket groups to a separate file This patch moves JavaScript functions used for managing basket groups to a file. This has the effect of putting the last (active) use of the YUI JavaScript library by the staff interface in one file: koha-tmpl/intranet-tmpl/prog/en/js/basketgroup.js Test plan: - Try all actions for basketgroup ( drag/drop, add, delete, close, print, reopen, edit, export as csv). - Check that there is no regression on others acquisition pages: * acqui/neworderempty.tt * acqui/uncertainprice.tt * acqui/addorderiso2709.tt * acqui/basketheader.tt * admin/aqbudgets.tt * admin/aqcontract.tt * admin/aqbudgetperiods.tt * admin/aqplan.tt * suggestion/suggestion.tt Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #17 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org