[Bug 14008] New: Saved reports disappear from display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Bug ID: 14008 Summary: Saved reports disappear from display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org To reproduce: - search for a keyword in your reports that exists - search works, correct reports are displayed - search for a keyword in your reports, that doesn't exist - result is correct and a nice message shown - click "use saved" in the navigation to the left to return to your full reports list - nothing is shown, all reports are hiding. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38062&action=edit Bug 14008: Display active filters when searching for reports On the saved report list, the filters on the left are not displayed. It means that some can be set, but the user has not visible feedbacks. How filters work here: If a user set a filter, it is saved in the session. Next time he will come on this search, the previous values will be kept. This patch just displayed the filter's values in the input fields. Test plan: Search for reports by date, author and keyword. The filters should be displayed after you have clicked on the submit button ("Apply filter"). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10706 CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Small patch Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Saved reports disappear |Filters are not displayed |from display |on search for reports --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #0)
To reproduce: - search for a keyword in your reports that exists - search works, correct reports are displayed - search for a keyword in your reports, that doesn't exist - result is correct and a nice message shown - click "use saved" in the navigation to the left to return to your full reports list - nothing is shown, all reports are hiding.
It was a feature, but did not work very well :) This patch should remove the ambiguity. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 38125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38125&action=edit Bug 14008 - Proposed follow-up: Dialog should appear whenever filters are active The first patch displays the value(s) of an active filter if you come back to the page or reload the page via a menu action. To make the situation more clear the dialog "No saved reports match your criteria." shoudl always appear when a filter is active. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38062|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38136&action=edit Bug 14008: Display active filters when searching for reports On the saved report list, the filters on the left are not displayed. It means that some can be set, but the user has not visible feedbacks. How filters work here: If a user set a filter, it is saved in the session. Next time he will come on this search, the previous values will be kept. This patch just displayed the filter's values in the input fields. Test plan: Search for reports by date, author and keyword. The filters should be displayed after you have clicked on the submit button ("Apply filter"). Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38125|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38137&action=edit Bug 14008 - Proposed follow-up: Dialog should appear whenever filters are active The first patch displays the value(s) of an active filter if you come back to the page or reload the page via a menu action. To make the situation more clear the dialog "No saved reports match your criteria." shoudl always appear when a filter is active. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Oops... Signed off without including the "Depends on". Will re-test in 6+ hours. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Retested with dependency. Sign-off holds. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38136|0 |1 is obsolete| | Attachment #38137|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38211&action=edit [PASSED QA] Bug 14008: Display active filters when searching for reports On the saved report list, the filters on the left are not displayed. It means that some can be set, but the user has not visible feedbacks. How filters work here: If a user set a filter, it is saved in the session. Next time he will come on this search, the previous values will be kept. This patch just displayed the filter's values in the input fields. Test plan: Search for reports by date, author and keyword. The filters should be displayed after you have clicked on the submit button ("Apply filter"). Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38212&action=edit [PASSED QA] Bug 14008 - Proposed follow-up: Dialog should appear whenever filters are active The first patch displays the value(s) of an active filter if you come back to the page or reload the page via a menu action. To make the situation more clear the dialog "No saved reports match your criteria." shoudl always appear when a filter is active. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org