[Bug 10063] New: Correct the documentation for the C4:Members sub: IsMemberBlocked
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 Bug ID: 10063 Summary: Correct the documentation for the C4:Members sub: IsMemberBlocked Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Developer documentation Assignee: gmcharlt@gmail.com Reporter: dcook@prosentient.com.au The perldoc for the IsMemberBlocked sub isn't accurate. It just needs to be updated so as to accurately describe the sub. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39972&action=edit Bug 10063: Correct documentation of C4::Members::IsMemberBlocked Rephrased documentation a bit, replacing fine days with the more general term restriction. As IsDebarred checks for existing active restrictions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- David, is this what you had in mind? If not, you will have to steer me in he right direction with this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #2)
David, is this what you had in mind? If not, you will have to steer me in he right direction with this.
No idea :). I should've written a better comment 2 years ago when I reported it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 39972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39972 Bug 10063: Correct documentation of C4::Members::IsMemberBlocked Review of attachment 39972: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10063&attachment=39972) ----------------------------------------------------------------- ::: C4/Members.pm @@ +531,4 @@
FIXME: this needs to be split into two functions; a potential block based on the number of current overdue items could be orthogonal +to a block based on whether the patron has any restrictions.
I'm not sure this FIXME is relevant any more. We have the Debarment function and surely there is a function in C4::Overdues which can be used to get the issues overdue count. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39972|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40145&action=edit Bug 10063: Correct documentation of C4::Members::IsMemberBlocked Rephrased documentation a bit, replacing fine days with the more general term restriction. As IsDebarred checks for existing active restrictions. TEST PLAN --------- 1) apply patch 2) git diff origin/master -- do the changes make sense 3) perldoc C4::Members -- look for the IsMemberBlocked. -- Does it reflect current state 4) koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. Tompsett from comment #4)
Comment on attachment 39972 [details] [review] Bug 10063: Correct documentation of C4::Members::IsMemberBlocked
Review of attachment 39972 [details] [review]: -----------------------------------------------------------------
::: C4/Members.pm @@ +531,4 @@
FIXME: this needs to be split into two functions; a potential block based on the number of current overdue items could be orthogonal +to a block based on whether the patron has any restrictions.
I'm not sure this FIXME is relevant any more. We have the Debarment function and surely there is a function in C4::Overdues which can be used to get the issues overdue count.
Same here, shouldn't we remove this FIXME? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was not sure so I left it - if you want, please go ahead and remove it! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40145|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40377&action=edit Bug 10063: Correct documentation of C4::Members::IsMemberBlocked Rephrased documentation a bit, replacing fine days with the more general term restriction. As IsDebarred checks for existing active restrictions. TEST PLAN --------- 1) apply patch 2) git diff origin/master -- do the changes make sense 3) perldoc C4::Members -- look for the IsMemberBlocked. -- Does it reflect current state 4) koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40378&action=edit Bug 10063: Remove outdated FIXME Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40377|0 |1 is obsolete| | Attachment #40378|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40390&action=edit Bug 10063: Correct documentation of C4::Members::IsMemberBlocked Rephrased documentation a bit, replacing fine days with the more general term restriction. As IsDebarred checks for existing active restrictions. TEST PLAN --------- 1) apply patch 2) git diff origin/master -- do the changes make sense 3) perldoc C4::Members -- look for the IsMemberBlocked. -- Does it reflect current state 4) koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40391&action=edit Bug 10063: Remove outdated FIXME Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40390|0 |1 is obsolete| | Attachment #40391|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40392&action=edit [PASSED QA] Bug 10063: Correct documentation of C4::Members::IsMemberBlocked Rephrased documentation a bit, replacing fine days with the more general term restriction. As IsDebarred checks for existing active restrictions. TEST PLAN --------- 1) apply patch 2) git diff origin/master -- do the changes make sense 3) perldoc C4::Members -- look for the IsMemberBlocked. -- Does it reflect current state 4) koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40393&action=edit [PASSED QA] Bug 10063: Remove outdated FIXME Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org