[Bug 29803] New: Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Bug ID: 29803 Summary: Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios Change sponsored?: --- Product: Koha Version: 21.11 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martinbmorris@gmail.com QA Contact: testopia@bugs.koha-community.org After upgrading to 21.11 from 21.05, locally cover images stopped loading on the details page for an individual biblio. They still load in a listing of multiple biblios. Additionally, images from the locally running Coce server load without problems. Example of multiple listing where covers show as normal: https://katalogo.biblioteko.ca/cgi-bin/koha/opac-search.pl?q=au:%22Doyle%2C%... Example of individual biblio where locally stored cover doesn't load: https://katalogo.biblioteko.ca/cgi-bin/koha/opac-detail.pl?biblionumber=2189&query_desc=au%3A%22Doyle%2C%20Arthur%20Conan%22 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- The image is loading but it is hidden. I notice you have some CSS loading twice in your OPAC: <link href="/opac-tmpl/bootstrap/css/opac_21.1101000.css" type="text/css" rel="stylesheet"> <link rel="stylesheet" type="text/css" href="/opac-tmpl/bootstrap/css/opac.css" /> Do you have a custom stylesheet defined somewhere? In the OpacAdditionalStylesheet system preference perhaps? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #2 from Martin Morris <martinbmorris@gmail.com> --- Thanks for the reply. I do have some custom CSS which I had previously stripped out (from OpacAdditionalStylesheet and any other possible field), which didn't help at all. I do also have a custom Coce server, hosted on the same machine, and I have now discovered that if I disable that the local cover images display correctly. Is this a bug in 21.11 which causes a conflict between a locally hosted Coce server and locally stored cover images perhaps? It worked perfectly under 21.05 and the previous versions of Koha I had used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Looks like it's working now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #4 from Martin Morris <martinbmorris@gmail.com> --- Only if I disable Coce, and I do very much want/need that to be working as well. So I wouldn't want to close this bug until that issue is resolved in case it's not just my system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #1)
<link href="/opac-tmpl/bootstrap/css/opac_21.1101000.css" type="text/css" rel="stylesheet"> <link rel="stylesheet" type="text/css" href="/opac-tmpl/bootstrap/css/opac.css" />
Do you have a custom stylesheet defined somewhere? In the OpacAdditionalStylesheet system preference perhaps?
The source for that page still has two links to opac.css. I think that's the cause. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #6 from Martin Morris <martinbmorris@gmail.com> --- I have now stripped out all customisation of the OPAC css and the source shows that <link rel="stylesheet" type="text/css" href="/opac-tmpl/bootstrap/css/opac.css" /> is now absent. Upon reenabling Coce the local cover image again fails to display. Will leave the catalogue like this while investigating. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28180 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've tested this with BywaterSolutions Coce server and for me it's the other way around. When both Coce and local covers are available, only the local cover shows on the detail page. The result page shows both. I wonder if that has to do with bug 28180 - linking them just in case. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- For testing: https://bywatersolutions.com/education/koha-tutorial-cover-images-koha-opac-... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129247&action=edit Bug 29803: Prevent local cover image to be hidden if Coce is enabled If Coce is enabled by no image are returned by the service, then no other image will be displayed (actually un-hidden) The getURL is returning early if no image is returned by the service and the "done" flag is never set. Test plan: Add a local cover image to a bibliographic record (ktd biblionumber=14 is good) Set CoceHost = http://coce.bywatersolutions.com Select all CoceProviders Enable OpacCoce => If no image is returned by Coce then the local image should be displayed anyway -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |unspecified Assignee|oleonard@myacpl.org |jonathan.druart+koha@gmail. | |com CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129248&action=edit Bug 29803: Do not wait for the images more than 5 seconds In case of the previous bug, the page was calling the callback function every 100ms, endlessly. We should add a test to prevent future similar problem. Test plan: Remove the previous patch "Prevent local cover image to be hidden if Coce is enabled" Recreate the test plan => You should see the local image displayed after 5 seconds, and a log in the JS console -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #11 from Martin Morris <martinbmorris@gmail.com> --- Hello there Both patches applied, and that worked! Many thanks for your efforts on resolving this bug. Martin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Eliana <eliana@flo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eliana@flo.org --- Comment #12 from Eliana <eliana@flo.org> --- I believe we have the same issue as Martin (although we're on 21.05). I tried the troubleshooting suggestions above and they didn't work for me. Wondering what I'm missing here. Covers show in opac-search.pl: https://catalog.helmlib.org/cgi-bin/koha/opac-search.pl?idx=ti&q=Careers+in+psychology+%26+behavioral+health.&limit=&weight_search=1 No covers in opac-detail.pl: https://catalog.helmlib.org/cgi-bin/koha/opac-detail.pl?biblionumber=1253757&query_desc=Careers%20in%20psychology%20%26%20behavioral%20health. The local covers do load in opac-detail.pl sometimes, adding to my confusion: https://catalog.helmlib.org/cgi-bin/koha/opac-detail.pl?biblionumber=1298655&query_desc=1298655 The ones that don't appear seem to blip in and out of existence as the page loads so they're being hidden by something. I've tried disabling JS which didn't solve the problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #13 from Martin Morris <martinbmorris@gmail.com> --- Good afternoon I've just upgraded to 21.11.02 and this problem has returned. Can I just reapply the patches which I previously applied for 21.11.01? Martin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Morris from comment #13)
Good afternoon
I've just upgraded to 21.11.02 and this problem has returned. Can I just reapply the patches which I previously applied for 21.11.01?
Martin
Can you add your Signed-off-by lines to them? That will make them move forward. https://wiki.koha-community.org/wiki/Sign_off_on_patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Morris from comment #13)
Good afternoon
I've just upgraded to 21.11.02 and this problem has returned. Can I just reapply the patches which I previously applied for 21.11.01?
Martin
It will probably work, but you always have to be careful when applying manually locally. Better to get this moving into releases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129247|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130579&action=edit Bug 29803: Prevent local cover image to be hidden if Coce is enabled If Coce is enabled by no image are returned by the service, then no other image will be displayed (actually un-hidden) The getURL is returning early if no image is returned by the service and the "done" flag is never set. Test plan: Add a local cover image to a bibliographic record (ktd biblionumber=14 is good) Set CoceHost = http://coce.bywatersolutions.com Select all CoceProviders Enable OpacCoce => If no image is returned by Coce then the local image should be displayed anyway Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129248|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130580&action=edit Bug 29803: Do not wait for the images more than 5 seconds In case of the previous bug, the page was calling the callback function every 100ms, endlessly. We should add a test to prevent future similar problem. Test plan: Remove the previous patch "Prevent local cover image to be hidden if Coce is enabled" Recreate the test plan => You should see the local image displayed after 5 seconds, and a log in the JS console Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I signed off, but you might want to have a look at the warning from QA test tools for QA: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt FAIL forbidden patterns forbidden pattern: console.log (line 1568) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The console.log is expected, see the second patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #19)
The console.log is expected, see the second patch.
I thought it might, but always better to get any questions out of the way :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Locally stored cover images |Local cover images don't |do not show in detail page |show in detail page, but |for individual biblio, but |only in results |do show in listing for | |multiple biblios | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130579|0 |1 is obsolete| | Attachment #130580|0 |1 is obsolete| | --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130866&action=edit Bug 29803: Prevent local cover image to be hidden if Coce is enabled If Coce is enabled by no image are returned by the service, then no other image will be displayed (actually un-hidden) The getURL is returning early if no image is returned by the service and the "done" flag is never set. Test plan: Add a local cover image to a bibliographic record (ktd biblionumber=14 is good) Set CoceHost = http://coce.bywatersolutions.com Select all CoceProviders Enable OpacCoce => If no image is returned by Coce then the local image should be displayed anyway Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130867&action=edit Bug 29803: Do not wait for the images more than 5 seconds In case of the previous bug, the page was calling the callback function every 100ms, endlessly. We should add a test to prevent future similar problem. Test plan: Remove the previous patch "Prevent local cover image to be hidden if Coce is enabled" Recreate the test plan => You should see the local image displayed after 5 seconds, and a log in the JS console Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle@bywatersolutions.com --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Manos PETRIDIS <egpetridis@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis@yahoo.com --- Comment #25 from Manos PETRIDIS <egpetridis@yahoo.com> --- Could this be related to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Manos PETRIDIS from comment #25)
Could this be related to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 ?
It could be a duplicate, but this bug has already been closed and pushed to stable versions, so best way to find out is to update :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #27 from Manos PETRIDIS <egpetridis@yahoo.com> --- (In reply to Katrin Fischer from comment #26)
(In reply to Manos PETRIDIS from comment #25)
Could this be related to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 ?
It could be a duplicate, but this bug has already been closed and pushed to stable versions, so best way to find out is to update :)
Unfortunately I'm already at 21.11.03.000 and apt-get reports there isn't anything new to install. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #28 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org