https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29962 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29962 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- This patch works and restores the Columns button. However the order of the columns is wrong in the tool is wrong. This is a bit confusing. On every other page I looked at with a Columns button, the order in the tool is the same as the order in the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29962 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Lucas Gass from comment #2)

This patch works and restores the Columns button. However the order of the columns is wrong in the tool is wrong. This is a bit confusing.

On every other page I looked at with a Columns button, the order in the tool is the same as the order in the table.

I would report this on a separate bug report. This one is restoring a regression from bug 27526. The way we deal with the table settings is different on this view, we pass the bKohaColumnsUseNames flag to KohaTable: we won't display all the columns defined in the yaml file, only those that have at least a non-empty value. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29962 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129919|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 130584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130584&action=edit Bug 29962: (bug 27526 follow-up): Fix columns button on item list The "Columns" button on the item list view has been broken (hidden) by bug 27526. "column_name" was removed from the item_header_loop: - if ( $kohafield && $kohafield =~ /items.(.+)/ ) { - $header_value{column_name} = $1; - } We can still access the attribute name using 'attribute' however. The difference is that non-mapped subfield will have an "attribute", but there is a net to prevent a crash in columns_settings.inc: 12 var named_id = $( 'thead th[data-colname="' + this.columnname + '"]', selector ).index( selector + ' th' ); 13 var used_id = dt_parameters.bKohaColumnsUseNames ? named_id : counter; 14 if ( used_id == -1 ) return; We should simply pass attribute. Test plan: Create a non-mapped subfield (952$k) Edit an item, add a value for k On the item table at the top of the edit form notice that the "Columns" button is back and that it's working correctly. Note that 'k' cannot be hidden (may be considered as a bug, but it's not a regression). Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29962 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130584|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130877&action=edit Bug 29962: (bug 27526 follow-up): Fix columns button on item list The "Columns" button on the item list view has been broken (hidden) by bug 27526. "column_name" was removed from the item_header_loop: - if ( $kohafield && $kohafield =~ /items.(.+)/ ) { - $header_value{column_name} = $1; - } We can still access the attribute name using 'attribute' however. The difference is that non-mapped subfield will have an "attribute", but there is a net to prevent a crash in columns_settings.inc: 12 var named_id = $( 'thead th[data-colname="' + this.columnname + '"]', selector ).index( selector + ' th' ); 13 var used_id = dt_parameters.bKohaColumnsUseNames ? named_id : counter; 14 if ( used_id == -1 ) return; We should simply pass attribute. Test plan: Create a non-mapped subfield (952$k) Edit an item, add a value for k On the item table at the top of the edit form notice that the "Columns" button is back and that it's working correctly. Note that 'k' cannot be hidden (may be considered as a bug, but it's not a regression). Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29962 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29962 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |andrew@bywatersolutions.com --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes.