[Bug 39171] New: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 Bug ID: 39171 Summary: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: glasklas@gmail.com QA Contact: testopia@bugs.koha-community.org To better reflect what the actual format is, and avoid using different names in the code and syspref, the ElastcsearchMARCFormat IS02709 should be renamed to base64ISO2709. Since the setting is actually never explicitly checked anywhere this should be safe to do and very little chance of causing any issues. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178373&action=edit Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709 To test: 1) Apply patch 2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t pass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |glasklas@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178373|0 |1 is obsolete| | --- Comment #2 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178374&action=edit Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709 To test: 1) Apply patch 2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27859 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 [Bug 27859] MARC export for search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178374|0 |1 is obsolete| | --- Comment #3 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178375&action=edit Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709 To test: 1) Apply patch 2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178375|0 |1 is obsolete| | --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 178384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178384&action=edit Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709 To test: 1) Apply patch 2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t pass Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Noting that this isn't passing the QA tools: WARN installer/data/mysql/atomicupdate/bug_39171-rename_IS02709_ElasticsearchMarcFormat_to_base64ISO2709.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 6) OK installer/data/mysql/mandatory/sysprefs.sql OK t/db_dependent/Koha/SearchEngine/Elasticsearch.t I'm not sure if atomicupdates are supposed to be tidy or not, so leaving that for a more up-to-date QA person to decide -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |domm@plix.at QA Contact|testopia@bugs.koha-communit |domm@plix.at |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178384|0 |1 is obsolete| | --- Comment #6 from Thomas Klausner <domm@plix.at> --- Created attachment 179915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179915&action=edit Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709 To test: 1) Apply patch 2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t pass Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 --- Comment #7 from Thomas Klausner <domm@plix.at> --- Created attachment 179916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179916&action=edit Bug 39171: apply perltidy to atomicupdate file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179915|0 |1 is obsolete| | --- Comment #8 from Thomas Klausner <domm@plix.at> --- Created attachment 179917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179917&action=edit Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709 To test: 1) Apply patch 2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t pass Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179916|0 |1 is obsolete| | --- Comment #9 from Thomas Klausner <domm@plix.at> --- Created attachment 179918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179918&action=edit Bug 39171: apply perltidy to atomicupdate file Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thomas, thanks for QA. As we are trying to avoid tidy only patches, I have squashed yours into the main patch. Hope that's OK. David, please always use say_success for the success messages to keep your RM happy :) Have a look at the database updates for this release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39171 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org