[Bug 38994] New: Class up the circulation homepage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 Bug ID: 38994 Summary: Class up the circulation homepage Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com There aren't distinct html classes on the various sections and buttons on /cgi-bin/koha/circ/circulation-home.pl and it makes things hard to target with CSS. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 177319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177319&action=edit Bug 38994: Add classes to circulation module homepage To test: 1: inspect /koha/circ/circulation-home.pl, see most elements lack distinct classes 2: apply patch, reload page 3: inspect page again, confirm nothing has changed in display 4: confirm page elements have distinct classes now and can be accurately targetted with CSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Applying patches produces following error: Applying: Bug 38994: Add classes to circulation module homepage Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 38994: Add classes to circulation module homepage hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-38994-Add-classes-to-circulation-module-homepa-xIUMjF.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177319|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 180782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180782&action=edit Bug 38994: Add classes to circulation module homepage To test: 1: inspect /koha/circ/circulation-home.pl, see most elements lack distinct classes 2: apply patch, reload page 3: inspect page again, confirm nothing has changed in display 4: confirm page elements have distinct classes now and can be accurately targetted with CSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180782|0 |1 is obsolete| | --- Comment #4 from Jason Robb <jrobb@sekls.org> --- Created attachment 180795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180795&action=edit Bug 38994: Add classes to circulation module homepage To test: 1: inspect /koha/circ/circulation-home.pl, see most elements lack distinct classes 2: apply patch, reload page 3: inspect page again, confirm nothing has changed in display 4: confirm page elements have distinct classes now and can be accurately targetted with CSS Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- I reckon for "Offline circulation", it would be good to have a class for the whole section. For instance, for bug 39378, if someone wanted to hide this with CSS, they'd need to do it for the whole section. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to David Cook from comment #5)
I reckon for "Offline circulation", it would be good to have a class for the whole section.
For instance, for bug 39378, if someone wanted to hide this with CSS, they'd need to do it for the whole section.
That section already has an id, so this works: #offline-circulation { display: none; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Andrew Fuerste-Henry from comment #6)
That section already has an id, so this works: #offline-circulation { display: none; }
Ah, nice one! Looks like I misread the patch! Thanks for the correction :). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180795|0 |1 is obsolete| | --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Created attachment 180894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180894&action=edit Bug 38994: Add classes to circulation module homepage To test: 1: inspect /koha/circ/circulation-home.pl, see most elements lack distinct classes 2: apply patch, reload page 3: inspect page again, confirm nothing has changed in display 4: confirm page elements have distinct classes now and can be accurately targetted with CSS Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- I really like this. The more hooks on HTML elements the better imho. Technically, some of these classes probably could've/should've been IDs, but I don't think it matters, especially since you can chain them together with the body ID of "circ_circulation-home". So thumbs up from me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Class up the circulation |Add class attributes to the |homepage |circulation homepage to | |ease customization --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree about the id vs. class predicament, but I don't have a strong argument for changing it. Some of the classes are quite general, but there doesn't appear to be a conflict as far as I can tell. Not blocker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38994 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x (cherry pick showed to much conflicts even with ignore spaces strategy) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org