[Bug 28509] New: Koha/Acquisition/Orders.t is failing (randomly?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Bug ID: 28509 Summary: Koha/Acquisition/Orders.t is failing (randomly?) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org 03:25:39 koha_1 | # Failed test 'The 2 orders are returned' 03:25:39 koha_1 | # at t/db_dependent/Koha/Acquisition/Orders.t line 152. 03:25:39 koha_1 | # Structures begin differing at: 03:25:39 koha_1 | # $got->[0] = '10' 03:25:39 koha_1 | # $expected->[0] = '9' 03:25:39 koha_1 | # Looks like you failed 1 test of 4. 03:25:39 koha_1 | 03:25:39 koha_1 | # Failed test 'filter_by_id_including_transfers() tests' 03:25:39 koha_1 | # at t/db_dependent/Koha/Acquisition/Orders.t line 160. 03:25:39 koha_1 | # Looks like you failed 1 test of 2. 03:25:39 koha_1 | [01:24:50] t/db_dependent/Koha/Acquisition/Orders.t Koha_21.05_D10 run 6 on Docker_5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Master_D9_MDB_Latest/612 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Koha_21.05_D9/26 D5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #1)
Master_D9_MDB_Latest/612
This was on Docker_2. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #3)
(In reply to Jonathan Druart from comment #1)
Master_D9_MDB_Latest/612
This was on Docker_2.
16:36:15 koha_1 | # Failed test 'The 2 orders are returned' 16:36:15 koha_1 | # at t/db_dependent/Koha/Acquisition/Orders.t line 152. 16:36:15 koha_1 | # Structures begin differing at: 16:36:15 koha_1 | # $got->[0] = '100' 16:36:15 koha_1 | # $expected->[0] = '99' 16:36:15 koha_1 | # Looks like you failed 1 test of 4. 16:36:15 koha_1 | 16:36:15 koha_1 | # Failed test 'filter_by_id_including_transfers() tests' 16:36:15 koha_1 | # at t/db_dependent/Koha/Acquisition/Orders.t line 160. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #2)
Koha_21.05_D9/26 D5
16:51:24 koha_1 | # Failed test 'The 2 orders are returned' 16:51:24 koha_1 | # at t/db_dependent/Koha/Acquisition/Orders.t line 152. 16:51:24 koha_1 | # Structures begin differing at: 16:51:24 koha_1 | # $got->[0] = '10' 16:51:24 koha_1 | # $expected->[0] = '9' 16:51:24 koha_1 | # Looks like you failed 1 test of 4. 16:51:24 koha_1 | 16:51:24 koha_1 | # Failed test 'filter_by_id_including_transfers() tests' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122942&action=edit Bug 28509: Prevent Koha/Acquisition/Orders.t to fail randomly The random errors were: 03:25:39 koha_1 | # Structures begin differing at: 03:25:39 koha_1 | # $got->[0] = '10' 03:25:39 koha_1 | # $expected->[0] = '9' and 16:36:15 koha_1 | # Structures begin differing at: 16:36:15 koha_1 | # $got->[0] = '100' 16:36:15 koha_1 | # $expected->[0] = '99' You see it coming? We sorted the ordernumbers alphabetically. Test plan: 0. Don't apply this patch 1. % git checkout v21.05.01 # The error is not appearing in master right now 2. Add 2 warn statements before the 'The 2 orders are returned' tests to display $order_1->ordernumber and $order_2->ordernumber 3. MariaDB CLI > ALTER TABLE aqorders AUTO_INCREMENT=3; 4. prove t/db_dependent/Koha/Acquisition/Orders.t => Fail with # Structures begin differing at: # $got->[0] = '10' # $expected->[0] = '9' 5. Apply this patch, repeat 3. and 4. => The test passes now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha/Acquisition/Orders.t |Koha/Acquisition/Orders.t |is failing (randomly?) |is failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122942|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 123293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123293&action=edit Bug 28509: Prevent Koha/Acquisition/Orders.t to fail randomly The random errors were: 03:25:39 koha_1 | # Structures begin differing at: 03:25:39 koha_1 | # $got->[0] = '10' 03:25:39 koha_1 | # $expected->[0] = '9' and 16:36:15 koha_1 | # Structures begin differing at: 16:36:15 koha_1 | # $got->[0] = '100' 16:36:15 koha_1 | # $expected->[0] = '99' You see it coming? We sorted the ordernumbers alphabetically. Test plan: 0. Don't apply this patch 1. % git checkout v21.05.01 # The error is not appearing in master right now 2. Add 2 warn statements before the 'The 2 orders are returned' tests to display $order_1->ordernumber and $order_2->ordernumber 3. MariaDB CLI > ALTER TABLE aqorders AUTO_INCREMENT=3; 4. prove t/db_dependent/Koha/Acquisition/Orders.t => Fail with # Structures begin differing at: # $got->[0] = '10' # $expected->[0] = '9' 5. Apply this patch, repeat 3. and 4. => The test passes now. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |25670 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 [Bug 25670] Add useful methods to Koha::Acquisition::Orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 25670 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Bug 28509 depends on bug 25670, which changed state. Bug 25670 Summary: Add useful methods to Koha::Acquisition::Orders https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org