[Bug 27719] New: receiving orders hangs on processing when missing a replacement price
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Bug ID: 27719 Summary: receiving orders hangs on processing when missing a replacement price Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: agustinmoyano@theke.io Reporter: agustinmoyano@theke.io QA Contact: testopia@bugs.koha-community.org Depends on: 20212 The list of items to be received hangs at Processing if any of your items/orders do not include a replacement price. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Slowness in receiving in acquisitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 --- Comment #1 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 116946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116946&action=edit Bug 27719: Apply _escape_str and _escape_price where needed This bug replaces calls for .escapeHtml and format_price for there null checking counterparts To test: 1: have a fresh Koha Testing Docker 2: have a basket set to create item records on ordering 3: populate basket from a marc file, only setting price and fund for the items 4: close basket 5: click to Receive, create invoice 6: on parcel.pl, "Processing" alert never resolves CHECK => The console shows: parcel.pl?invoiceid=1:810 Uncaught TypeError: Cannot read property 'format_price' of null at render (parcel.pl?invoiceid=1:810) at datatables.min_20.1200012.js:57 at Object.b.fnGetData (datatables.min_20.1200012.js:51) at B (datatables.min_20.1200012.js:56) at Ha (datatables.min_20.1200012.js:64) at P (datatables.min_20.1200012.js:68) at vb (datatables.min_20.1200012.js:79) at datatables.min_20.1200012.js:76 at i (datatables.min_20.1200012.js:74) at Object.success (datatables.min_20.1200012.js:75) And that error points toward: "data": "replacement_price", "render": function(data, type, row, meta) { return (row.replacement_price).format_price(); }, }, 7: apply patch 8: redo steps 5 and 6 SUCCESS => "Processing" alert doesn't hangs, and prices with null values are empty. Sponsored-by: Virginia Polytechnic Institute and State University -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8179 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116946|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 116947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116947&action=edit Bug 27719: Apply _escape_str and _escape_price where needed This bug replaces calls for .escapeHtml and format_price for there null checking counterparts To test: 1: have a fresh Koha Testing Docker 2: have a basket set to create item records on ordering 3: populate basket from a marc file, only setting price and fund for the items 4: close basket 5: click to Receive, create invoice 6: on parcel.pl, "Processing" alert never resolves CHECK => The console shows: parcel.pl?invoiceid=1:810 Uncaught TypeError: Cannot read property 'format_price' of null at render (parcel.pl?invoiceid=1:810) at datatables.min_20.1200012.js:57 at Object.b.fnGetData (datatables.min_20.1200012.js:51) at B (datatables.min_20.1200012.js:56) at Ha (datatables.min_20.1200012.js:64) at P (datatables.min_20.1200012.js:68) at vb (datatables.min_20.1200012.js:79) at datatables.min_20.1200012.js:76 at i (datatables.min_20.1200012.js:74) at Object.success (datatables.min_20.1200012.js:75) And that error points toward: "data": "replacement_price", "render": function(data, type, row, meta) { return (row.replacement_price).format_price(); }, }, 7: apply patch 8: redo steps 5 and 6 SUCCESS => "Processing" alert doesn't hangs, and prices with null values are empty. Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|receiving orders hangs on |Receiving orders hangs on |processing when missing a |processing when missing a |replacement price |replacement price -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116947|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116965&action=edit Bug 27719: Apply _escape_str and _escape_price where needed This bug replaces calls for .escapeHtml and format_price for there null checking counterparts To test: 1: have a fresh Koha Testing Docker 2: have a basket set to create item records on ordering 3: populate basket from a marc file, only setting price and fund for the items 4: close basket 5: click to Receive, create invoice 6: on parcel.pl, "Processing" alert never resolves CHECK => The console shows: parcel.pl?invoiceid=1:810 Uncaught TypeError: Cannot read property 'format_price' of null at render (parcel.pl?invoiceid=1:810) at datatables.min_20.1200012.js:57 at Object.b.fnGetData (datatables.min_20.1200012.js:51) at B (datatables.min_20.1200012.js:56) at Ha (datatables.min_20.1200012.js:64) at P (datatables.min_20.1200012.js:68) at vb (datatables.min_20.1200012.js:79) at datatables.min_20.1200012.js:76 at i (datatables.min_20.1200012.js:74) at Object.success (datatables.min_20.1200012.js:75) And that error points toward: "data": "replacement_price", "render": function(data, type, row, meta) { return (row.replacement_price).format_price(); }, }, 7: apply patch 8: redo steps 5 and 6 SUCCESS => "Processing" alert doesn't hangs, and prices with null values are empty. Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 20212 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Bug 27719 depends on bug 20212, which changed state. Bug 20212 Summary: Improve performance of acquisitions receive page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org