[Bug 21103] New: Fix parameter reuse in Elasticsearch/QueryBuilder.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21103 Bug ID: 21103 Summary: Fix parameter reuse in Elasticsearch/QueryBuilder.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org t/00-testcritic.t is failing on master On line 318 we have: foreach $val (@values) { $val is a parameter passed in elsewhere, we should declare our own variable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21103 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21103 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77188&action=edit Bug 21103: Declare new parameter for loop iterator To test: prove -v t/00-testcritic.t it fails apply patch it passes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21103 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |19604 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21103 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- The third patch: "Bug 19604: Fix perlcritic "Loop iterator is not lexical" (1.20 KB, patch) 2018-07-31 11:22 UTC, Jonathan Druart" is a duplicate, except for variable names chosen. *** This bug has been marked as a duplicate of bug 19604 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21103 Bug 21103 depends on bug 19604, which changed state. Bug 19604 Summary: Elasticsearch Fixes for build_authorities_query for auth searching https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org