https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 72090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72090&action=edit Bug 20273 - Use compat routines for autocomplete in auth_finder.pl Test plan: - Context: Koha working with elasticsearch, - Apply BZ 19582 (that make auth_finder.pl works again), - apply this patch, - go to cgi-bin/koha/authorities/auth_finder.pl, - type at least 3 chararcters in a search field and check that the autocomplete returns results -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17373 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17373 [Bug 17373] Elasticsearch - Authority mappings for UNIMARC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- I applied again with apply-on-cascade bz, applied all patches, update db, koha schema, reset mappings, rebuild index... for what it's worth, here is the ysearch url : http://localhost:9999/cgi-bin/koha/authorities/ysearch.pl?authtypecode=&term=Sha&op=do_search&type=intranet&and_or=and&operator=contains&orderby=HeadingAsc&querytype=mainmainentry I have '[]' as a result. Note I can't use normal search and find something with 'sha' or 'sha*', I have results with the complete 'shalev'. When I type 'shalev' in place of 'sha' in ysearch, it answers an error: Software error: Undefined subroutine &C4::AuthoritiesMarc::BuildSummary called at /home/koha/kohaclone/Koha/SearchEngine/Elasticsearch/Search.pm line 234. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #6 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Nicolas Legrand from comment #5)

The ysearch.pl use 'contains' operator instead of 'start'. When adjusting the search form to 'start with', ysearch.pl still launch a 'contains' operator. It means we need to put a complete word to make it work.

Is it the wanted behaviour? Wouldn't it be better to put a start operator by default? When I type three letters and see the wheel spinning without results, it feels like nothing looks like what I typed.

I'm not sure of the right answer, but i'm not upset by that. Operators are used for the search itself, not for autocomplete. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #8 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 74997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74997&action=edit Bug 20273: Followup - Autocomplete use start instead of contains -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74996|0 |1 is obsolete| | --- Comment #9 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 74998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74998&action=edit Bug 20273 - Use compat routines for autocomplete in auth_finder.pl Test plan: - Context: Koha working with elasticsearch, - Apply BZ 19582 (that make auth_finder.pl works again), - apply this patch, - go to cgi-bin/koha/authorities/auth_finder.pl, - type at least 3 chararcters in a search field and check that the autocomplete returns results Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74999|0 |1 is obsolete| | --- Comment #12 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 75001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75001&action=edit Bug 20273: Followup - Autocomplete use start instead of contains Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd love to test this, but I am stuck on my Elasticsearch authority search not working at all. This is what I've tried: I've reset my mappings using: http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 Then I've done a complete reindex. When I search for an authority, I get an Internal server error resolving to: [Request] ** [http://localhost:9200]-[400] [query_shard_exception] No mapping found for [Heading__sort.phrase] in order to sort on, with: {"index":"koha_kohadev_authorities","index_uuid":"FwdgBXbyRq-5E0F3sa4LTA"}, called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at /usr/share/perl5/Catmandu/Store/ElasticSearch/Bag.pm line 167. With vars: {'request' => {'method' => 'GET','path' => '/koha_kohadev_authorities/data/_search','ignore' => [],'mime_type' => 'application/json','qs' => {},'body' => {'sort' => [{'Heading__sort.phrase' => 'asc'}],'query' => {'bool' => {'should' => [{'match' => {'Heading-Main' => 'k'}}]}},'size' => 20,'from' => 0},'serialize' => 'std'},'status_code' => 400,'body' => {'status' => 400,'error' => {'type' => 'search_phase_execution_exception','grouped' => bless( do{\(my $o = 1)}, 'JSON::PP::Boolean' ),'failed_shards' => [{'shard' => 0,'reason' => {'index' => 'koha_kohadev_authorities','type' => 'query_shard_exception','reason' => 'No mapping found for [Heading__sort.phrase] in order to sort on','index_uuid' => 'FwdgBXbyRq-5E0F3sa4LTA'},'node' => 'vSTPqetISteesIkQSA_Ehg','index' => 'koha_kohadev_authorities'}],'phase' => 'query','reason' => 'all shards failed','root_cause' => [{'type' => 'query_shard_exception','index' => 'koha_kohadev_authorities','reason' => 'No mapping found for [Heading__sort.phrase] in order to sort on','index_uuid' => 'FwdgBXbyRq-5E0F3sa4LTA'}]}}} Unable to perform your search. Please try again. Anyone able to help or point me in the right direction? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was doing a 'standard' search in authorities search, without changing any settings. What do you mean by none? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nicolas, thx! 'None' works. Is there a bug already about the broken sorting for authorities with Elasticsearch? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Nicolas Legrand from comment #18)

(In reply to Katrin Fischer from comment #17)

...

Hi Nicolas, thx! 'None' works.

Great!

...

Is there a bug already about the broken sorting for authorities with Elasticsearch?

I think it's Bug 19604. I cc Nick so he can confirm.

I believe that is correct, 19604 will at least improve the sorting situation -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, but I can' test this - I switched the sort to none, but the auto-complete feature triggers the same error for the sorting. I think we need to fix this first. [Request] ** [http://localhost:9200]-[400] [query_shard_exception] No mapping found for [Heading__sort.phrase] in order to sort on, with: {"index_uuid":"FwdgBXbyRq-5E0F3sa4LTA","index":"koha_kohadev_authorities"}, called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at /usr/share/perl5/Catmandu/Store/ElasticSearch/Bag.pm line 167. With vars: {'body' => {'status' => 400,'error' => {'failed_shards' => [{'index' => 'koha_kohadev_authorities','node' => 'vSTPqetISteesIkQSA_Ehg','reason' => {'index' => 'koha_kohadev_authorities','index_uuid' => 'FwdgBXbyRq-5E0F3sa4LTA','reason' => 'No mapping found for [Heading__sort.phrase] in order to sort on','type' => 'query_shard_exception'},'shard' => 0}],'type' => 'search_phase_execution_exception','root_cause' => [{'type' => 'query_shard_exception','reason' => 'No mapping found for [Heading__sort.phrase] in order to sort on','index_uuid' => 'FwdgBXbyRq-5E0F3sa4LTA','index' => 'koha_kohadev_authorities'}],'reason' => 'all shards failed','phase' => 'query','grouped' => bless( do{\(my $o = 1)}, 'JSON::PP::Boolean' )}},'request' => {'path' => '/koha_kohadev_authorities/data/_search','qs' => {},'ignore' => [],'mime_type' => 'application/json','serialize' => 'std','body' => {'sort' => [{'Heading__sort.phrase' => 'asc'}],'size' => 50,'from' => 0,'query' => {'bool' => {'should' => [{'wildcard' => {'Heading-Main.phrase' => 'sew*'}}]}}},'method' => 'GET'},'status_code' => 400} Unable to perform your search. Please try again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It seems it can't work right now without fixing authority sorting. We could also mark it BLOCKED instead if that is preferred. Hopefully it can be resolved soon! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77091&action=edit Bug 20273: (follow-up) Autocomplete use start instead of contains Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Depends on bug 19604 which needs clarifications and help in backporting to 18.05.x branch.. awaiting feedback there. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 Bug 20273 depends on bug 19604, which changed state. Bug 19604 Summary: Elasticsearch Fixes for build_authorities_query for auth searching https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.