[Bug 12438] New: Bad encoding in acquisition basket
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 Bug ID: 12438 Summary: Bad encoding in acquisition basket Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org We noticed a bad encoding (diacritics replaced by <?>) in acquisition basket when updating a server to Debian Wheezy. We found it comes from a query containing biblio.title twice. Maybe the mysql newer version creates this side-effect. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |cgi-bin/koha/acqui/basket.p | |l?basketno=x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 --- Comment #1 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 28911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28911&action=edit Bug 12438 - Bad encoding in acquisition basket We noticed a bad encoding (diacritics replaced by <?>) in acquisition basket when updating a server to Debian Wheezy. We found it comes from a query containing biblio.title twice. Maybe the mysql newer version creates this side-effect. Test plan : - Create an order on a record containing a diacritic in title - Look at the basket : cgi-bin/koha/acqui/basket.pl?basketno=x => Without the patch the record title is bad encoded (with <?>) => With this patch the record title is well encoded - Check also basket CSV export -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi@cineca.it --- Comment #2 from Paola Rossi <paola.rossi@cineca.it> --- It seems to me that this problem is going to be solved by 11944. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11944 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 --- Comment #3 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Paola Rossi from comment #2)
It seems to me that this problem is going to be solved by 11944. Maybe, but also the SQL query is wrong. There is no need to add biblio.title when there is biblio.*
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Paola Rossi <paola.rossi@cineca.it> --- Thanks, Fridolin I've applied against master 3.17.00.008 Everything's OK. So I've passed tha patch to "Signed Off" status. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28911|0 |1 is obsolete| | --- Comment #5 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 29209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29209&action=edit 28911: Bug 12438 - Bad encoding in acquisition basket -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29209|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29340&action=edit [PASSED QA] Bug 12438 - Bad encoding in acquisition basket We noticed a bad encoding (diacritics replaced by <?>) in acquisition basket when updating a server to Debian Wheezy. We found it comes from a query containing biblio.title twice. Maybe the mysql newer version creates this side-effect. Test plan : - Create an order on a record containing a diacritic in title - Look at the basket : cgi-bin/koha/acqui/basket.pl?basketno=x => Without the patch the record title is bad encoded (with <?>) => With this patch the record title is well encoded - Check also basket CSV export Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Good catch! Works as expected, passes tests and QA script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Fridolin! Note: I pushed it because I think the duplicated biblio.title has to be removed. It hides the real problem, but as bug 11944 actually solves the problem (tried it), I feel good about it making into the stable branches for a short term solution. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Beautiful! This patch fixes the problem that I was having! It's worth mentioning that we only had this problem on a Debian Squeeze server. When we dumped the data and loaded it into a Koha instance on an OpenSuse server, we didn't get the <?> replacing the diacritics. It worked perfectly. So...not really sure what was going on there, but I'm just happy at this point to have a fix of the symptom. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 3.12.x! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_4_candidate CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 --- Comment #10 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |gmcharlt@gmail.com --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.4. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org